Re: [PATCHv2 14/16] ARM: OMAP3: hwmod data: cleanup data for IOMMUs

2014-02-27 Thread Florian Vaussard
Hi, On 02/26/2014 06:59 PM, Suman Anna wrote: > Tony, > > On 02/26/2014 11:18 AM, Tony Lindgren wrote: >> * Suman Anna [140213 10:19]: >>> From: Florian Vaussard >>> >>> The irq numbers, ocp address space and device attribute data >>> have all

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-24 Thread Florian Vaussard
Hi, On 02/13/2014 07:15 PM, Suman Anna wrote: > From: Florian Vaussard > > This patch adds the iommu bindings for all OMAP2+ SoCs. Apart from > the standard bindings used by OMAP peripherals, this patch uses a > 'dma-window' (already used by Tegra SMMU) and adds two OMA

Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2014-01-15 Thread Florian Vaussard
Hi Suman, So back to this... On 12/24/2013 12:35 AM, Anna, Suman wrote: > Hi Florian, > [...] >> >> If omap_iommu_probe() fails, the init will have called bus_set_iommu() >> anyways. Thus, when a driver request the iommu by calling >> iommu_domain_alloc(), it will succeed (but iommu_attach_dev

Re: [PATCH 3/7] iommu/omap: Convert to devicetree

2014-01-15 Thread Florian Vaussard
Hi On 01/02/2014 02:01 AM, Sebastian Reichel wrote: > Hi, > > On Thu, Jan 02, 2014 at 01:13:42AM +0100, Laurent Pinchart wrote: >>> + .of_match_table = omap_iommu_of_match, >> >> If CONFIG_OF isn't defined (pretty unlikely I agree, but a possibility you >> seem to be prepared for nonet

Re: [PATCH 6/7] ARM: OMAP2+: Remove legacy data from hwmod for omap3 isp iommu

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:08 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> The data are now passed using the devicetree. > > Patch is good by itself. A similar change is needed for the IVA > MMU as well. > As I under

Re: [PATCH 3/7] iommu/omap: Convert to devicetree

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:48 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> As OMAP2+ is moving to a full DT boot for 3.14, commit 7ce93f3 >> "ARM: OMAP2+: Fix more missing data for omap3.dtsi file" adds >> bas

Re: [PATCH 0/7] Fix omap-iommu probe and convert to DT for 3.14

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 07:52 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> OMAP2+ is heading towards a full device tree boot for 3.14. Currently, >> the iommu used by the OMAP3 camera subsystem is not yet converted. It &

Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:02 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> Currently, bus_set_iommu() is done in omap_iommu_init(). However, >> omap_iommu_probe() can fail in a number of ways, leaving the platform >> bus w

Re: [PATCH 5/7] ARM: dts: Complete data for isp iommu

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:12 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> Add missing information required to probe the iommu for the camera >> subsystem. >> >> Signed-off-by: Florian Vaussard >> --

Re: [PATCH 4/7] iommu/omap: Allow enable/disable even without pdata

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:05 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> When booting with a devietree, no platform data is provided. Do not >> prematurely >> exit iommu_enable() and iommu_disable() in such a case. >

[PATCH 0/7] Fix omap-iommu probe and convert to DT for 3.14

2013-12-17 Thread Florian Vaussard
[2] g...@github.com:vaussard/linux.git overo-for-3.14/iommu/dt Florian Vaussard (7): iommu/omap: Do bus_set_iommu() only if probe() succeeds iommu/omap: omap_iommu_attach() should return ENODEV, not NULL iommu/omap: Convert to devicetree iommu/omap: Allow enable/disable even without pdata ARM

[PATCH 4/7] iommu/omap: Allow enable/disable even without pdata

2013-12-17 Thread Florian Vaussard
When booting with a devietree, no platform data is provided. Do not prematurely exit iommu_enable() and iommu_disable() in such a case. Signed-off-by: Florian Vaussard --- drivers/iommu/omap-iommu.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/iommu

[PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2013-12-17 Thread Florian Vaussard
Currently, bus_set_iommu() is done in omap_iommu_init(). However, omap_iommu_probe() can fail in a number of ways, leaving the platform bus with a dangling reference to a non-initialized iommu. Perform bus_set_iommu() only if omap_iommu_probe() succeed. Signed-off-by: Florian Vaussard

[PATCH 5/7] ARM: dts: Complete data for isp iommu

2013-12-17 Thread Florian Vaussard
Add missing information required to probe the iommu for the camera subsystem. Signed-off-by: Florian Vaussard --- arch/arm/boot/dts/omap3.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index daabf99

[PATCH 7/7] ARM: OMAP2+: Remove platform-specific omap-iommu

2013-12-17 Thread Florian Vaussard
With full DT boot, the platform specific part of the OMAP iommu is not useful anymore. Signed-off-by: Florian Vaussard --- arch/arm/mach-omap2/Makefile | 3 -- arch/arm/mach-omap2/omap-iommu.c | 79 2 files changed, 82 deletions(-) delete mode

[PATCH 3/7] iommu/omap: Convert to devicetree

2013-12-17 Thread Florian Vaussard
uses 'dma-window' (already used by Tegra SMMU) and adds a custom 'ti,#tlb-entries' binding. Signed-off-by: Florian Vaussard --- .../devicetree/bindings/iommu/ti,omap-iommu.txt| 19 arch/arm/mach-omap2/omap-iommu.c | 5 +

[PATCH 6/7] ARM: OMAP2+: Remove legacy data from hwmod for omap3 isp iommu

2013-12-17 Thread Florian Vaussard
The data are now passed using the devicetree. Signed-off-by: Florian Vaussard --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 8 1 file changed, 8 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c index 0477131..6dccd46

[PATCH 2/7] iommu/omap: omap_iommu_attach() should return ENODEV, not NULL

2013-12-17 Thread Florian Vaussard
() should return ENODEV, not NULL. Signed-off-by: Florian Vaussard --- drivers/iommu/omap-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index ee83bcc..385bf5e 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers