Re: [RESEND v2] iommu/vt-d: Use passthrough mode for the Intel IPUs

2021-04-20 Thread Grant Grundler
On Tue, Apr 20, 2021 at 11:02 AM Sakari Ailus wrote: > > Hi Bingbu, > > Thanks for the patch. > > On Tue, Apr 20, 2021 at 10:48:33AM +0800, Bingbu Cao wrote: > > Intel IPU(Image Processing Unit) has its own (IO)MMU hardware, > > The IPU driver allocates its own page table that is not mapped > > vi

Re: [PATCH 1/3] iommu/rockchip: rk3288 iommu driver

2014-10-07 Thread Grant Grundler
, the iommu domain maintains a list of iommu devices which are > attached. This driver relies on the iommu core to ensure that all devices > have detached before destroying a domain. > > Signed-off-by: Daniel Kurtz > Signed-off-by: Simon Xue Reviewed-by: Grant Grundler

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Grant Grundler
On Wed, May 21, 2014 at 2:32 AM, Arnd Bergmann wrote: > On Wednesday 21 May 2014 11:02:45 Thierry Reding wrote: >> On Wed, May 21, 2014 at 10:54:42AM +0200, Arnd Bergmann wrote: >> >> > Right. As long as we always unmap the buffers from the IOMMU after they >> > have stopped being in use, it's ver

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-05-01 Thread Grant Grundler
On Thu, May 1, 2014 at 6:29 AM, Arnd Bergmann wrote: ... >> GICv3 can descriminate between different MSI senders based on ID >> signals on the bus. > > Any idea what this is good for? Do we have to use it? It probably doesn't > fit very well into the way Linux handles MSIs today. I can see this b

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-04-29 Thread Grant Grundler
On Tue, Apr 29, 2014 at 11:16 AM, Dave Martin wrote: ... > An IOMMU is really a specialised bridge Is a GART a bridge? IOMMUs can provide three basic functions: 1) remap address space to reach phys mem ranges that the device is otherwise not capable of accessing (classic 32-bit DMA to reach 64-b

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-19 Thread Grant Grundler
On Wed, Mar 19, 2014 at 10:30 AM, Tomasz Figa wrote: ... > As I said, AFAIK the trend is to get rid of ordering by initcalls and make > sure that drivers can handle missing dependencies properly, even for > "services" such as DMA, GPIO, clocks and so on, which after all are provided > by normal dr

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-19 Thread Grant Grundler
On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa wrote: ... >> Device driver is not only for the scholarship but also for the real use. > > Huh? I'm not sure what kind of comment is this. I'm guessing Cho meant: "This isn't an academic exercise - I have a real use case that requires reference countin

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-19 Thread Grant Grundler
On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa wrote: ... > No. Proper Linux drivers must support deferred probing mechanism and there > should be no assumptions about probing orders. Using other initcall level > than module_initcall for particular drivers is strongly discouraged. That's true for "

Re: [PATCH v11 24/27] iommu/exynos: use exynos-iommu specific typedef

2014-03-18 Thread Grant Grundler
On Thu, Mar 13, 2014 at 10:13 PM, Cho KyongHo wrote: > This commit introduces sysmmu_pte_t for page table entries and > sysmmu_iova_t vor I/O virtual address that is manipulated by > exynos-iommu driver. The purpose of the typedef is to remove > dependencies to the driver code from the change of C

Re: [PATCH v11 02/27] iommu/exynos: add missing cache flush for removed page table entries

2014-03-14 Thread Grant Grundler
all and large page entries > in exynos_iommu_unmap(). Missing cache flush of removed page table > entries can cause missing page fault interrupt when a master IP > accesses an unmapped area. > > Reviewed-by: Tomasz Figa > Tested-by: Grant Grundler > Signed-off-by: Cho KyongHo

Re: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-07-26 Thread Grant Grundler
On Fri, Jul 26, 2013 at 4:28 AM, Cho KyongHo wrote: > Signed-off-by: Cho KyongHo > --- > .../bindings/iommu/samsung,exynos4210-sysmmu.txt | 103 +++ > arch/arm/boot/dts/exynos4.dtsi | 122 > arch/arm/boot/dts/exynos4210.dtsi | 25 ++ > arch