On 12/13/2017 9:58 AM, Alex Williamson wrote:
On Wed, 13 Dec 2017 15:13:55 +0800
Peter Xu wrote:
On Tue, Dec 12, 2017 at 03:43:08PM -0700, Alex Williamson wrote:
[...]
diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
index 9a7ffd13c7f0..87888b102057 100644
--- a/drivers/iommu/dmar.c
On 12/13/2017 11:15 AM, Alex Williamson wrote:
On Wed, 13 Dec 2017 10:41:47 -0600
"Hook, Gary" wrote:
On 12/13/2017 9:58 AM, Alex Williamson wrote:
On Wed, 13 Dec 2017 15:13:55 +0800
Peter Xu wrote:
On Tue, Dec 12, 2017 at 03:43:08PM -0700, Alex Williamson wrote:
[...]
On 2/13/2018 8:22 AM, Joerg Roedel wrote:
On Tue, Jan 30, 2018 at 07:04:27PM -0600, Gary R Hook wrote:
+ dev_err(dev, "ILLEGAL_DEV_TABLE_ENTRY device=%02x:%02x.%x "
+ "address=0x%016llx flags=0x%04x]\n",
+ PCI_BUS_NUM(devid), PCI_SLOT(dev
On 2/13/2018 11:00 AM, Joerg Roedel wrote:
On Tue, Feb 13, 2018 at 10:47:55AM -0500, Hook, Gary wrote:
dev_err(&iommu->dev->dev, "ILLEGAL...
I think its more something like iommu->iommu->dev.
Without actually running a driver and getting some debug info,
On 2/14/2018 6:49 AM, Joerg Roedel wrote:
On Tue, Feb 13, 2018 at 02:24:56PM -0500, Hook, Gary wrote:
Without actually running a driver and getting some debug info, I'll just
say that my example compiled, the amd_iommu structure points to a pci_dev
which contains a device, and th
On 4/13/2018 7:55 PM, Mehta, Sohil wrote:
On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
+struct dentry *iommu_debugfs_setup(void)
+{
+ if (!debugfs_initialized())
This check is probably not needed.
Ah, so it isn't. Thank you.
+ return NULL;
+
+ if
On 4/13/2018 8:08 PM, Mehta, Sohil wrote:
On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
+
+void amd_iommu_debugfs_setup(struct amd_iommu *iommu)
+{
+ char name[MAX_NAME_LEN + 1];
+ struct dentry *d_top;
+
+ if (!debugfs_initialized())
Probably not needed.
Right.
On 4/16/2018 8:52 PM, Mehta, Sohil wrote:
On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile
index 5eb1121d54b9..0ca250f626d9 100644
--- a/drivers/iommu/Makefile
+++ b/drivers/iommu/Makefile
@@ -11,6 +11,7 @@ obj-$(CONFIG_IOMMU_IOV
On 4/6/2018 9:17 AM, Gary R Hook wrote:
Provide base enablement for using debugfs to expose internal data of
an IOMMU driver. When called, create the /sys/kernel/debug/iommu
directory. Emit a strong warning at boot time to indicate that this
feature is enabled.
This patch adds a top-level funct
On 4/17/2018 1:55 PM, Robin Murphy wrote:
On 17/04/18 18:36, Hook, Gary wrote:
On 4/13/2018 7:55 PM, Mehta, Sohil wrote:
On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
+struct dentry *iommu_debugfs_setup(void)
+{
+ if (!debugfs_initialized())
This check is probably not needed
On 4/18/2018 4:16 PM, Mehta, Sohil wrote:
On Wed, 2018-04-18 at 08:31 +, Yang, Shunyong wrote:
Maybe the original design is to call debugfs_initialized() before
calling debugfs_create_xxx()?
I am unaware of the original design. Someone else would probably have
more context. However, lookin
On 5/7/2018 6:47 PM, kbuild test robot wrote:
Hi Gary,
I imagine these questions have been asked before, so I'll ask for
forgiveness up front.
Thank you for the patch! Yet something to improve:
[auto build test ERROR on iommu/next]
[also build test ERROR on v4.17-rc4 next-20180507]
[if you
On 7/3/2018 10:55 AM, Joe Perches wrote:
On Tue, 2018-07-03 at 07:56 -0500, Gary R Hook wrote:
On 07/03/2018 05:07 AM, Joe Perches wrote:
On Tue, 2018-07-03 at 07:40 +0100, Colin King wrote:
Currently tag is being assigned but not used, it is missing from
the dev_err message, so add it in.
Cl
On 7/3/2018 11:24 AM, Colin Ian King wrote:
On 03/07/18 17:21, Hook, Gary wrote:
On 7/3/2018 10:55 AM, Joe Perches wrote:
On Tue, 2018-07-03 at 07:56 -0500, Gary R Hook wrote:
On 07/03/2018 05:07 AM, Joe Perches wrote:
On Tue, 2018-07-03 at 07:40 +0100, Colin King wrote:
Currently tag is
14 matches
Mail list logo
