[PATCH v2 01/10] driver core: Add a wrapper around __device_release_driver()

2016-06-17 Thread Marek Szyprowski
.@intel.com> Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/base/dd.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 16688f50729c..d9e76e9205c7 100644 --- a/drivers/

Re: [PATCH 1/3] PM / Runtime: Add notifiers for device runtime PM events

2016-06-17 Thread Marek Szyprowski
Hi Rafael, On 2016-06-08 19:18, Rafael J. Wysocki wrote: On Wed, Jun 8, 2016 at 12:25 PM, Marek Szyprowski <m.szyprow...@samsung.com> wrote: From: Krzysztof Kozlowski<k.kozlow...@samsung.com> Allow drivers registering for certain runtime PM events of other devices. Some driv

Re: [RFC PATCH 15/15] iommu/exynos: update to use iommu big-endian

2016-06-09 Thread Marek Szyprowski
ed-by: Marek Szyprowski <m.szyprow...@samsung.com> Just to keep my curiosity satisfied - what's the reason to use big-endian on ARM? Good luck with fixing the kernel and userspace codes, which usually assume little-endian is the only possible order! --- Cc: Marek Szyprowski <m.szypr

[PATCH 1/3] PM / Runtime: Add notifiers for device runtime PM events

2016-06-08 Thread Marek Szyprowski
erform some necessary steps. For example Exynos IOMMU has to save its context. Based on previous work of Sylwester Nawrocki <s.nawro...@samsung.com>. Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>

[PATCH 3/3] iommu/exynos: Add proper runtime pm support

2016-06-08 Thread Marek Szyprowski
prevents respective power domains to be turned off when master's device is not used. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 211 +-- 1 file changed, 101 insertions(+), 110 deletions(-) diff --git a/d

[PATCH 2/3] iommu/exynos: Remove excessive, useless debug

2016-06-08 Thread Marek Szyprowski
Remove excessive, useless debug about skipping TLB invalidation, which is a normal situation when more aggressive power management is enabled. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/d

[PATCH 0/3] Exynos IOMMU: proper runtime pm support

2016-06-08 Thread Marek Szyprowski
ement" thread: http://www.spinics.net/lists/arm-kernel/msg505695.html Best regards Marek Szyprowski Samsung R Institute Poland Krzysztof Kozlowski (1): PM / Runtime: Add notifiers for device runtime PM events Marek Szyprowski (2): iommu/exynos: Remove excessive, useless debug iommu/e

[PATCH 4/3] iommu/exynos: Prepare for deferred probe support

2016-05-23 Thread Marek Szyprowski
Register iommu_ops at the end of successful probe instead of doing that unconditionally. This makes Exynos IOMMU driver ready for deferred probe caused by not-yet-available clocks. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- I'm sorry for the confussing patch number. This

[PATCH 3/3] iommu/exynos: Prepare clocks when needed, not in driver probe

2016-05-23 Thread Marek Szyprowski
() it with BUG_ON(). Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 54 +--- 1 file changed, 26 insertions(+), 28 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 018bcd

[PATCH 2/3] iommu/exynos: Fix master clock management for inactive SYSMMU

2016-05-23 Thread Marek Szyprowski
If SYSMMU controller is not active, there is no point in enabling master's clock just for doing the the of internal state. This patch moves enabling that clock to the block which actually does the register access. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers

[PATCH 0/3] Exynos IOMMU: improve clock management

2016-05-23 Thread Marek Szyprowski
regards Marek Szyprowski Samsung R Institute Poland Marek Szyprowski (3): iommu/exynos: Return proper errors from getting clocks iommu/exynos: Fix master clock management for inactive SYSMMU iommu/exynos: Prepare clocks when needed, not in driver probe drivers/iommu/exynos-iommu.c | 95

[PATCH 1/3] iommu/exynos: Return proper errors from getting clocks

2016-05-23 Thread Marek Szyprowski
This patch reworks driver probe code to propagate error codes from clk_get() operation. This will allow to properly handle deferred probe in the future. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.

[PATCH] iommu/exynos: Suppress unbinding to prevent system failure

2016-05-20 Thread Marek Szyprowski
by such operation. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> CC: sta...@vger.kernel.org # v4.2+ --- drivers/iommu/exynos-iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 558a40d3a6a0..d365c40a7b84

Re: [RFC 0/9] IOMMU probe deferral support

2016-05-12 Thread Marek Szyprowski
iommu controllers cannot get their clocks early enough. Tested-by: Marek Szyprowski <m.szyprow...@samsung.com> Now associating a group with an master has become mandatory and happens when the master is added to the bus using BUS_ADD_DEVICE from iommu core. But the iommu has to be ready before this

Re: [RFC PATCH 06/11] drivers: iommu: make of_xlate() interface DT agnostic

2016-04-20 Thread Marek Szyprowski
Hi Lorenzo, On 2016-04-19 13:30, Lorenzo Pieralisi wrote: Hi Marek, On Tue, Apr 19, 2016 at 10:28:02AM +0200, Marek Szyprowski wrote: Hello, On 2016-04-14 19:25, Lorenzo Pieralisi wrote: On systems booting with ACPI, the IOMMU drivers require the same kind of id mapping carried out

Re: [RFC PATCH 06/11] drivers: iommu: make of_xlate() interface DT agnostic

2016-04-19 Thread Marek Szyprowski
gmail.com> Cc: Will Deacon <will.dea...@arm.com> Cc: Hanjun Guo <hanjun@linaro.org> Cc: Rob Herring <robh...@kernel.org> Cc: Krzysztof Kozlowski <k.kozlow...@samsung.com> Cc: Robin Murphy <robin.mur...@arm.com> Cc: Tomasz Nowicki <t...@semihalf.com> Cc: Joe

Re: [RFC 3/3] iommu: dma-iommu: use common implementation also on ARM architecture

2016-03-15 Thread Marek Szyprowski
Hello, On 2016-03-15 12:18, Magnus Damm wrote: Hi Marek, On Fri, Feb 19, 2016 at 5:22 PM, Marek Szyprowski <m.szyprow...@samsung.com> wrote: This patch replaces ARM-specific IOMMU-based DMA-mapping implementation with generic IOMMU DMA-mapping code shared with ARM64 architecture. Th

Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL

2016-03-02 Thread Marek Szyprowski
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index b066504..cb57bda 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -1347,8 +1347,8 @@ static int __init exynos_iommu_of_setup(struct

[PATCH] iommu/exynos: Use proper readl/writel register interface

2016-02-29 Thread Marek Szyprowski
Drivers should use generic readl/writel calls to access HW registers, so replace all __raw_readl/writel with generic version. Suggested-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-

[RFC 3/3] iommu: dma-iommu: use common implementation also on ARM architecture

2016-02-19 Thread Marek Szyprowski
, which rely on initialization from generic arch_setup_dna_ops() interface. Code, which used old arm_iommu_* functions must be updated to new interface. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- arch/arm/Kconfig | 22 +- arch/arm/include/asm/de

[RFC 1/3] drm/exynos: rewrite IOMMU support code

2016-02-19 Thread Marek Szyprowski
on of real devices for DMA-mapping operations, such hacks are no longer needed. The only requirement is to have all the devices, which build Exynos DRM, attached to the same IOMMU domain (to share IO address space). Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/g

[RFC 0/3] Unify IOMMU-based DMA-mapping code for ARM and ARM64

2016-02-19 Thread Marek Szyprowski
eeded (there are all needed patches for Exynos subarch, which have been posted as separate patchsets): https://git.linaro.org/people/marek.szyprowski/linux-srpol.git v4.5-dma-iommu-unification Patches are based on Linux v4.5-rc4 vanilla tree. Best regards Marek Szyprowski Samsung R Institute Po

[RFC 2/3] iommu: dma-iommu: move IOMMU/DMA-mapping code from ARM64 arch to drivers

2016-02-19 Thread Marek Szyprowski
This patch moves all the IOMMU-based DMA-mapping code from arch/arm64/mm to drivers/iommu/dma-iommu-ops.c. This way it can be easily shared with ARM architecture, which will also use them. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- arch/arm64/include/asm/dma-mapping.h

[PATCH v2 10/13] iommu: exynos: update device tree documentation

2016-02-18 Thread Marek Szyprowski
Exynos SYSMMU bindings documentation was merged before generic IOMMU binding have been introduced. This patch updates documentation to match current state. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- .../devicetree/bindings/iommu/samsung,sysmmu.txt

[PATCH v2 02/13] iommu: exynos: add support for IOMMU_DOMAIN_DMA domain type

2016-02-18 Thread Marek Szyprowski
This patch adds support for DMA domain type. Such domain have DMA cookie prepared and can be used by generic DMA-IOMMU glue layer. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 19 +++ 1 file changed, 15 insertions(+), 4 del

[PATCH v2 11/13] iommu: exynos: add support for v5 SYSMMU

2016-02-18 Thread Marek Szyprowski
5433 SoCs. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- .../devicetree/bindings/iommu/samsung,sysmmu.txt | 5 +- drivers/iommu/Kconfig | 2 +- drivers/iommu/exynos-iommu.c | 187 +++-- 3 files change

[PATCH v2 13/13] iommu: exynos: support multiple attach_device calls

2016-02-18 Thread Marek Szyprowski
IOMMU core calls attach_device callback without detaching device from the previous domain. This patch adds support for such unballanced calls. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 72

[PATCH v2 06/13] iommu: exynos: refactor fault handling code

2016-02-18 Thread Marek Szyprowski
This patch provides a new implementation for page fault handing code. The new implementation is ready for future extensions. No functional changes have been made. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c

[PATCH v2 09/13] iommu: exynos: add support for SYSMMU controller with bogus version reg

2016-02-18 Thread Marek Szyprowski
SYSMMU on some SoCs reports bogus values in VERSION register. Force hardware version to 1.0 for such controllers. This patch also moves reading version register to driver's probe() function. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.

[PATCH v2 04/13] iommu: exynos: simplify master clock operations

2016-02-18 Thread Marek Szyprowski
All clock API function can be called on NULL clock, so simplify code avoid checking of master clock presence. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 32 1 file changed, 12 insertions(+), 20 deletions(-)

[PATCH v2 07/13] iommu: exynos: refactor init config code

2016-02-18 Thread Marek Szyprowski
This patch rewrites sysmmu_init_config function to make it easier to read and understand. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH v2 08/13] iommu: exynos: unify code for fldp cache invalidation

2016-02-18 Thread Marek Szyprowski
This patch simplifies the code for handling of flpdcache invalidation. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/

[PATCH v2 01/13] iommu: exynos: rework iommu group initialization

2016-02-18 Thread Marek Szyprowski
This patch replaces custom code in add_device implementation with iommu_group_get_for_dev() call and provides the needed callback. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 27 --- 1 file changed, 16 insertions(

[PATCH v2 05/13] iommu: exynos: refactor code (no direct register access)

2016-02-18 Thread Marek Szyprowski
This patch changes some internal functions to have access to the state of sysmmu device instead of having only it's registers. This will make the code ready for future extensions. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.

[PATCH v2 00/13] SYSMMU driver update and support for Exynos 5433

2016-02-18 Thread Marek Szyprowski
architecture. Best regards Marek Szyprowski Samsung R Institute Poland Changelog: v2: - added support for multiple calls of device_attach (without detach), needed for default domain handling in iommu core (patch no 13), more information in the following thread: https://lists.linaro.org

[PATCH v2 03/13] iommu: exynos: remove ARM-specific cache flush interface

2016-02-18 Thread Marek Szyprowski
because all SYSMMU controllers are in the same address space (where DMA address equals physical address) and the DMA-mapping calls are done mainly to flush CPU cache to make changes visible to SYSMMU controllers. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-i

Re: [PATCH 1/2] iommu: call detach also for default_domain before attaching to new one

2016-02-17 Thread Marek Szyprowski
Hello, On 2016-02-17 12:14, Joerg Roedel wrote: On Wed, Feb 17, 2016 at 08:35:10AM +0100, Marek Szyprowski wrote: Huh, I wasn't aware of this change in the iommu drivers api. For some drivers attach/detach callbacks does something more than just programming page table base register, like

Re: [PATCH 1/2] iommu: call detach also for default_domain before attaching to new one

2016-02-16 Thread Marek Szyprowski
Hello, On 2016-02-16 16:59, Joerg Roedel wrote: On Tue, Feb 16, 2016 at 03:40:31PM +0100, Marek Szyprowski wrote: This patch ensures that devices attached to the default_domain will be first detached from it before attaching to new domain. To avoid forward declaration, __iommu_attach_group

[PATCH 06/11] iommu: exynos: refactor fault handling code

2016-02-16 Thread Marek Szyprowski
This patch provides a new implementation for page fault handing code. The new implementation is ready for future extensions. No functional changes have been made. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c

[PATCH 10/11] iommu: exynos: add support for v5 SYSMMU

2016-02-16 Thread Marek Szyprowski
5433 SoCs. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- .../devicetree/bindings/iommu/samsung,sysmmu.txt | 5 +- drivers/iommu/Kconfig | 2 +- drivers/iommu/exynos-iommu.c | 195 +++-- 3 files change

[PATCH 05/11] iommu: exynos: refactor code (no direct register access)

2016-02-16 Thread Marek Szyprowski
This patch changes some internal functions to have access to the state of sysmmu device instead of having only it's registers. This will make the code ready for future extensions. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.

[PATCH 01/11] iommu: exynos: rework iommu group initialization

2016-02-16 Thread Marek Szyprowski
This patch replaces custom code in add_device implementation with iommu_group_get_for_dev() call and provides the needed callback. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 27 --- 1 file changed, 16 insertions(

[PATCH 02/11] iommu: exynos: add support for IOMMU_DOMAIN_DMA domain type

2016-02-16 Thread Marek Szyprowski
This patch adds support for DMA domain type. Such domain have DMA cookie prepared and can be used by generic DMA-IOMMU glue layer. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 19 +++ 1 file changed, 15 insertions(+), 4 del

[PATCH 11/11] iommu: exynos: add Maintainers entry for Exynos SYSMMU driver

2016-02-16 Thread Marek Szyprowski
Add Marek Szyprowski as maintainer for Exynos IOMMU driver. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7bd927e..1e9c4df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

[PATCH 07/11] iommu: exynos: refactor init config code

2016-02-16 Thread Marek Szyprowski
This patch rewrites sysmmu_init_config function to make it easier to read and understand. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH 03/11] iommu: exynos: remove ARM-specific cache flush interface

2016-02-16 Thread Marek Szyprowski
because all SYSMMU controllers are in the same address space (where DMA address equals physical address) and the DMA-mapping calls are done mainly to flush CPU cache to make changes visible to SYSMMU controllers. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-i

[PATCH 08/11] iommu: exynos: unify code for fldp cache invalidation

2016-02-16 Thread Marek Szyprowski
This patch simplifies the code for handling of flpdcache invalidation. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/

[PATCH 04/11] iommu: exynos: simplify master clock operations

2016-02-16 Thread Marek Szyprowski
All clock API function can be called on NULL clock, so simplify code avoid checking of master clock presence. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/exynos-iommu.c | 32 1 file changed, 12 insertions(+), 20 deletions(-)

[PATCH 09/11] iommu: exynos: update device tree documentation

2016-02-16 Thread Marek Szyprowski
Exynos SYSMMU bindings documentation was merged before generic IOMMU binding have been introduced. This patch updates documentation to match current state. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- .../devicetree/bindings/iommu/samsung,sysmmu.txt

[PATCH 00/11] SYSMMU driver update and support for Exynos 5433

2016-02-16 Thread Marek Szyprowski
architecture. Best regards Marek Szyprowski Samsung R Institute Poland Patch summary: Marek Szyprowski (11): iommu: exynos: rework iommu group initialization iommu: exynos: add support for IOMMU_DOMAIN_DMA domain type iommu: exynos: remove ARM-specific cache flush interface iommu: exynos

[PATCH 0/2] iommu: fix handling of attach/detach for default domains

2016-02-16 Thread Marek Szyprowski
Szyprowski Samsung R Institute Poland Patch summary: Marek Szyprowski (2): iommu: call detach also for default_domain before attaching to new one iommu: fix default domain handling in __iommu_detach_group() drivers/iommu/iommu.c | 48 +++- 1 file changed

[PATCH 1/2] iommu: call detach also for default_domain before attaching to new one

2016-02-16 Thread Marek Szyprowski
This patch ensures that devices attached to the default_domain will be first detached from it before attaching to new domain. To avoid forward declaration, __iommu_attach_group() function has been moved to new place in the source code. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.

[PATCH 2/2] iommu: fix default domain handling in __iommu_detach_group()

2016-02-16 Thread Marek Szyprowski
This patch ensures that all devices will be first detached from the provided domain and then attached to the default_domain if such has been provided. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/iommu/iommu.c | 12 ++-- 1 file changed, 6 insertions

Re: [PATCH v6 1/3] iommu: Implement common IOMMU ops for DMA mapping

2015-11-17 Thread Marek Szyprowski
parameters like per-page offset and dma address/len. Maybe it would be better if something like page vector (or PFN vector to solve the problem of mapping buffers that cannot be described by pages) have been introduced and operations like dma_map_vector() will make thing much more clear. I ca

Re: [RFC/PATCH] media: omap3isp: Set maximum DMA segment size

2015-11-17 Thread Marek Szyprowski
add a check in videobuf2-dc. Best regards -- Marek Szyprowski, PhD Samsung R Institute Poland On 2015-11-09 15:18, Laurent Pinchart wrote: Hello everybody, Ping ? On Tuesday 13 October 2015 16:18:36 Laurent Pinchart wrote: The maximum DMA segment size controls the IOMMU mapping granularity.

Re: [PATCH] iommu: Ignore -ENODEV errors from add_device call-back returning -ENODEV

2015-06-29 Thread Marek Szyprowski
Hello, On 2015-06-29 10:35, Joerg Roedel wrote: Hi Marek, On Thu, Jun 25, 2015 at 03:10:44PM +0200, Marek Szyprowski wrote: + /* skip devices which doesn't have sysmmu controller */ if (!has_sysmmu(dev)) - return -ENODEV; + return 0; Thanks

[PATCH] iommu/exynos: Skip unsupported devices instead of returning -ENODEV

2015-06-25 Thread Marek Szyprowski
skip them gently instead of returning error, which would be propagated up to bus_set_iommu() and cause initialization failure. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- Please queue this patch to v4.2-rcX line. It fixes regression introduced by a commit merged in parallel

Re: [PATCH v3 (alternative) 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-15 Thread Marek Szyprowski
Hello, On 2015-06-12 15:51, Inki Dae wrote: On 2015년 06월 12일 21:10, Inki Dae wrote: On 2015년 06월 12일 18:07, Marek Szyprowski wrote: One should not do any assumptions on the stare of the fimd hardware during driver initialization, so to properly reset fimd before enabling IOMMU, one should

[PATCH v4] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-15 Thread Marek Szyprowski
() function to ensure that any access to fimd registers will be performed with clocks and power domains enabled. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changelog: v4: - added temporary changing of ctx-pipe to -1

Re: [PATCH v2 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Marek Szyprowski
Hello, On 2015-06-11 17:04, Inki Dae wrote: On 2015년 06월 03일 17:26, Marek Szyprowski wrote: One should not do any assumptions on the stare of the fimd hardware during driver initialization, so to properly reset fimd before enabling IOMMU, one should ensure that all power domains and clocks

[PATCH v3 (alternative) 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Marek Szyprowski
() function to ensure that any access to fimd registers will be performed with clocks and power domains enabled. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changelog: v3 (alternative): - araranged code by moving fimd_

[PATCH v3 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Marek Szyprowski
() function to ensure that any access to fimd registers will be performed with clocks and power domains enabled. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changelog: v3: - replaced forward declaration and calls

Re: [PATCH v3 (alternative) 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Marek Szyprowski
Hello, On 2015-06-12 14:10, Inki Dae wrote: On 2015년 06월 12일 18:07, Marek Szyprowski wrote: One should not do any assumptions on the stare of the fimd hardware during driver initialization, so to properly reset fimd before enabling IOMMU, one should ensure that all power domains and clocks

Re: [PATCH v2 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-08 Thread Marek Szyprowski
Hello, On 2015-06-04 15:13, Inki Dae wrote: On 2015년 06월 04일 22:08, Inki Dae wrote: On 2015년 06월 03일 17:26, Marek Szyprowski wrote: One should not do any assumptions on the stare of the fimd hardware during driver initialization, so to properly reset fimd before enabling IOMMU, one should

[PATCH v2 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-03 Thread Marek Szyprowski
() function to ensure that any access to fimd registers will be performed with clocks and power domains enabled. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 22

[PATCH v2 2/3] drm/exynos: iommu: detach from default dma-mapping domain on init

2015-06-03 Thread Marek Szyprowski
This patch adds code, which detach sub-device nodes from default iommu domain if such has been configured. This lets Exynos DRM driver to properly attach sub-devices to its own, common for all sub-devices domain. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Tested-by: Javier Martinez

[PATCH v2 3/3] drm/exynos: iommu: improve a check for non-iommu dma_ops

2015-06-03 Thread Marek Szyprowski
DRM Exynos driver is relying on dma-mapping internal structures when used with IOMMU enabled. This patch partially hides dma-mapping internal things by using proper get_dma_ops/set_dma_ops calls. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/gpu/drm/exynos

[PATCH v2 0/3] Exynos SYSMMU (IOMMU) updates for Exynos DRM

2015-06-03 Thread Marek Szyprowski
rebased onto latest exynos-drm-next branch with atomic mode setting patches applied. Best regards Marek Szyprowski Samsung RD Institute Poland Marek Szyprowski (3): drm/exynos: fimd: ensure proper hw state in fimd_clear_channel() drm/exynos: iommu: detach from default dma-mapping domain

[PATCH 0/3] Exynos SYSMMU (IOMMU) updates for Exynos DRM

2015-06-01 Thread Marek Szyprowski
-mapping internals from Exynos DRM driver, a direct check for NULL has been replaced by more error-proof comparison of dma_get_ops() values. Inki: could you queue those patches to exynos-drm-next and get them merged to v4.2 to have it functional for the release? Best regards Marek Szyprowski Samsung

[PATCH 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-01 Thread Marek Szyprowski
to ensure that any access to fimd registers will be performed with clocks and power domains enabled. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 26

[PATCH 2/3] drm/exynos: iommu: detach from default dma-mapping domain on init

2015-06-01 Thread Marek Szyprowski
This patch adds code, which detach sub-device nodes from default iommu domain if such has been configured. This lets Exynos DRM driver to properly attach sub-devices to its own, common for all sub-devices domain. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Tested-by: Javier Martinez

[PATCH 2/6] ARM: dts: exynos4: add sysmmu nodes

2015-06-01 Thread Marek Szyprowski
This patch adds System MMU nodes that are specific to Exynos4210/4x12 series. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi| 118 ++ arch/arm/boot/dts

[PATCH 4/6] ARM: dts: exynos4415: add sysmmu nodes

2015-06-01 Thread Marek Szyprowski
This patch adds System MMU nodes to all defined devices that are specific to Exynos4415 series. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/boot/dts/exynos4415.dtsi | 11 +++ 1 file changed, 11 insertions

[PATCH 0/6] Exynos SYSMMU (IOMMU) dts and arch updates

2015-06-01 Thread Marek Szyprowski
-domains') and added properties to jpeg codec merged recently. Best regards Marek Szyprowski Samsung RD Institute Poland Marek Szyprowski (6): ARM: Exynos: pm_domains: register power domain driver from core_initcall ARM: dts: exynos4: add sysmmu nodes ARM: dts: exynos3250: add sysmmu

[PATCH 5/6] ARM: dts: exynos5250: add sysmmu nodes

2015-06-01 Thread Marek Szyprowski
This patch adds System MMU nodes to all defined devices that are specific to Exynos5250 series. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 250 ++ 1

[PATCH 6/6] ARM: dts: exynos5420: add sysmmu nodes

2015-06-01 Thread Marek Szyprowski
This patch adds System MMU nodes to all defined devices that are specific to Exynos5420/5800/5422 series. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi | 183

[PATCH 1/6] ARM: Exynos: pm_domains: register power domain driver from core_initcall

2015-06-01 Thread Marek Szyprowski
with respective of_clk_* equivalents. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/mach-exynos/pm_domains.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/arch/arm/mach-exynos

[PATCH 3/6] ARM: dts: exynos3250: add sysmmu nodes

2015-06-01 Thread Marek Szyprowski
This patch adds System MMU nodes to the devices that are specific to Exynos3250 series. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi | 33 + 1 file changed, 33

Re: [RFC/PATCH 0/9] IOMMU probe deferral support

2015-05-27 Thread Marek Szyprowski
hackery in dma-mapping internal structures in Exynos DRM driver, but this is completely different story. You can add the following tag for the of/iommu/dma-mapping patches: Tested-by: Marek Szyprowski m.szyprow...@samsung.com [1] http://www.spinics.net/lists/arm-kernel/msg382787.html [2] http

Re: [PATCH v7 03/25] iommu: Init iommu-groups support earlier, in core_initcall

2015-05-25 Thread Marek Szyprowski
Hello, On 2015-05-23 18:23, Laurent Pinchart wrote: Hi Marek, Thank you for the patch. On Tuesday 19 May 2015 15:20:23 Marek Szyprowski wrote: iommu_group_alloc might be called very early in case of iommu controllers activated from of_iommu, so ensure that this part of subsystem is ready

Re: [PATCH v6 01/25] arm: dma-mapping: add support for creating reserved mappings in iova space

2015-05-19 Thread Marek Szyprowski
Hello, On 2015-05-06 16:01, Robin Murphy wrote: Hi Marek, On 04/05/15 09:15, Marek Szyprowski wrote: Some devices (like frame buffers) are enabled by bootloader and configured to perform DMA operations automatically (like displaying boot logo or splash screen). Such devices operate

[PATCH v7 17/25] iommu/exynos: Add callback for initializing devices from device tree

2015-05-19 Thread Marek Szyprowski
This patch adds implementation of of_xlate callback, which prepares masters device for attaching to IOMMU. This callback is called during creating devices from device tree. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/iommu/exynos-iommu.c | 28

[PATCH v7 24/25] ARM: DMA-mapping: add support for creating reserved mappings in iova space

2015-05-19 Thread Marek Szyprowski
by the respective driver. This patch adds support for iommu-reserved-mapping, which can be used to provide definitions for mappings that need to be created on system boot to let such devices (enabled by bootloader) to operate properly until respective driver is probed. Signed-off-by: Marek Szyprowski

[PATCH v7 23/25] ARM: dts: exynos5420: add sysmmu nodes

2015-05-19 Thread Marek Szyprowski
This patch adds System MMU nodes to all defined devices that are specific to Exynos5420/5800/5422 series. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi | 181

[PATCH v7 21/25] ARM: dts: exynos4415: add sysmmu nodes

2015-05-19 Thread Marek Szyprowski
This patch adds System MMU nodes to all defined devices that are specific to Exynos4415 series. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/boot/dts/exynos4415.dtsi | 11 +++ 1 file changed, 11 insertions

[PATCH v7 25/25] ARM: dts: exynos: add iommu reserved regions for bootloader's splash screen

2015-05-19 Thread Marek Szyprowski
in system memory. To avoid IOMMU access fault during system boot, additional identity mapping between system memory and IO virtual address space must be created when IOMMU driver gets enabled. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Krzysztof Kozlowski k.kozlow

[PATCH v7 13/25] iommu/exynos: Add support for binding more than one sysmmu to master device

2015-05-19 Thread Marek Szyprowski
-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/iommu/exynos-iommu.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index a5f0c99602c2..946f95ae46bc 100644 --- a/drivers/iommu/exynos-iommu.c +++ b

[PATCH v7 22/25] ARM: dts: exynos5250: add sysmmu nodes

2015-05-19 Thread Marek Szyprowski
This patch adds System MMU nodes to all defined devices that are specific to Exynos5250 series. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 250 ++ 1

[PATCH v7 20/25] ARM: dts: exynos3250: add sysmmu nodes

2015-05-19 Thread Marek Szyprowski
This patch adds System MMU nodes to the devices that are specific to Exynos3250 series. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/boot/dts/exynos3250.dtsi | 22 ++ 1 file changed, 22 insertions

[PATCH v7 03/25] iommu: Init iommu-groups support earlier, in core_initcall

2015-05-19 Thread Marek Szyprowski
iommu_group_alloc might be called very early in case of iommu controllers activated from of_iommu, so ensure that this part of subsystem is ready when devices are being populated from device-tree (core_initcall seems to be okay for this case). Signed-off-by: Marek Szyprowski m.szyprow

[PATCH v7 04/25] iommu/exynos: Don't read version register on every tlb operation

2015-05-19 Thread Marek Szyprowski
This patch removes reading of REG_MMU_VERSION register on every tlb operation and caches SYSMMU version in driver's internal data. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/iommu/exynos-iommu.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff

[PATCH v7 02/25] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-05-19 Thread Marek Szyprowski
to ensure that any access to fimd registers will be performed with clocks and power domains enabled. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git

[PATCH v7 00/25] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-05-19 Thread Marek Szyprowski
booting to console. Best regards Marek Szyprowski Samsung RD Institute Poland Changelog: v7: - rebased onto v4.1-rc4 - restored iommu_gruops support - added missing suspend/resume support patch - rearanged patch order and squashed some patches for better code readability - changed patch prefixes

[PATCH v7 09/25] iommu/exynos: Use struct exynos_iommu_domain in internal structures

2015-05-19 Thread Marek Szyprowski
Replace all remaining usage of struct iommu_domain with struct exynos_iommu_domain in all internal structures and functions. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/iommu/exynos-iommu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v7 12/25] iommu/exynos: Add/remove callbacks should fail if no iommu is available

2015-05-19 Thread Marek Szyprowski
Return fail if given master device passed to add_device/remove_device callbacks doesn't has associated any sysmmu controller. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/iommu/exynos-iommu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/iommu/exynos

[PATCH v7 08/25] iommu/exynos: Rename variables to reflect their purpose

2015-05-19 Thread Marek Szyprowski
This patch renames some variables to make the code easier to understand. 'domain' is replaced by 'iommu_domain' (more generic entity) and really meaningless 'priv' by 'domain' to reflect its purpose. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/iommu/exynos-iommu.c | 187

[PATCH v7 11/25] iommu/exynos: Document internal structures

2015-05-19 Thread Marek Szyprowski
Add a few words of comment to all internal structures used by the driver. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/iommu/exynos-iommu.c | 53 +--- 1 file changed, 35 insertions(+), 18 deletions(-) diff --git a/drivers/iommu

[PATCH v7 05/25] iommu/exynos: Remove unused functions

2015-05-19 Thread Marek Szyprowski
This patch removes two unneeded functions, which are not a part of generic IOMMU API and were never used by any other driver. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/iommu/exynos-iommu.c | 31 --- 1 file changed, 31 deletions(-) diff

[PATCH v7 15/25] iommu/exynos: Add system suspend/resume support

2015-05-19 Thread Marek Szyprowski
When system goes into suspend state, iommu should save it's state and restore after system resume. This is handled by 'late' pm ops to ensure that sysmmu will be suspended after its master devices and restored before them. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers

[PATCH v7 19/25] ARM: dts: exynos4: add sysmmu nodes

2015-05-19 Thread Marek Szyprowski
This patch adds System MMU nodes that are specific to Exynos4210/4x12 series. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi| 118 ++ arch/arm/boot/dts

<    1   2   3   4   5   6   7   8   9   >