Re: [PATCH - v7] of: Move of_dma_configure() to device.c to help re-use

2015-03-03 Thread Murali Karicheri
On 03/03/2015 03:53 PM, Bjorn Helgaas wrote: [+cc linux-pci] On Tue, Mar 3, 2015 at 11:55 AM, Murali Karicheri wrote: On 03/02/2015 10:43 PM, Bjorn Helgaas wrote: On Mon, Mar 2, 2015 at 3:59 PM, Murali Karicheri wrote: Move of_dma_configure() to device.c so it can be re-used for PCI

Re: [PATCH - v7] of: Move of_dma_configure() to device.c to help re-use

2015-03-03 Thread Murali Karicheri
On 03/02/2015 10:43 PM, Bjorn Helgaas wrote: On Mon, Mar 2, 2015 at 3:59 PM, Murali Karicheri wrote: Move of_dma_configure() to device.c so it can be re-used for PCI devices to obtain DMA configuration from DT. Also add a second argument so that for PCI, the DT node of root bus host bridge

[PATCH v8 3/7] of: Fix size when dma-range is not used

2015-03-03 Thread Murali Karicheri
Fix the dma-range size when the DT attribute is missing, i.e., set size to dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mask. Also add code to check invalid values of size configured in DT and log error. Tested-by: Suravee Suthikulpanit (AMD Seattle) Signed-off-by: Murali Kar

[PATCH v8 6/7] PCI: Update DMA configuration from DT

2015-03-03 Thread Murali Karicheri
ffset from CPU physical addresses. Tested-by: Suravee Suthikulpanit (AMD Seattle) Signed-off-by: Murali Karicheri Signed-off-by: Bjorn Helgaas Reviewed-by: Catalin Marinas Acked-by: Will Deacon CC: Joerg Roedel CC: Grant Likely CC: Rob Herring CC: Russell King CC: Arnd Bergmann --- driver

[PATCH v8 1/7] of: iommu: Add ptr to OF node arg to of_iommu_configure()

2015-03-03 Thread Murali Karicheri
e device is PCI. Add "parent" parameter (a struct device_node *) to of_iommu_configure(). Tested-by: Suravee Suthikulpanit (AMD Seattle) Signed-off-by: Murali Karicheri Signed-off-by: Bjorn Helgaas Reviewed-by: Catalin Marinas Acked-by: Rob Herring Acked-by: Will Deacon CC: Joerg Roe

[PATCH v8 5/7] of/pci: Add of_pci_dma_configure() to update DMA configuration

2015-03-03 Thread Murali Karicheri
-off-by: Murali Karicheri Signed-off-by: Bjorn Helgaas Reviewed-by: Catalin Marinas Acked-by: Rob Herring Acked-by: Will Deacon CC: Joerg Roedel CC: Grant Likely CC: Russell King CC: Arnd Bergmann --- drivers/of/of_pci.c| 18 ++ include/linux/of_pci.h |3 +++ 2 files

[PATCH v8 0/7] PCI: get DMA configuration from parent device

2015-03-03 Thread Murali Karicheri
Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Acked-by: Murali Karicheri Murali Karicheri (7): of: iommu: Add ptr to OF node arg to of_iommu_configure() of: Move of_dma_configure() to device.c to help re-use of: Fix size when dma-range is not used PCI: Add helper func

[PATCH v8 7/7] arm: dma-mapping: limit IOMMU mapping size

2015-03-03 Thread Murali Karicheri
arm_iommu_create_mapping() has size parameter of size_t and arm_setup_iommu_dma_ops() can take a value higher than that when this is called from the OF code. So limit the size to SIZE_MAX. Tested-by: Suravee Suthikulpanit (AMD Seattle) Signed-off-by: Murali Karicheri Signed-off-by: Bjorn

[PATCH v8 2/7] of: Move of_dma_configure() to device.c to help re-use

2015-03-03 Thread Murali Karicheri
(AMD Seattle) Signed-off-by: Murali Karicheri Signed-off-by: Bjorn Helgaas Reviewed-by: Catalin Marinas Acked-by: Will Deacon Acked-by: Rob Herring CC: Joerg Roedel CC: Grant Likely CC: Russell King CC: Arnd Bergmann --- drivers/of/device.c | 59

[PATCH v8 4/7] PCI: Add helper functions pci_get[put]_host_bridge_device()

2015-03-03 Thread Murali Karicheri
Add helper functions to get/put the root bus's host bridge device. Tested-by: Suravee Suthikulpanit (AMD Seattle) Signed-off-by: Murali Karicheri Signed-off-by: Bjorn Helgaas Reviewed-by: Catalin Marinas Acked-by: Will Deacon CC: Joerg Roedel CC: Grant Likely CC: Rob Herring CC: Ru

Re: [PATCH - v7] of: Move of_dma_configure() to device.c to help re-use

2015-03-03 Thread Murali Karicheri
On 03/02/2015 10:43 PM, Bjorn Helgaas wrote: On Mon, Mar 2, 2015 at 3:59 PM, Murali Karicheri wrote: Move of_dma_configure() to device.c so it can be re-used for PCI devices to obtain DMA configuration from DT. Also add a second argument so that for PCI, the DT node of root bus host bridge

[PATCH - V7] of/pci: Add of_pci_dma_configure() to update DMA configuration

2015-03-02 Thread Murali Karicheri
-off-by: Murali Karicheri Signed-off-by: Bjorn Helgaas Reviewed-by: Catalin Marinas Acked-by: Rob Herring Acked-by: Will Deacon CC: Joerg Roedel CC: Grant Likely CC: Russell King CC: Arnd Bergmann --- - Based on the existing patch on arm-pci/pci/iommu for pci next (Bjorn) - Fixed build issue

[PATCH - v7] of: Move of_dma_configure() to device.c to help re-use

2015-03-02 Thread Murali Karicheri
(AMD Seattle) Signed-off-by: Murali Karicheri Signed-off-by: Bjorn Helgaas Reviewed-by: Catalin Marinas Acked-by: Will Deacon CC: Joerg Roedel CC: Grant Likely CC: Rob Herring CC: Russell King CC: Arnd Bergmann --- - Based on the existing patch applied to arm-pci/pci/iommu for pci next

Re: [PATCH v6 6/7] PCI: update dma configuration from DT

2015-02-25 Thread Murali Karicheri
On 02/25/2015 11:09 AM, Arnd Bergmann wrote: On Wednesday 25 February 2015 11:03:02 Murali Karicheri wrote: (I don't know exactly how these patches all fit together, so that's probably not accurate, but that's the *sort* of thing I'd like to include.) If that actually *is

Re: [PATCH v6 6/7] PCI: update dma configuration from DT

2015-02-25 Thread Murali Karicheri
On 02/24/2015 08:53 PM, Bjorn Helgaas wrote: On Thu, Feb 05, 2015 at 04:52:58PM -0500, Murali Karicheri wrote: If there is a DT node available for the root bridge's parent device, use the dma configuration from that device node. For example, keystone PCI devices would require dma_pfn_offs

Re: [PATCH v6 0/7] PCI: get DMA configuration from parent device

2015-02-23 Thread Murali Karicheri
On 02/23/2015 05:15 PM, Bjorn Helgaas wrote: On Mon, Feb 23, 2015 at 4:08 PM, Murali Karicheri wrote: On 02/11/2015 11:58 AM, Murali Karicheri wrote: On 02/11/2015 11:54 AM, Murali Karicheri wrote: On 02/06/2015 01:36 PM, Murali Karicheri wrote: On 02/06/2015 12:53 PM, Bjorn Helgaas

Re: [PATCH v6 0/7] PCI: get DMA configuration from parent device

2015-02-23 Thread Murali Karicheri
On 02/11/2015 11:58 AM, Murali Karicheri wrote: On 02/11/2015 11:54 AM, Murali Karicheri wrote: On 02/06/2015 01:36 PM, Murali Karicheri wrote: On 02/06/2015 12:53 PM, Bjorn Helgaas wrote: On Fri, Feb 6, 2015 at 9:28 AM, Murali Karicheri wrote: On 02/06/2015 10:15 AM, Catalin Marinas wrote

Re: [PATCH v6 0/7] PCI: get DMA configuration from parent device

2015-02-11 Thread Murali Karicheri
On 02/11/2015 11:54 AM, Murali Karicheri wrote: On 02/06/2015 01:36 PM, Murali Karicheri wrote: On 02/06/2015 12:53 PM, Bjorn Helgaas wrote: On Fri, Feb 6, 2015 at 9:28 AM, Murali Karicheri wrote: On 02/06/2015 10:15 AM, Catalin Marinas wrote: On Thu, Feb 05, 2015 at 09:52:52PM +

Re: [PATCH v6 0/7] PCI: get DMA configuration from parent device

2015-02-11 Thread Murali Karicheri
On 02/06/2015 01:36 PM, Murali Karicheri wrote: On 02/06/2015 12:53 PM, Bjorn Helgaas wrote: On Fri, Feb 6, 2015 at 9:28 AM, Murali Karicheri wrote: On 02/06/2015 10:15 AM, Catalin Marinas wrote: On Thu, Feb 05, 2015 at 09:52:52PM +, Murali Karicheri wrote: This patch add an important

Re: [PATCH v6 0/7] PCI: get DMA configuration from parent device

2015-02-09 Thread Murali Karicheri
Suravee, Thanks for testing this patch. Murali Thanks, Suravee On 02/06/2015 05:52 AM, Murali Karicheri wrote: This patch add an important capability to PCI driver on Keystone. I hope to have this merged to the upstream branch so that it is available for v3.20. Also would like thank everyone for

Re: [PATCH v6 3/7] of: fix size when dma-range is not used

2015-02-06 Thread Murali Karicheri
On 02/06/2015 10:12 AM, Catalin Marinas wrote: On Fri, Feb 06, 2015 at 02:54:23PM +, Murali Karicheri wrote: On 02/06/2015 09:38 AM, Catalin Marinas wrote: On Thu, Feb 05, 2015 at 09:52:55PM +, Murali Karicheri wrote: Fix the dma-range size when the DT attribute is missing. i.e set

Re: [PATCH v6 0/7] PCI: get DMA configuration from parent device

2015-02-06 Thread Murali Karicheri
On 02/06/2015 12:53 PM, Bjorn Helgaas wrote: On Fri, Feb 6, 2015 at 9:28 AM, Murali Karicheri wrote: On 02/06/2015 10:15 AM, Catalin Marinas wrote: On Thu, Feb 05, 2015 at 09:52:52PM +, Murali Karicheri wrote: This patch add an important capability to PCI driver on Keystone. I hope to

Re: [PATCH v6 0/7] PCI: get DMA configuration from parent device

2015-02-06 Thread Murali Karicheri
On 02/06/2015 10:15 AM, Catalin Marinas wrote: On Thu, Feb 05, 2015 at 09:52:52PM +, Murali Karicheri wrote: This patch add an important capability to PCI driver on Keystone. I hope to have this merged to the upstream branch so that it is available for v3.20. It's very late for 3.2

Re: [PATCH v6 3/7] of: fix size when dma-range is not used

2015-02-06 Thread Murali Karicheri
On 02/06/2015 09:38 AM, Catalin Marinas wrote: On Thu, Feb 05, 2015 at 09:52:55PM +, Murali Karicheri wrote: Fix the dma-range size when the DT attribute is missing. i.e set size to dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mask. Also add code to check invalid values o

Re: [PATCH v6 0/7] PCI: get DMA configuration from parent device

2015-02-05 Thread Murali Karicheri
lay merge of this series because of that for reason I have mentioned below in the cover letter. So if this looks good, please merge this to the appropriate subsystem. Thanks a lot for the review and comments. Murali On 02/05/2015 04:52 PM, Murali Karicheri wrote: This patch add an important c

[PATCH v6 1/7] of: iommu: add ptr to OF node arg to of_iommu_configure()

2015-02-05 Thread Murali Karicheri
e device is PCI. Cc: Joerg Roedel Cc: Grant Likely Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Acked-by: Rob Herring Signed-off-by: Murali Karicheri --- drivers/iommu/of_iommu.c | 10 -- drivers/of/platform.c|2 +-

[PATCH v6 0/7] PCI: get DMA configuration from parent device

2015-02-05 Thread Murali Karicheri
Joerg Roedel Cc: Grant Likely Cc: Rob Herring Cc: Bjorn Helgaas Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Acked-by: Murali Karicheri Murali Karicheri (7): of: iommu: add ptr to OF node arg to of_iommu_configure() of:

[PATCH v6 2/7] of: move of_dma_configure() to device.c to help re-use

2015-02-05 Thread Murali Karicheri
: Grant Likely Cc: Rob Herring Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Signed-off-by: Murali Karicheri --- drivers/of/device.c | 59 + drivers/of/platform.c | 58

[PATCH v6 6/7] PCI: update dma configuration from DT

2015-02-05 Thread Murali Karicheri
Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Signed-off-by: Murali Karicheri --- drivers/pci/probe.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 23212f8..d7dcd6c 100644 --- a/dr

[PATCH v6 4/7] PCI: add helper functions pci_get[put]_host_bridge_device()

2015-02-05 Thread Murali Karicheri
Add a helper function to get/put the root bus's host bridge device. Cc: Joerg Roedel Cc: Grant Likely Cc: Rob Herring Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Signed-off-by: Murali Karicheri --- drivers/pci/host-bri

[PATCH v6 7/7] arm: dma-mapping: limit iommu mapping size

2015-02-05 Thread Murali Karicheri
Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Signed-off-by: Murali Karicheri --- arch/arm/mm/dma-mapping.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index a673c7f..b05d907 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch

[PATCH v6 3/7] of: fix size when dma-range is not used

2015-02-05 Thread Murali Karicheri
: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Signed-off-by: Murali Karicheri --- drivers/of/device.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/of/device.c b/drivers/of/device.c index 2de320d..314c8a9 100644

[PATCH v6 5/7] of/pci: add of_pci_dma_configure() update dma configuration

2015-02-05 Thread Murali Karicheri
: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Acked-by: Rob Herring Signed-off-by: Murali Karicheri --- drivers/of/of_pci.c| 19 +++ include/linux/of_pci.h |5 + 2 files changed, 24 insertions(+) diff --git a/drivers/of

Re: [PATCH v4 3/6] of: fix size when dma-range is not used

2015-02-05 Thread Murali Karicheri
On 02/02/2015 07:18 AM, Catalin Marinas wrote: On Fri, Jan 30, 2015 at 06:06:27PM +, Murali Karicheri wrote: On 01/28/2015 12:30 PM, Catalin Marinas wrote: I think we can remove this check altogether (we leaved without it for a while) but we need to add 1 when calculating the mask

Re: [PATCH v4 3/6] of: fix size when dma-range is not used

2015-02-02 Thread Murali Karicheri
On 02/02/2015 07:18 AM, Catalin Marinas wrote: On Fri, Jan 30, 2015 at 06:06:27PM +, Murali Karicheri wrote: On 01/28/2015 12:30 PM, Catalin Marinas wrote: I think we can remove this check altogether (we leaved without it for a while) but we need to add 1 when calculating the mask

Re: [PATCH v4 3/6] of: fix size when dma-range is not used

2015-01-30 Thread Murali Karicheri
On 01/28/2015 12:30 PM, Catalin Marinas wrote: On Wed, Jan 28, 2015 at 03:55:57PM +, Robin Murphy wrote: On 28/01/15 11:05, Catalin Marinas wrote: On Tue, Jan 27, 2015 at 06:55:15PM +, Murali Karicheri wrote: How about having the logic like this? ret = of_dma_get_range(np

Re: [PATCH v4 1/6] of: iommu: add ptr to OF node arg to of_iommu_configure()

2015-01-30 Thread Murali Karicheri
: On Wednesday 28 January 2015 12:29:42 Will Deacon wrote: On Wed, Jan 28, 2015 at 12:23:03PM +, Laurent Pinchart wrote: On Wednesday 28 January 2015 11:33:00 Will Deacon wrote: On Mon, Jan 26, 2015 at 06:49:01PM +, Murali Karicheri wrote: On 01/25/2015 08:32 AM, Laurent Pinchart wrote

Re: [PATCH v4 1/6] of: iommu: add ptr to OF node arg to of_iommu_configure()

2015-01-29 Thread Murali Karicheri
Pinchart wrote: On Wednesday 28 January 2015 11:33:00 Will Deacon wrote: On Mon, Jan 26, 2015 at 06:49:01PM +, Murali Karicheri wrote: On 01/25/2015 08:32 AM, Laurent Pinchart wrote: On Friday 23 January 2015 17:32:34 Murali Karicheri wrote: Function of_iommu_configure() is called from

Re: [PATCH v4 3/6] of: fix size when dma-range is not used

2015-01-28 Thread Murali Karicheri
On 01/28/2015 10:45 AM, Rob Herring wrote: On Wed, Jan 28, 2015 at 5:05 AM, Catalin Marinas wrote: On Tue, Jan 27, 2015 at 06:55:15PM +, Murali Karicheri wrote: On 01/27/2015 06:27 AM, Robin Murphy wrote: On 23/01/15 22:32, Murali Karicheri wrote: Fix the dma-range size when the DT

Re: [PATCH v5 3/8] of: fix size when dma-range is not used

2015-01-28 Thread Murali Karicheri
On 01/28/2015 06:21 AM, Robin Murphy wrote: Hi Murali, [sorry, missed replying to yesterday's version] On 27/01/15 21:00, Murali Karicheri wrote: Fix the dma-range size when the DT attribute is missing. i.e set size to dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mas

Re: [PATCH v4 1/6] of: iommu: add ptr to OF node arg to of_iommu_configure()

2015-01-28 Thread Murali Karicheri
Mon, Jan 26, 2015 at 06:49:01PM +, Murali Karicheri wrote: On 01/25/2015 08:32 AM, Laurent Pinchart wrote: On Friday 23 January 2015 17:32:34 Murali Karicheri wrote: Function of_iommu_configure() is called from of_dma_configure() to setup iommu ops using DT property. This API is currently

[PATCH v5 2/8] of: move of_dma_configure() to device.c to help re-use

2015-01-27 Thread Murali Karicheri
: Grant Likely Cc: Rob Herring Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Signed-off-by: Murali Karicheri --- drivers/of/device.c | 59 + drivers/of/platform.c | 58

[PATCH v5 3/8] of: fix size when dma-range is not used

2015-01-27 Thread Murali Karicheri
: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Signed-off-by: Murali Karicheri --- drivers/of/device.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/of/device.c b/drivers/of/device.c index 2de320d..17504f4 100644 --- a/driv

[PATCH v5 4/8] PCI: add helper functions pci_get[put]_host_bridge_device()

2015-01-27 Thread Murali Karicheri
Add a helper function to get/put the root bus's host bridge device. Cc: Joerg Roedel Cc: Grant Likely Cc: Rob Herring Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Signed-off-by: Murali Karicheri --- drivers/pci/host-bri

[PATCH v5 1/8] of: iommu: add ptr to OF node arg to of_iommu_configure()

2015-01-27 Thread Murali Karicheri
e device is PCI. Cc: Joerg Roedel Cc: Grant Likely Cc: Rob Herring Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Signed-off-by: Murali Karicheri --- drivers/iommu/of_iommu.c | 10 -- drivers/of/platform.c|2 +-

[PATCH v5 5/8] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-27 Thread Murali Karicheri
: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Signed-off-by: Murali Karicheri --- drivers/of/of_pci.c| 19 +++ include/linux/of_pci.h |5 + 2 files changed, 24 insertions(+) diff --git a/drivers/of/of_pci.c b

[PATCH v5 8/8] of: limit dma_mask of the device based on dma-range size

2015-01-27 Thread Murali Karicheri
limit the device dma_mask to the min of default dma_mask and mask calculate from the dma-range size. Cc: Joerg Roedel Cc: Grant Likely Cc: Rob Herring Cc: Bjorn Helgaas Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Signed-off-by: Murali Karicheri

[PATCH v5 7/8] arm: dma-mapping: limit iommu mapping size

2015-01-27 Thread Murali Karicheri
Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Signed-off-by: Murali Karicheri --- arch/arm/mm/dma-mapping.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index 7864797..496b2c3 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch

[PATCH v5 0/8] PCI: get DMA configuration from parent device

2015-01-27 Thread Murali Karicheri
arent - Added an API in of_pci.c to update DMA configuration of the pci device. Cc: Joerg Roedel Cc: Grant Likely Cc: Rob Herring Cc: Bjorn Helgaas Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Acked-by: Murali Karicheri M

[PATCH v5 6/8] PCI: update dma configuration from DT

2015-01-27 Thread Murali Karicheri
Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Acked-by: Bjorn Helgaas Signed-off-by: Murali Karicheri --- drivers/pci/probe.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 23212f8..d7dcd6c 100644 --- a/dr

Re: [PATCH v4 3/6] of: fix size when dma-range is not used

2015-01-27 Thread Murali Karicheri
On 01/27/2015 06:27 AM, Robin Murphy wrote: Hi Murali, On 23/01/15 22:32, Murali Karicheri wrote: Fix the dma-range size when the DT attribute is missing. i.e set size to dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mask. To detect overflow when mask is set to max of u64,

Re: [PATCH v4 4/6] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-27 Thread Murali Karicheri
On 01/27/2015 01:42 PM, Bjorn Helgaas wrote: On Tue, Jan 27, 2015 at 12:14 PM, Murali Karicheri wrote: On 01/26/2015 06:59 PM, Bjorn Helgaas wrote: On Mon, Jan 26, 2015 at 5:25 PM, Murali Karicheri wrote: On 01/23/2015 06:41 PM, Bjorn Helgaas wrote: On Fri, Jan 23, 2015 at 05:32:37PM

Re: [PATCH v4 4/6] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-27 Thread Murali Karicheri
On 01/26/2015 06:59 PM, Bjorn Helgaas wrote: On Mon, Jan 26, 2015 at 5:25 PM, Murali Karicheri wrote: On 01/23/2015 06:41 PM, Bjorn Helgaas wrote: On Fri, Jan 23, 2015 at 05:32:37PM -0500, Murali Karicheri wrote: Add of_pci_dma_configure() to allow updating the dma configuration of the pci

Re: [PATCH v4 3/6] of: fix size when dma-range is not used

2015-01-27 Thread Murali Karicheri
On 01/27/2015 06:27 AM, Robin Murphy wrote: Hi Murali, On 23/01/15 22:32, Murali Karicheri wrote: Fix the dma-range size when the DT attribute is missing. i.e set size to dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mask. To detect overflow when mask is set to max of u64,

Re: [PATCH v4 6/6] arm: dma-mapping: updates to limit dma_mask and iommu mapping size

2015-01-27 Thread Murali Karicheri
On 01/27/2015 06:34 AM, Catalin Marinas wrote: On Tue, Jan 27, 2015 at 11:12:32AM +, Robin Murphy wrote: On 23/01/15 22:32, Murali Karicheri wrote: Limit the dma_mask to minimum of dma_mask and dma_base + size - 1. Also arm_iommu_create_mapping() has size parameter of size_t and

Re: [PATCH v4 5/6] PCI: update dma configuration from DT

2015-01-26 Thread Murali Karicheri
On 01/23/2015 06:27 PM, Bjorn Helgaas wrote: On Fri, Jan 23, 2015 at 05:32:38PM -0500, Murali Karicheri wrote: If there is a DT node available for the root bridge's parent device, use the dma configuration from that device node. For example, keystone PCI devices would require dma_pfn_offs

Re: [PATCH v4 4/6] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-26 Thread Murali Karicheri
On 01/23/2015 06:41 PM, Bjorn Helgaas wrote: On Fri, Jan 23, 2015 at 05:32:37PM -0500, Murali Karicheri wrote: Add of_pci_dma_configure() to allow updating the dma configuration of the pci device using the configuration from DT of the parent of the root bridge device. Cc: Joerg Roedel Cc

Re: [PATCH v4 1/6] of: iommu: add ptr to OF node arg to of_iommu_configure()

2015-01-26 Thread Murali Karicheri
On 01/25/2015 08:32 AM, Laurent Pinchart wrote: Hi Murali, Thank you for the patch. On Friday 23 January 2015 17:32:34 Murali Karicheri wrote: Function of_iommu_configure() is called from of_dma_configure() to setup iommu ops using DT property. This API is currently used for platform devices

[PATCH v4 5/6] PCI: update dma configuration from DT

2015-01-23 Thread Murali Karicheri
Bjorn Helgaas Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Signed-off-by: Murali Karicheri --- drivers/pci/probe.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 23212f8..d7dcd6c 100644 --- a/driver

[PATCH v4 1/6] of: iommu: add ptr to OF node arg to of_iommu_configure()

2015-01-23 Thread Murali Karicheri
e device is PCI. Cc: Joerg Roedel Cc: Grant Likely Cc: Rob Herring Cc: Bjorn Helgaas Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Signed-off-by: Murali Karicheri --- drivers/iommu/of_iommu.c | 10 -- drivers/of/platform.c|2 +- include/l

[PATCH v4 0/6] PCI: get DMA configuration from parent device

2015-01-23 Thread Murali Karicheri
ed an API in of_pci.c to update DMA configuration of the pci device. Cc: Joerg Roedel Cc: Grant Likely Cc: Rob Herring Cc: Bjorn Helgaas Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Murali Karicheri (6): of: iommu: add ptr to OF node a

[PATCH v4 3/6] of: fix size when dma-range is not used

2015-01-23 Thread Murali Karicheri
catch this and fix. Cc: Joerg Roedel Cc: Grant Likely Cc: Rob Herring Cc: Bjorn Helgaas Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Signed-off-by: Murali Karicheri --- drivers/of/device.c | 14 +- 1 file changed, 13 insertions(+), 1 de

[PATCH v4 4/6] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-23 Thread Murali Karicheri
Suthikulpanit Signed-off-by: Murali Karicheri --- drivers/of/of_pci.c| 39 +++ include/linux/of_pci.h | 12 2 files changed, 51 insertions(+) diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c index 88471d3..34878c9 100644 --- a

[PATCH v4 2/6] of: move of_dma_configure() to device.c to help re-use

2015-01-23 Thread Murali Karicheri
: Grant Likely Cc: Rob Herring Cc: Bjorn Helgaas Cc: Will Deacon Cc: Russell King Cc: Arnd Bergmann Cc: Suravee Suthikulpanit Signed-off-by: Murali Karicheri --- drivers/of/device.c | 59 + drivers/of/platform.c | 58

[PATCH v4 6/6] arm: dma-mapping: updates to limit dma_mask and iommu mapping size

2015-01-23 Thread Murali Karicheri
Limit the dma_mask to minimum of dma_mask and dma_base + size - 1. Also arm_iommu_create_mapping() has size parameter of size_t and arm_setup_iommu_dma_ops() can take a value higher than that. So limit the size to SIZE_MAX. Signed-off-by: Murali Karicheri --- arch/arm/mm/dma-mapping.c | 10

Re: [PATCH v3 2/4] of: move of_dma_configure() to device,c to help re-use

2015-01-23 Thread Murali Karicheri
On 01/09/2015 10:34 AM, Rob Herring wrote: On Thu, Jan 8, 2015 at 4:24 PM, Arnd Bergmann wrote: On Thursday 08 January 2015 14:26:36 Murali Karicheri wrote: On 01/08/2015 03:40 AM, Arnd Bergmann wrote: On Wednesday 07 January 2015 17:37:56 Rob Herring wrote: On Wed, Jan 7, 2015 at 12:49 PM

Re: [PATCH v3 2/4] of: move of_dma_configure() to device,c to help re-use

2015-01-08 Thread Murali Karicheri
On 01/08/2015 05:24 PM, Arnd Bergmann wrote: On Thursday 08 January 2015 14:26:36 Murali Karicheri wrote: On 01/08/2015 03:40 AM, Arnd Bergmann wrote: On Wednesday 07 January 2015 17:37:56 Rob Herring wrote: On Wed, Jan 7, 2015 at 12:49 PM, Murali Karicheri wrote: + ret

Re: [PATCH v3 0/4] PCI: get DMA configuration from parent device

2015-01-08 Thread Murali Karicheri
e don't have to do anything for USB. Ok Thanks. Murali Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Murali

Re: [PATCH v3 3/4] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-08 Thread Murali Karicheri
On 01/08/2015 05:25 PM, Arnd Bergmann wrote: On Thursday 08 January 2015 14:52:13 Murali Karicheri wrote: Could you add this as as a follow up patch as I don't have a platformm that support IOMMU and as such my understanding of the IOMMU is limited? I can help test the change to make su

Re: [PATCH v3 3/4] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-08 Thread Murali Karicheri
On 01/08/2015 11:06 AM, Will Deacon wrote: On Wed, Jan 07, 2015 at 06:49:53PM +, Murali Karicheri wrote: Add of_pci_dma_configure() to allow updating the dma configuration of the pci device using the configuration from DT of the parent of the root bridge device. Signed-off-by: Murali

Re: [PATCH v3 2/4] of: move of_dma_configure() to device,c to help re-use

2015-01-08 Thread Murali Karicheri
On 01/08/2015 03:40 AM, Arnd Bergmann wrote: On Wednesday 07 January 2015 17:37:56 Rob Herring wrote: On Wed, Jan 7, 2015 at 12:49 PM, Murali Karicheri wrote: + ret = of_dma_get_range(np,&dma_addr,&paddr,&size); + if (ret< 0) { + dma_ad

Re: [PATCH v3 1/4] of: iommu: add ptr to OF node arg to of_iommu_configure()

2015-01-08 Thread Murali Karicheri
On 01/07/2015 06:30 PM, Rob Herring wrote: On Wed, Jan 7, 2015 at 12:49 PM, Murali Karicheri wrote: Function of_iommu_configure() is called from of_dma_configure() to setup iommu ops using DT property. This API is currently used for platform devices for which DMA configuration (including iommu

Re: [PATCH v3 0/4] PCI: get DMA configuration from parent device

2015-01-08 Thread Murali Karicheri
On 01/07/2015 06:08 PM, Bjorn Helgaas wrote: On Wed, Jan 7, 2015 at 5:05 PM, Murali Karicheri wrote: On 01/07/2015 01:49 PM, Murali Karicheri wrote: PCI devices on Keystone doesn't have correct dma_pfn_offset set. This patch add capability to set the dma configuration such as dma

Re: [PATCH v3 0/4] PCI: get DMA configuration from parent device

2015-01-07 Thread Murali Karicheri
On 01/07/2015 01:49 PM, Murali Karicheri wrote: PCI devices on Keystone doesn't have correct dma_pfn_offset set. This patch add capability to set the dma configuration such as dma-mask, dma_pfn_offset, and dma ops etc using the information from DT. The prior RFCs and discussions are availab

Re: [PATCH v3 0/4] PCI: get DMA configuration from parent device

2015-01-07 Thread Murali Karicheri
On 01/07/2015 04:18 PM, Arnd Bergmann wrote: On Wednesday 07 January 2015 13:49:50 Murali Karicheri wrote: PCI devices on Keystone doesn't have correct dma_pfn_offset set. This patch add capability to set the dma configuration such as dma-mask, dma_pfn_offset, and dma ops etc usin

[PATCH v3 2/4] of: move of_dma_configure() to device, c to help re-use

2015-01-07 Thread Murali Karicheri
-range size when the DT attribute is missing. i.e set size to dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mask. Signed-off-by: Murali Karicheri --- drivers/of/device.c | 58 + drivers/of/platform.c

[PATCH v3 3/4] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-07 Thread Murali Karicheri
Add of_pci_dma_configure() to allow updating the dma configuration of the pci device using the configuration from DT of the parent of the root bridge device. Signed-off-by: Murali Karicheri --- drivers/of/of_pci.c| 39 +++ include/linux/of_pci.h | 12

[PATCH v3 0/4] PCI: get DMA configuration from parent device

2015-01-07 Thread Murali Karicheri
Added a helper function to get the OF node of the parent - Added an API in of_pci.c to update DMA configuration of the pci device. Murali Karicheri (4): of: iommu: add ptr to OF node arg to of_iommu_configure() of: move of_dma_configure() to device,c to help re-use o

[PATCH v3 1/4] of: iommu: add ptr to OF node arg to of_iommu_configure()

2015-01-07 Thread Murali Karicheri
e device is PCI. Signed-off-by: Murali Karicheri --- drivers/iommu/of_iommu.c | 10 -- drivers/of/platform.c|2 +- include/linux/of_iommu.h |6 -- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index a

[PATCH v3 4/4] PCI: update dma configuration from DT

2015-01-07 Thread Murali Karicheri
will have dma-ranges defined for this. Also support using the DT property dma-coherent to allow coherent DMA operation by the PCI device. This patch use the new helper function of_pci_dma_configure() to update the device dma configuration. Signed-off-by: Murali Karicheri --- drivers/pci/pr