RE: [PATCH v2 1/2] IOMMU: arm-smmu-v3: Fix broken STE.VALID check in Broadcom Vulcan

2015-12-18 Thread Prem (Premachandra) Mallappa
Hi Will, > > Is this workaround only needed for bypass STEs? If not, we have a problem > when we install a stage-1 entry, because we'll clear the EATS bits as it > stands. > Yes, this _was_ needed only in Bypass STEs, AFAIK. However, the h/w fixes that were committed recently has this worked

RE: [PATCH] IOMMU: arm-smmu-v3: fix broken S2PS and AARCH64 in Broadcom Vulcan

2015-12-16 Thread Prem (Premachandra) Mallappa
> Ok -- so what is the value reported by your IDR5? Our IDR5, OAS=0x4 (44bits) > > Ok, I just didn't see any mention of that in the commit message and wanted > to make sure it wasn't an accidental unrelated change. > Got it. /Prem ___ iommu

RE: [PATCH] IOMMU: arm-smmu-v3: fix broken S2PS and AARCH64 in Broadcom Vulcan

2015-12-15 Thread Prem (Premachandra) Mallappa
Hi Will, Thanks for the review. > On Mon, Dec 14, 2015 at 10:01:27PM +0530, Prem Mallappa wrote: > > Vulcan SMMUv3 looks for AARCH64 and S2PS inroder to validate the STE > > entry, > > 'inroder' ? > In order > > which is a overkill, but when proper encoding not found; the SMMU > > stops

RE: [PATCH] IOMMU: arm-smmu-v3: Use STE.S1STALLD only when supported

2015-12-11 Thread Prem (Premachandra) Mallappa
Hi Will, It is ready, in internal review, will be sending it in a day. /Prem > -Original Message- > From: Will Deacon [mailto:will.dea...@arm.com] > Sent: 12 December 2015 01:23 AM > To: Prem (Premachandra) Mallappa > Cc: iommu@lists.linux-foundation.org