[PATCH] dma-debug: Only skip one stackframe entry

case, it's best to err on the side of skipping less. Signed-off-by: Scott Wood --- kernel/dma/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c index 45d51e8e26f6..a218e43cc382 100644 --- a/kernel/dma/debug.c +++ b/kernel/dma/debug.c

Re: [PATCH 16/20] powerpc/dma: use dma_direct_{alloc,free}

On Thu, 2018-08-09 at 10:52 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2018-07-30 at 18:38 +0200, Christoph Hellwig wrote: > > These do the same functionality as the existing helpers, but do it > > simpler, and also allow the (optional) use of CMA. > > > > Note that the swiotlb code now calls

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

On Mon, 2018-03-19 at 13:15 +0100, Sebastian Andrzej Siewior wrote: > On 2018-03-17 16:43:39 [-0500], Scott Wood wrote: > > If that's worth the lock dropping then fine (though why does only > > one > > of the two allocations use GFP_KERNEL?), but it doesn't need to be > >

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

On Sat, 2018-03-17 at 22:10 +0100, Sebastian Andrzej Siewior wrote: > On 2018-03-17 14:49:54 [-0500], Scott Wood wrote: > > On Fri, 2018-03-16 at 21:18 +0100, Sebastian Andrzej Siewior wrote: > > > The goal here is to make the memory allocation in get_irq_table() > > &

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

On Fri, 2018-03-16 at 21:18 +0100, Sebastian Andrzej Siewior wrote: > The goal here is to make the memory allocation in get_irq_table() not > with disabled interrupts and having as little raw_spin_lock as > possible > while having them if the caller is also holding one (like desc->lock > during

[PATCH v2] iommu/amd: Avoid locking get_irq_table() from atomic context

ing for. Signed-off-by: Scott Wood <sw...@redhat.com> --- v2: Added new get_irq_table() with WARNs rather than accessing irq_lookup_table[] directly. --- drivers/iommu/amd_iommu.c | 29 ++--- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/drivers/iommu/amd_

[PATCH] iommu/amd: Don't use dev_data in irte_ga_set_affinity()

search_dev_data() acquires a non-raw lock, which can't be done from atomic context on PREEMPT_RT. There is no need to look at dev_data because guest_mode should never be set if use_vapic is not set. Signed-off-by: Scott Wood <sw...@redhat.com> --- This is a followup to the patches below:

[PATCH 2/2] amd/iommu: Use raw locks on atomic context paths

Several functions in this driver are called from atomic context, and thus raw locks must be used in order to be safe on PREEMPT_RT. This includes paths that must wait for command completion, which is a potential PREEMPT_RT latency concern but not easily avoidable. Signed-off-by: Scott Wood <

[PATCH 1/2] iommu/amd: Avoid get_irq_table() from atomic context

ful protection if they did, since it's released before using the looked up table in the get_irq_table() caller. The amd_iommu_rlookup_table[] check is not needed because irq_lookup_table[devid] should never be non-NULL if amd_iommu_rlookup_table[devid] is NULL. Signed-off-by: Scott Wood <sw...@redh

Re: [v16, 0/7] Fix eSDHC host version register bug

On Thu, 2016-11-10 at 04:11 +, Y.B. Lu wrote: > > > > -Original Message- > > From: Y.B. Lu > > Sent: Thursday, November 10, 2016 12:06 PM > > To: 'Scott Wood'; Ulf Hansson > > Cc: linux-mmc; Arnd Bergmann; linuxppc-...@lists.ozlabs.org; > >

Re: [v16, 0/7] Fix eSDHC host version register bug

On Wed, 2016-11-09 at 19:27 +0100, Ulf Hansson wrote: > - i2c-list > > On 9 November 2016 at 04:14, Yangbo Lu wrote: > > > > This patchset is used to fix a host version register bug in the T4240- > > R1.0-R2.0 > > eSDHC controller. To match the SoC version and revision, 15

Re: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

On Fri, 2016-10-28 at 11:32 +0800, Yangbo Lu wrote: > + guts->regs = of_iomap(np, 0); > + if (!guts->regs) > + return -ENOMEM; > + > + /* Register soc device */ > + machine = of_flat_dt_get_machine_name(); > + if (machine) > + soc_dev_attr.machine =

Re: [v12, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

On Wed, 2016-09-21 at 14:57 +0800, Yangbo Lu wrote: > diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig > new file mode 100644 > index 000..b99764c > --- /dev/null > +++ b/drivers/soc/fsl/Kconfig > @@ -0,0 +1,19 @@ > +# > +# Freescale SOC drivers > +# > + > +source

Re: [v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

On Tue, 2016-09-13 at 07:23 +, Y.B. Lu wrote: > > > > > > -Original Message- > > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > > ow...@vger.kernel.org] On Behalf Of Scott Wood > > Sent: Tuesday, September 13, 2016 7:25 AM > &

Re: [v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

On Mon, 2016-09-12 at 06:39 +, Y.B. Lu wrote: > Hi Scott, > > Thanks for your review :) > See my comment inline. > > > > > -Original Message- > > From: Scott Wood [mailto:o...@buserror.net] > > Sent: Friday, September 09, 2016 11:47 AM >

Re: [v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

river to manage and access global utilities block. > Initially only reading SVR and registering soc device are supported. > Other guts accesses, such as reading RCW, should eventually be moved > into this driver as well. > > Signed-off-by: Yangbo Lu <yangbo...@nxp.com> > Signe

Re: [v10, 3/7] soc: fsl: add GUTS driver for QorIQ platforms

nate > > function selection for multiplexed signals,and clock control. > > > > This patch adds GUTS driver to manage and access global utilities > > block. > > > > Signed-off-by: Yangbo Lu <yangbo...@nxp.com> > > Acked-by: Scott Wood <o...@buserr

Re: [PATCH 2/4] soc: fsl: add GUTS driver for QorIQ platforms

On Thu, 2016-07-07 at 10:30 +0200, Arnd Bergmann wrote: > On Thursday, July 7, 2016 2:35:33 AM CEST Yangbo Lu wrote: > > > > Hi Arnd, > > > > Could you reply when you see the email? > > If your method doesn’t resolve the problem, we still want to use our old > > patchset. > > > > This guts

Re: [PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of arch/powerpc"

On Thu, 2016-06-02 at 11:01 +0200, Arnd Bergmann wrote: > On Wednesday, June 1, 2016 8:24:20 PM CEST Scott Wood wrote: > > On Mon, 2016-05-30 at 15:18 +0200, Arnd Bergmann wrote: > > > All users of this driver are PowerPC specific and the header file > > > has no bus

Re: [PATCH 3/4] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

On Thu, 2016-06-02 at 10:52 +0200, Arnd Bergmann wrote: > On Wednesday, June 1, 2016 8:11:14 PM CEST Scott Wood wrote: > > > +#define T4240_HOST_VER ((VENDOR_V_23 << SDHCI_VENDOR_VER_SHIFT) | > > > SDHCI_SPEC_200) > > > +static const struct so

Re: [PATCH 2/4] soc: fsl: add GUTS driver for QorIQ platforms

On Thu, 2016-06-02 at 10:43 +0200, Arnd Bergmann wrote: > On Wednesday, June 1, 2016 8:47:22 PM CEST Scott Wood wrote: > > On Mon, 2016-05-30 at 15:15 +0200, Arnd Bergmann wrote: > > > diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c > > > new file mode 1006

Re: [PATCH 2/4] soc: fsl: add GUTS driver for QorIQ platforms

On Mon, 2016-05-30 at 15:15 +0200, Arnd Bergmann wrote: > diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c > new file mode 100644 > index ..2f30698f5bcf > --- /dev/null > +++ b/drivers/soc/fsl/guts.c > @@ -0,0 +1,130 @@ > +/* > + * Freescale QorIQ Platforms GUTS Driver > +

Re: [PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of arch/powerpc"

On Mon, 2016-05-30 at 15:18 +0200, Arnd Bergmann wrote: > All users of this driver are PowerPC specific and the header file > has no business in the global include/linux/ hierarchy, so move > it back before anyone starts using it on ARM. > > This reverts commit

Re: [PATCH 3/4] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

On Mon, 2016-05-30 at 15:16 +0200, Arnd Bergmann wrote: > This is a rewrite of an earlier patch from Yangbo Lu, adding a quirk > for the NXP QorIQ T4240 in the detection of the host device version. > > Unfortunately, this device cannot be detected using the compatible > string, as we have to

Re: [v10, 7/7] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

ion.org; net...@vger.kernel.org; Mark Rutland; > > > ulf.hans...@linaro.org; Russell King; Bhupesh Sharma; Joerg Roedel; > > > Santosh Shilimkar; Yang-Leo Li; Scott Wood; Rob Herring; Claudiu Manoil; > > > Kumar Gala; Xiaobo Xie; Qiang Zhao > > > Subject: Re: [v10, 7/7]

Re: [v7, 0/5] Fix eSDHC host version register bug

TS driver for QorIQ platforms > dt: move guts devicetree doc out of powerpc directory > powerpc/fsl: move mpc85xx.h to include/linux/fsl > mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0 Acked-by: Scott Wood <o...@buserror.net> -Scott ___

Re: [v6, 3/5] dt: move guts devicetree doc out of powerpc directory

On 03/17/2016 12:06 PM, Rob Herring wrote: > On Wed, Mar 09, 2016 at 06:08:49PM +0800, Yangbo Lu wrote: >> Move guts devicetree doc to Documentation/devicetree/bindings/soc/fsl/ >> since it's used by not only PowerPC but also ARM. And add a specification >> for 'little-endian' property. >> >>

Re: [v6, 2/5] soc: fsl: add GUTS driver for QorIQ platforms

On 03/09/2016 04:18 AM, Yangbo Lu wrote: > +#ifdef CONFIG_FSL_GUTS > +u32 fsl_guts_get_svr(void); > +int fsl_guts_init(void); > +#endif Don't ifdef prototypes (when not providing a stub alternative). -Scott ___ iommu mailing list

Re: [v6, 5/5] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

er...@lists.infradead.org; linux-ker...@vger.kernel.org; linux- >> c...@vger.kernel.org; linux-...@vger.kernel.org; iommu@lists.linux- >> foundation.org; net...@vger.kernel.org; linux-...@vger.kernel.org; >> ulf.hans...@linaro.org; Zhao Qiang; Russell King; Bhupesh Sharma; Joerg >>

Re: [v6, 5/5] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

On 03/17/2016 12:06 PM, Arnd Bergmann wrote: > On Thursday 17 March 2016 12:01:01 Rob Herring wrote: >> On Mon, Mar 14, 2016 at 05:45:43PM +0000, Scott Wood wrote: > >>>>> This makes the driver non-portable. Better identify the specific >>>>>

Re: [PATCH] iommu/fsl: Fix the dependency check for PAMU driver.

On Thu, 2015-05-14 at 23:11 +0530, Varun Sethi wrote: Fix the build dependency for the PAMU driver. PPC32 build dependecy is incorrect. Add the CORENET_GENERIC build dependency for PAMU driver. Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/Kconfig |2 +- 1

Re: [RFC PATCH v4 01/10] driver core: export driver_probe_device()

On Sat, 2014-02-15 at 12:19 -0600, Yoder Stuart-B08248 wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Saturday, February 15, 2014 11:34 AM To: Yoder Stuart-B08248 Cc: Antonios Motakis; alex.william...@redhat.com;

Re: [RFC PATCH v4 06/10] VFIO_PLATFORM: Read and write support for the device fd

On Mon, 2014-02-10 at 15:45 -0700, Alex Williamson wrote: On Sat, 2014-02-08 at 18:29 +0100, Antonios Motakis wrote: VFIO returns a file descriptor which we can use to manipulate the memory regions of the device. Since some memory regions we cannot mmap due to security concerns, we also

Re: [PATCH 0/9 v2] vfio-pci: add support for Freescale IOMMU (PAMU)

My e-mail address is scottw...@freescale.com, not IMCEAEX-_O=MMS_OU=EXTERNAL+20+28FYDIBOHF25SPDLT +29_CN=RECIPIENTS_CN=f0faac8d7e74473a9ee1c45b068d8...@namprd03.prod.outlook.com On Tue, 2013-12-10 at 05:37 +, bharat.bhus...@freescale.com wrote: -Original Message- From: Wood

Re: [PATCH 0/9 v2] vfio-pci: add support for Freescale IOMMU (PAMU)

On Thu, 2013-12-05 at 22:11 -0600, Bharat Bhushan wrote: -Original Message- From: Wood Scott-B07421 Sent: Friday, December 06, 2013 5:52 AM To: Bhushan Bharat-R65777 Cc: Alex Williamson; linux-...@vger.kernel.org; ag...@suse.de; Yoder Stuart- B08248;

Re: [PATCH 0/9 v2] vfio-pci: add support for Freescale IOMMU (PAMU)

-ker...@vger.kernel.org Subject: Re: [PATCH 0/9 v2] vfio-pci: add support for Freescale IOMMU (PAMU) On Thu, 2013-11-21 at 14:47 -0600, Scott Wood wrote: They can interfere. Want to be sure of how they can interfere? If more than one VFIO user shares the same MSI group

Re: [PATCH 0/9 v2] vfio-pci: add support for Freescale IOMMU (PAMU)

On Fri, 2013-12-06 at 12:30 -0700, Alex Williamson wrote: On Fri, 2013-12-06 at 12:59 -0600, Scott Wood wrote: On Thu, 2013-12-05 at 22:11 -0600, Bharat Bhushan wrote: -Original Message- From: Wood Scott-B07421 Sent: Friday, December 06, 2013 5:52 AM To: Bhushan

Re: [PATCH 0/9 v2] vfio-pci: add support for Freescale IOMMU (PAMU)

Stuart-B08248; iommu@lists.linux-foundation.org; bhelg...@google.com; linuxppc- d...@lists.ozlabs.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH 0/9 v2] vfio-pci: add support for Freescale IOMMU (PAMU) On Thu, 2013-11-21 at 14:47 -0600, Scott Wood wrote: On Thu, 2013-11-21 at 13:43

Re: [PATCH 0/9 v2] vfio-pci: add support for Freescale IOMMU (PAMU)

) On Thu, 2013-11-21 at 14:47 -0600, Scott Wood wrote: On Thu, 2013-11-21 at 13:43 -0700, Alex Williamson wrote: On Thu, 2013-11-21 at 11:20 +, Bharat Bhushan wrote: -Original Message- From: Alex Williamson [mailto:alex.william...@redhat.com

Re: [PATCH] iommu/fsl_pamu: use physical cpu index to find the matched cpu nodes

On Thu, 2013-11-14 at 21:16 -0600, Sethi Varun-B16395 wrote: Haiying/Scott, Forgot to mention this, the PAMU driver has to handle stash destination settings both for power and dsp cores (on B4 platform). For the dsp cores we would expect the physical core id (not controlled by Linux). To make

Re: [PATCH] iommu/fsl_pamu: use physical cpu index to find the matched cpu nodes

On Mon, 2013-11-18 at 20:42 -0600, Varun Sethi wrote: For the DSP case again we have to set up the stash attribute. Are you saying that this should be a separate attribute? Not necessarily a separate attribute, but there should be some way to distinguish whether you're providing a Linux cpu

Re: [PATCH] iommu/fsl_pamu: use physical cpu index to find the matched cpu nodes

On Thu, 2013-11-14 at 14:30 -0500, Haiying Wang wrote: In the case we miss to bring up some cpus, we need to make sure we can find the correct cpu nodes in the device tree based on the given logical cpu index from the caller. Signed-off-by: Haiying Wang haiying.w...@freescale.com ---

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

On Tue, 2013-10-08 at 10:47 -0600, Bjorn Helgaas wrote: On Thu, Oct 3, 2013 at 11:19 PM, Bhushan Bharat-R65777 r65...@freescale.com wrote: I don't know enough about VFIO to understand why these new interfaces are needed. Is this the first VFIO IOMMU driver? I see

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

On Thu, 2013-09-19 at 12:59 +0530, Bharat Bhushan wrote: @@ -376,6 +405,7 @@ static int fsl_of_msi_probe(struct platform_device *dev) int len; u32 offset; static const u32 all_avail[] = { 0, NR_MSI_IRQS }; + static int bank_index; match =

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

On Tue, 2013-10-08 at 17:25 -0600, Bjorn Helgaas wrote: - u32 msiir_offset; /* Offset of MSIIR, relative to start of CCSR */ + dma_addr_t msiir; /* MSIIR Address in CCSR */ Are you sure dma_addr_t is right here, versus phys_addr_t? It implies that it's the output of the DMA API,

Re: [PATCH 2/3 v13] iommu/fsl: Add additional iommu attributes required by the PAMU driver.

On 04/22/2013 12:31:55 AM, Varun Sethi wrote: Added the following domain attributes for the FSL PAMU driver: 1. Added new iommu stash attribute, which allows setting of the LIODN specific stash id parameter through IOMMU API. 2. Added an attribute for enabling/disabling DMA to a particular

Re: RFC: vfio API changes needed for powerpc (v3)

On 04/11/2013 07:56:59 AM, Joerg Roedel wrote: On Tue, Apr 09, 2013 at 01:22:15AM +, Yoder Stuart-B08248 wrote: What happens if a normal unmap call is done on the MSI iova? Do we need a separate unmap? I was thinking a normal unmap on an MSI windows would be an error...but I'm

Re: RFC: vfio API changes needed for powerpc (v3)

On 04/04/2013 05:10:27 PM, Yoder Stuart-B08248 wrote: /* * VFIO_IOMMU_PAMU_UNMAP_MSI_BANK * * Unmaps the MSI bank at the specified iova. * Caller provides struct vfio_pamu_msi_bank_unmap with all fields set. * Operates on VFIO file descriptor (/dev/vfio/vfio). * Return: 0 on success,

Re: RFC: vfio API changes needed for powerpc

On 04/03/2013 01:32:26 PM, Stuart Yoder wrote: On Tue, Apr 2, 2013 at 5:50 PM, Scott Wood scottw...@freescale.com wrote: On 04/02/2013 04:38:45 PM, Alex Williamson wrote: On Tue, 2013-04-02 at 16:08 -0500, Stuart Yoder wrote: VFIO_IOMMU_MAP_MSI(iova, size) Not sure how you mean

Re: RFC: vfio API changes needed for powerpc

On 04/03/2013 02:09:45 PM, Stuart Yoder wrote: Would is be possible for userspace to simply leave room for MSI bank mapping (how much room could be determined by something like VFIO_IOMMU_GET_MSI_BANK_COUNT) then document the API that userspace can DMA_MAP starting at the 0x0 address of

Re: RFC: vfio API changes needed for powerpc

On 04/03/2013 02:43:06 PM, Stuart Yoder wrote: On Wed, Apr 3, 2013 at 2:18 PM, Scott Wood scottw...@freescale.com wrote: On 04/03/2013 02:09:45 PM, Stuart Yoder wrote: Would is be possible for userspace to simply leave room for MSI bank mapping (how much room could be determined

Re: RFC: vfio API changes needed for powerpc

On 04/02/2013 10:37:20 PM, Alex Williamson wrote: On Tue, 2013-04-02 at 17:50 -0500, Scott Wood wrote: On 04/02/2013 04:38:45 PM, Alex Williamson wrote: On Tue, 2013-04-02 at 16:08 -0500, Stuart Yoder wrote: On Tue, Apr 2, 2013 at 3:57 PM, Scott Wood scottw...@freescale.com wrote

Re: RFC: vfio API changes needed for powerpc

On 04/02/2013 10:12:31 PM, Alex Williamson wrote: On Tue, 2013-04-02 at 17:44 -0500, Scott Wood wrote: On 04/02/2013 04:32:04 PM, Alex Williamson wrote: On Tue, 2013-04-02 at 15:57 -0500, Scott Wood wrote: On 04/02/2013 03:32:17 PM, Alex Williamson wrote: On x86 the interrupt remapper

Re: RFC: vfio API changes needed for powerpc

On 04/02/2013 03:32:17 PM, Alex Williamson wrote: On Tue, 2013-04-02 at 17:32 +, Yoder Stuart-B08248 wrote: 2. MSI window mappings The more problematic question is how to deal with MSIs. We need to create mappings for up to 3 MSI banks that a device may need to target to

Re: RFC: vfio API changes needed for powerpc

On 04/02/2013 03:38:42 PM, Stuart Yoder wrote: On Tue, Apr 2, 2013 at 2:39 PM, Scott Wood scottw...@freescale.com wrote: On 04/02/2013 12:32:00 PM, Yoder Stuart-B08248 wrote: Alex, We are in the process of implementing vfio-pci support for the Freescale IOMMU (PAMU). It is an aperture

Re: RFC: vfio API changes needed for powerpc

On 04/02/2013 04:08:27 PM, Stuart Yoder wrote: On Tue, Apr 2, 2013 at 3:57 PM, Scott Wood scottw...@freescale.com wrote: This could also be done as another type2 ioctl extension. Again, what is type2, specifically? If someone else is adding their own IOMMU that is kind of, sort of like

Re: RFC: vfio API changes needed for powerpc

On 04/02/2013 04:16:11 PM, Alex Williamson wrote: On Tue, 2013-04-02 at 15:54 -0500, Stuart Yoder wrote: The number of windows is always power of 2 (and max is 256). And to reduce PAMU cache pressure you want to use the fewest number of windows you can.So, I don't see practically how

Re: RFC: vfio API changes needed for powerpc

On 04/02/2013 04:38:45 PM, Alex Williamson wrote: On Tue, 2013-04-02 at 16:08 -0500, Stuart Yoder wrote: On Tue, Apr 2, 2013 at 3:57 PM, Scott Wood scottw...@freescale.com wrote: C. Explicit mapping using normal DMA map. The last idea is that we would introduce a new ioctl