Hi Miaoqian,
On 1/9/22 8:43 PM, Miaoqian Lin wrote:
> Hi Suman Anna,
> On Fri, Jan 07, 2022 at 08:42:16AM -0600, Suman Anna wrote:
>> Hi Miaoqian,
>>
>>
>>> Add the corresponding 'put_device()' in the error handling paths.
>>
>> Also, need
Hi Miaoqian,
On 1/7/22 2:04 AM, Miaoqian Lin wrote:
> The reference taken by 'of_find_device_by_node()' must be released when
> not needed anymore.
Thanks for catching this.
> Add the corresponding 'put_device()' in the error handling paths.
Also, need it in the regular path, not just in error
Hi Rob,
On 6/15/21 2:15 PM, Rob Herring wrote:
> If a property has an 'items' list, then a 'minItems' or 'maxItems' with the
> same size as the list is redundant and can be dropped. Note that is DT
> schema specific behavior and not standard json-schema behavior. The tooling
> will fixup the final
On 8/20/20 6:01 PM, Robin Murphy wrote:
> On 2020-08-20 20:55, Sakari Ailus wrote:
>> On Thu, Aug 20, 2020 at 06:25:19PM +0100, Robin Murphy wrote:
>>> On 2020-08-20 17:53, Sakari Ailus wrote:
Hi Robin,
On Thu, Aug 20, 2020 at 04:08:36PM +0100, Robin Murphy wrote:
> Now that arch
Hi Robin,
On 8/20/20 10:08 AM, Robin Murphy wrote:
> Now that arch/arm is wired up for default domains and iommu-dma,
> implement the corresponding driver-side support for DMA domains.
>
> Signed-off-by: Robin Murphy
> ---
> drivers/iommu/omap-iommu.c | 22 +-
> 1 file chang
437:47: warning:
> format ‘%x’ expects argument of type ‘unsigned int’,
> but argument 7 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
>
> Signed-off-by: Krzysztof Kozlowski
With "iommu/omap: ..." on the subject-line as per the current convention,
Acked-by: Suman A
^~~~
>>
>> vim +44 drivers/iommu/omap-iopgtable.h
>>
>> 97ec7d585b33bb arch/arm/plat-omap/iopgtable.h Hiroshi DOYU 2010-02-15 38
>> 97ec7d585b33bb arch/arm/plat-omap/iopgtable.h Hiroshi DOYU 2010-02-15 39 /*
>> 97ec7d585b33b
Hi Tony,
On 8/26/19 7:14 PM, Suman Anna wrote:
> Hi Tony,
>
> The following 2 patches need to go along with the recent "iommu/omap: misc
> fixes" series [1] that is currently staged [2] for a 5.4 merge and available
> in linux-next. That series added runtime pm callbacks
ough runtime
> pm callbacks")
> Signed-off-by: Arnd Bergmann
Acked-by: Suman Anna
> ---
> drivers/iommu/omap-iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 451e3
le of days.
regards
Suman
[1]
https://lore.kernel.org/linux-iommu/20190809153730.gf12...@8bytes.org/T/#mec99f8e8ed351689f4fcc76f4f000f9144a02b51
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git/log/?h=arm/omap
[3] https://patchwork.kernel.org/patch/11082125/#22829477
Suman Anna
Us through pdata quirks to
maintain functionality.
Signed-off-by: Suman Anna
---
arch/arm/mach-omap2/pdata-quirks.c | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/mach-omap2/pdata-quirks.c
b/arch/arm/mach-omap2/pdata-quirks.c
index 6c6f8fce854e..dbe8d9718f70 100644
--- a/arc
backs") to enable/disable the clocks properly
and maintain the reference count and the omap_hwmod state machine.
So, add these callbacks through iommu pdata quirks for the OMAP3
ISP IOMMU.
Signed-off-by: Suman Anna
---
arch/arm/mach-omap2/pdata-quirks.c | 7 +++
1 file changed, 7 insertions
The macro SLAB_HWCACHE_ALIGN is of type slab_flags_t, but is currently
assigned in the OMAP IOMMU driver using a unsigned long variable. This
generates a sparse warning around the type check. Fix this by defining
the variable flags using the correct type.
Signed-off-by: Suman Anna
---
drivers
On 8/9/19 11:13 AM, Joerg Roedel wrote:
> On Wed, Aug 07, 2019 at 11:26:50AM +0300, Tero Kristo wrote:
>> +static inline int omap_iommu_domain_deactivate(struct iommu_domain *domain)
>> {}
>> +static inline int omap_iommu_domain_activate(struct iommu_domain *domain) {}
>
> This caused compilation
into this patch.
include/linux/platform_data/iommu-omap.h
Acked-by: Suman Anna
regards
Suman
> ---
> drivers/iommu/omap-iommu-debug.c | 5 +
> drivers/iommu/omap-iommu.c | 5 +
> drivers/iommu/omap-iommu.h | 5 +
> drivers/iommu/omap-iopgtable.h | 5 +--
0 Aug 8 03:59 subsystem ->
../../../../bus/platform
-rw-r--r--1 root root 4096 Aug 8 03:59 uevent
Suman Anna (2):
iommu/omap: Change the attach detection logic
iommu/omap: Add support to program multiple iommus
drivers/iommu/omap-iommu.c | 375 +
multiple iommu devices to be
bound to a single iommu domain, and thereby to a client device.
Signed-off-by: Suman Anna
---
v2: No changes
drivers/iommu/omap-iommu.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu
l IOMMU objects.
Signed-off-by: Suman Anna
[t-kri...@ti.com: ported support to 4.13 based kernel]
Signed-off-by: Tero Kristo
---
v2:
- Added a new helper omap_iommu_can_register() function which is
used in probe to selectively register the probed IOMMU platform
devices with the IOMMU core.
- Th
On 09/01/2017 11:33 AM, Joerg Roedel wrote:
> Hi Suman,
> On Fri, Sep 01, 2017 at 11:21:45AM -0500, Suman Anna wrote:
>> It's primarily a question of whether each iommu platform device need to
>> be represented as a unique iommu_device or not. If you still think that
&
Hi Joerg,
On 09/01/2017 05:01 AM, Joerg Roedel wrote:
> Hi Suman,
>
> On Thu, Aug 31, 2017 at 08:14:02AM -0500, Suman Anna wrote:
>> The OMAP IOMMU driver has been enhanced to support allowing
>> multiple IOMMUs to be programmed by a single client user. This
>> suppo
0 Aug 8 03:59 power
drwxr-xr-x3 root root 0 Aug 8 04:03 remoteproc
lrwxrwxrwx1 root root 0 Aug 8 03:59 subsystem ->
../../../../bus/platform
-rw-r--r--1 root root 4096 Aug 8 03:59 uevent
Suman Anna (2):
iommu/omap: Change th
MU debugfs code still continues to operate on
individual IOMMU objects.
Signed-off-by: Suman Anna
[t-kri...@ti.com: ported support to 4.13 based kernel]
Signed-off-by: Tero Kristo
---
drivers/iommu/omap-iommu.c | 307 ++---
drivers/iommu/omap-iommu.h
multiple iommu devices to be
bound to a single iommu domain, and thereby to a client device.
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index
vices always see the
> updated page table entries. The outer caches are now addressed
> automatically with the usage of the DMA API.
>
> Signed-off-by: Josue Albarran
Thanks for fixing this,
Acked-by: Suman Anna
[snip]
___
iommu mailing l
On 06/28/2017 07:00 AM, Joerg Roedel wrote:
> From: Joerg Roedel
>
> Make sure that the device_group callback returns an ERR_PTR
> instead of NULL.
>
> Signed-off-by: Joerg Roedel
Thanks for the patch,
Acked-by: Suman Anna
regards
Suman
> ---
> drivers/iommu/omap-
[s-a...@ti.com: few minor cleanups]
Signed-off-by: Suman Anna
---
v3 w.r.t v1:
- dropped the iommu_domain from arch_data (same as in v2)
- squashed patch 3 from v1 into this patch
- minor revisions to the commit subject and description
- renamed the iommu variable to oiommu in add_device
: Suman Anna
---
v3: new patch
drivers/media/platform/omap3isp/isp.c | 17 -
drivers/media/platform/omap3isp/isp.h | 1 -
2 files changed, 18 deletions(-)
diff --git a/drivers/media/platform/omap3isp/isp.c
b/drivers/media/platform/omap3isp/isp.c
index 084ecf4aa9a4..0d984a28a003
ake use of 'struct iommu_device'
iommu/omap: Add iommu-group support
Suman Anna (3):
iommu/omap: Register driver before setting IOMMU ops
iommu/omap: Drop legacy-style device support
[media] omap3isp: Remove iommu_group related code
drivers/iommu/omap
From: Joerg Roedel
Modify the driver to register individual iommus and
establish links between devices and iommus in sysfs.
Signed-off-by: Joerg Roedel
[s-a...@ti.com: fix some cleanup issues during failures]
Signed-off-by: Suman Anna
---
v3 w.r.t v1:
- moved the iommu_device calls in probe
: revise kerneldoc comments]
Signed-off-by: Suman Anna
---
v3 w.r.t v2:
- added kerneldoc comment for @domain
- renamed iommu_arch_data to omap_iommu_arch_data in comments
drivers/iommu/omap-iommu.c | 16
drivers/iommu/omap-iommu.h | 33
platform data is still needed though for
performing reset management properly in a multi-arch environment.
Signed-off-by: Suman Anna
---
v3: New patch
drivers/iommu/omap-iommu.c | 30 ++
include/linux/platform_data/iommu-omap.h | 3 ---
2 files changed, 14
driver.
While at this, also check for the return status from bus_set_iommu.
Signed-off-by: Suman Anna
---
v3: New patch
drivers/iommu/omap-iommu.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
From: Joerg Roedel
Support for IOMMU groups will become mandatory for drivers,
so add it to the omap iommu driver.
Signed-off-by: Joerg Roedel
[s-a...@ti.com: minor error cleanups]
Signed-off-by: Suman Anna
---
v3 w.r.t v1:
- iommu_group_get_for_dev() failure path cleanup code added in
Hi Joerg,
This patch is still causing couple of issues.
Adding Laurent and Sakari to the thread as we do have the OMAP3ISP
driver which would need some changes once the iommu groups are
implemented in the OMAP IOMMU driver. The OMAP3 ISP driver
(drivers/media/platform/omap3isp/isp.c) is currently
Hi Joerg,
On 04/07/2017 09:41 AM, Joerg Roedel wrote:
> From: Joerg Roedel
>
> Modify the driver to register individual iommus and
> establish links between devices and iommus in sysfs.
>
> Signed-off-by: Joerg Roedel
> ---
> drivers/iommu/omap-iommu.c | 25 +
> driver
On 04/07/2017 09:41 AM, Joerg Roedel wrote:
> From: Joerg Roedel
>
> Don't leave a stale pointer in case the device continues to
> exist for some more time.
>
> Signed-off-by: Joerg Roedel
Acked-by: Suman Anna
> ---
> drivers/iommu/omap-iommu.c | 2 ++
&g
On 04/07/2017 09:41 AM, Joerg Roedel wrote:
> From: Joerg Roedel
>
> The internal data-structures are scattered over various
> header and C files. Consolidate them in omap-iommu.h.
>
> Signed-off-by: Joerg Roedel
Acked-by:
Hi Joerg,
On 03/31/2017 07:10 AM, Joerg Roedel wrote:
> From: Joerg Roedel
>
> Instead of finding the matching IOMMU for a device using
> string comparision functions, keep the pointer to the
> iommu_dev in arch_data permanently populated.
>
> Signed-off-by: Joerg Roedel
> ---
> drivers/iommu
Hi Joerg,
On 03/31/2017 07:10 AM, Joerg Roedel wrote:
> From: Joerg Roedel
>
> Don't leave a stale pointer in case the device continues to
> exist for some more time.
>
> Signed-off-by: Joerg Roedel
> ---
> drivers/iommu/omap-iommu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/d
On 03/31/2017 07:10 AM, Joerg Roedel wrote:
> From: Joerg Roedel
>
> The internal data-structures are scattered over various
> header and C files. Consolidate them in omap-iommu.h.
>
> Signed-off-by: Joerg Roedel
> ---
> drivers/iommu/omap-iommu.c | 16
> drivers
Hi Joerg,
On 03/31/2017 07:10 AM, Joerg Roedel wrote:
> Hi,
>
> here is a small patch-set for the omap-iommu driver to make
> it use new features of the iommu-core. Please review.
Thanks for the patches - this has been on my TODO list but you beat me
in getting there first :). Are these for 4.12
The iopgtable_store_entry_core() function uses a BUG() statement
for an unsupported page size entry programming. Replace this with
a less severe WARN_ON() and perform a graceful bailout on error.
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu.c | 4 +++-
1 file changed, 3 insertions
The OMAP IOMMU page table needs to be aligned on a 16K boundary,
and the current code uses a BUG_ON on the alignment sanity check
in the .domain_alloc() ops implementation. Replace this with a
less severe WARN_ON and bail out gracefully.
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu.c
This patch fixes one existing alignment checkpatch check
warning of the type "Alignment should match open parenthesis"
in the OMAP IOMMU debug source file.
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu-debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
remove.
Removing this fixes a NULL pointer dereference crash if the IOMMU
device is unbound from the driver with no client device attached
to the IOMMU device.
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iommu/omap-iommu.c b
flow. Feel free to
pick it up either for the -rc cycle or for the next merge window.
Remaining patches are trivial cleanups addressing some of the current
checkpatch warnings/checks.
regards
Suman
Suman Anna (4):
iommu/omap: Remove iopgtable_clear_entry_all() from driver remove
iommu/omap
Hi Tony,
On 09/16/2015 06:48 PM, Suman Anna wrote:
> Hi Tony,
>
> The following series removes the legacy platform device creation
> logic for OMAP IOMMU devices. I will cleanup the legacy support
> from the OMAP IOMMU driver in a subsequent merge window after
> this series ma
Hi Tony,
On 10/12/2015 04:43 PM, Tony Lindgren wrote:
> * Suman Anna [151002 16:27]:
>> The DSP_SYSTEM sub-module is a dedicated system control logic
>> module present within a DRA7 DSP processor sub-system. This
>> module is responsible for power management, clock generat
[2] http://marc.info/?l=linux-omap&m=144382697928741&w=2
Suman Anna (4):
ARM: dts: DRA7: Add dsp1_system syscon node
ARM: dts: DRA74x: Add dsp2_system syscon node
ARM: dts: DRA7: Add common IOMMU nodes
ARM: dts: DRA74x: Add IOMMU nodes for DSP2
arch/arm/boot/dts/
family.
Signed-off-by: Suman Anna
---
arch/arm/boot/dts/dra74x.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/dra74x.dtsi b/arch/arm/boot/dts/dra74x.dtsi
index feea98e0a4b5..dfa29b7ba86a 100644
--- a/arch/arm/boot/dts/dra74x.dtsi
+++ b/arch/arm/boot/dts/dra74x.dtsi
family.
Signed-off-by: Suman Anna
---
arch/arm/boot/dts/dra7.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index e289c706d27d..62055094e8d5 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -292,6
second MMU within
the DSP subsystem for the EDMA port. The DSP IOMMUs also need
an additional 'ti,syscon-mmuconfig' property compared to the
IPU IOMMUs.
NOTE: The enabling of these nodes is left to the respective
board dts files.
Signed-off-by: Suman Anna
---
arch/arm/boot/dts/dra7
The DRA74x family of SoCs have a second DSP, that also has
two MMUs just like the DSP1 subsystem. Add the IOMMU nodes
for this DSP2 subsystem in disabled state to the DRA74x
specific DTS file, the nodes would need to be enabled
appropriately in the respective board DTS files.
Signed-off-by: Suman
ONFIG register programming is achieved through
the processing of the optional "ti,syscon-mmuconfig" property.
A proper value is assigned to the id field only when this
property is present.
Signed-off-by: Suman Anna
---
drivers/iommu/om
cument for clarity.
Signed-off-by: Suman Anna
---
.../devicetree/bindings/iommu/ti,omap-iommu.txt| 27 ++
1 file changed, 27 insertions(+)
diff --git a/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt
b/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt
index 86
://marc.info/?l=linux-omap&m=144356627831318&w=2
[6] http://marc.info/?l=linux-omap&m=143752332808524&w=2
Suman Anna (2):
Documentation: dt: Update OMAP iommu bindings for DRA7 DSPs
iommu/omap: Add support for configuring dsp iommus on DRA7xx
.../devicetree/bindings/iommu/ti,omap-i
The legacy-mode device creation logic for IOMMU devices has
been cleaned up, so the device attribute data, irq information
and address data are no longer required. Remove all of these
data for the ISP & IVA IOMMU devices.
Signed-off-by: Suman Anna
---
arch/arm/mach-omap2/omap_hwmod_3xxx_da
OMAP4 has been DT-boot only for some time, and the legacy-mode
device creation logic for IOMMU devices has also been cleaned up,
so the dev_attr and address data is no longer required. So, remove
these attribute data and hwmod addr space for the IPU & DSP IOMMU
devices.
Signed-off-by: Suman
definition altogether, so will
cause build issues if picked separately from the hwmod cleanup
patches.
I do not have any boards where I can still perform a legacy-style
boot, so patches verified using DT-boot only.
regards
Suman
[1] https://patchwork.kernel.org/patch/6806891/
Suman Anna (4
needed, so remove it.
Signed-off-by: Suman Anna
---
include/linux/platform_data/iommu-omap.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/include/linux/platform_data/iommu-omap.h
b/include/linux/platform_data/iommu-omap.h
index 54a0a9582fad..0496d171700a 100644
--- a/include/linux
Drop platform data support")
removed the legacy device support from the OMAP3 ISP driver, so the
legacy device instantiation of OMAP IOMMU devices is no longer
needed, and is cleaned up.
Signed-off-by: Suman Anna
---
arch/arm/mach-omap2/omap-iommu.c | 66 --
Hi Tony,
Sorry for the long delay in getting back on this. I will repost the
series once 4.3-rc1 is out, but at the moment I do not think any changes
are required. Let me know if you still need any additional details.
>>>> On 07/23/2015 02:24 AM, Tony Lindgren wrote:
>>>>
On 08/03/2015 11:31 AM, Joerg Roedel wrote:
> On Tue, Jul 21, 2015 at 06:55:34PM -0500, Suman Anna wrote:
>> The patches are baselined on 4.2-rc3 + the recent OMAP IOMMU
>> cleanup series [1]. I will post the DTS patches separately to
>> allow Tony to pick them up indepen
On 08/03/2015 08:55 AM, Joerg Roedel wrote:
> On Mon, Jul 20, 2015 at 05:33:22PM -0500, Suman Anna wrote:
>> Suman Anna (11):
>> Documentation: dt: Add #iommu-cells info to OMAP iommu bindings
>> iommu/omap: Remove all module references
>> iommu/omap: Move debu
Hi Tony,
On 07/23/2015 11:30 PM, Tony Lindgren wrote:
> * Suman Anna [150723 09:25]:
>> Hi Tony,
>>
>> On 07/23/2015 02:24 AM, Tony Lindgren wrote:
>>> * Suman Anna [150722 09:25]:
>>>> On 07/22/2015 12:26 AM, Tony Lindgren wrote:
>>>>&g
Hi Tony,
On 07/23/2015 02:24 AM, Tony Lindgren wrote:
> * Suman Anna [150722 09:25]:
>> On 07/22/2015 12:26 AM, Tony Lindgren wrote:
>>>
>>> I don't like using syscon for tinkering directly with SoC registers.
>>
>> This is not a SoC-level register,
Hi Tony,
On 07/22/2015 12:26 AM, Tony Lindgren wrote:
> * Suman Anna [150721 16:58]:
>> --- a/drivers/iommu/omap-iommu.c
>> +++ b/drivers/iommu/omap-iommu.c
>> @@ -26,6 +26,8 @@
>> #include
>> #include
>> #include
>> +#include
>> +#in
=linux-omap&m=143752295508435&w=2
Suman Anna (4):
ARM: dts: DRA7: Add dsp1_system syscon node
ARM: dts: DRA74x: Add dsp2_system syscon node
ARM: dts: DRA7: Add common IOMMU nodes
ARM: dts: DRA74x: Add IOMMU nodes for DSP2
arch/arm/boot/dts/dra7.dts
family.
Signed-off-by: Suman Anna
---
arch/arm/boot/dts/dra74x.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/dra74x.dtsi b/arch/arm/boot/dts/dra74x.dtsi
index fa995d0ca1f2..6cb112450ddd 100644
--- a/arch/arm/boot/dts/dra74x.dtsi
+++ b/arch/arm/boot/dts/dra74x.dtsi
second MMU within
the DSP subsystem for the EDMA port. The DSP IOMMUs also need
an additional 'ti,syscon-mmuconfig' property compared to the
IPU IOMMUs.
NOTE: The enabling of these nodes is left to the respective
board dts files.
Signed-off-by: Suman Anna
---
arch/arm/boot/dts/dra7
The DRA74x family of SoCs have a second DSP, that also has
two MMUs just like the DSP1 subsystem. Add the IOMMU nodes
for this DSP2 subsystem in disabled state to the DRA74x
specific DTS file, the nodes would need to be enabled
appropriately in the respective board DTS files.
Signed-off-by: Suman
family.
Signed-off-by: Suman Anna
---
arch/arm/boot/dts/dra7.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 8f1e25bcecbd..1c96729641b6 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -296,6
s [1]. I will post the DTS patches separately to
allow Tony to pick them up independently.
regards
Suman
[1] http://lists.linuxfoundation.org/pipermail/iommu/2015-July/013659.html
Suman Anna (2):
Documentation: dt: Update OMAP iommu bindings for DRA7 DSPs
iommu/omap: Add support for configu
ONFIG register programming is achieved through
the processing of the optional "ti,syscon-mmuconfig" property.
A proper value is assigned to the id field only when this
property is present.
Signed-off-by: Suman Anna
---
drivers/iommu/om
cument for clarity.
Signed-off-by: Suman Anna
---
.../devicetree/bindings/iommu/ti,omap-iommu.txt| 27 ++
1 file changed, 27 insertions(+)
diff --git a/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt
b/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt
index 86
Hi Laurent,
>
> On Monday 20 July 2015 17:33:24 Suman Anna wrote:
>> The OMAP IOMMU driver has been adapted to the IOMMU framework
>> for a while now, and it does not support being built as a
>> module anymore. So, remove all the module references from the
>> OMAP I
warning about using a blank line
after function/struct/union/enum declarations.
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index a22c33d6a486
Switch to using the BIT(x) macros in omap-iommu.h where
possible. This eliminates the following checkpatch check
warning:
"CHECK: Prefer using the BIT macro"
A couple of the warnings were ignored for better readability
of the bit-shift for the different values.
Signed-off-by:
routines are in one place.
The move required exposing some new functions and moving some
definitions to the internal omap-iommu.h header file.
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu-debug.c | 111 +
drivers/iommu/omap-iommu.c | 148
Protect the omap-pgtable.h header against double inclusion in
source code by using the standard include guard mechanism.
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iopgtable.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/iommu/omap-iopgtable.h b/drivers/iommu/omap
ned-off-by: Suman Anna
---
drivers/iommu/omap-iopgtable.h | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/iommu/omap-iopgtable.h b/drivers/iommu/omap-iopgtable.h
index bfde5405f514..01a315227bf0 100644
--- a/drivers/iommu/omap-iopgtable.h
+++
Remove the trailing semi-colon in the DEBUG_FOPS_RO macro
definition. This fixes the checking warning,
"WARNING: macros should not use a trailing semicolon"
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu-debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
Fix couple of checkpatch warnings of the type,
"WARNING: Possible unnecessary 'out of memory' message"
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/iommu/omap-iommu.c b/driver
should apply fine on any 4.2-rc.
regards
Suman
Suman Anna (11):
Documentation: dt: Add #iommu-cells info to OMAP iommu bindings
iommu/omap: Remove all module references
iommu/omap: Move debugfs functions to omap-iommu-debug.c
iommu/omap: Protect omap-iopgtable.h against double inclusion
The OMAP IOMMU bindings is updated to reflect the required #iommu-cells
property.
Signed-off-by: Suman Anna
---
Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt
b
There are couple of unions defined in the structures
iotlb_entry and cr_regs. There are no usage/references
to some of these union fields in the code, so clean
them up and simplify the structures.
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu.h | 23 +++
1 file
Fix all the occurrences of the following check warning
generated with the checkpatch --strict option:
"CHECK: Alignment should match open parenthesis"
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu.c | 23 +++
1 file changed, 11 insertions(+), 12
Use separate assignments for assigning the same value into
different variables. This fixes the following check warning
generated with the checkpatch --strict option:
"CHECK: multiple assignments should be avoided"
Signed-off-by: Suman Anna
---
drivers/iommu/omap-iommu.c | 6
Hi Thierry,
On 02/06/2015 04:44 AM, Thierry Reding wrote:
> From: Thierry Reding
>
> Hi Joerg,
>
> Here are a couple of urgent fixes for a regression on old Tegra devices
> related to IOMMU support. The issue is that many drivers think it's a
> good idea to register IOMMU support unconditionall
he DRM driver will try to use the
>> obviously non-existent OMAP IOMMU.
>>
>> Reported-by: Nicolas Chauvet
>> Cc: Tony Lindgren
>> Cc: Suman Anna
>> Cc: Laurent Pinchart
>> Signed-off-by: Thierry Reding
>> ---
>> drivers/iommu/omap-iommu.c | 6 +
"Operation not permitted" trace when the
corresponding IOMMU is not enabled.
Signed-off-by: Suman Anna
Acked-by: Laurent Pinchart
---
drivers/iommu/omap-iommu-debug.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/iommu/omap-iommu-debug.c b/drivers/iommu/
LB is defined
- iotlb_dump_cr() is similarly defined only when CONFIG_OMAP_IOMMU_DEBUG
is defined
- Elimination of the OMAP IOMMU exported functions to register the
arch ops, omap_install_iommu_arch() & omap_uninstall_iommu_arch()
- Any stale comments about OMAP1 are also cleaned up
Signed-off-
The isr_priv field is a left-over from before the IOMMU API
adaptation, this was used to store the callback data. This is
no longer relevant, so remove it.
Signed-off-by: Suman Anna
Acked-by: Laurent Pinchart
---
drivers/iommu/omap-iommu.h | 1 -
1 file changed, 1 deletion(-)
diff --git a
k.kernel.org/patch/5007261/
[3]
https://github.com/sumananna/omap-kernel/commits/iommu/submit/3.18-rc1-cleanup-consolidation-v2
Suman Anna (17):
iommu/omap: Remove refcount field from omap_iommu object
iommu/omap: Remove unused isr_priv field from omap_iommu
iommu/omap: Remove duplicate
making the debugfs entry 'pagetable' read-only.
Signed-off-by: Suman Anna
Acked-by: Laurent Pinchart
---
drivers/iommu/omap-iommu.c | 21 -
drivers/iommu/omap-iommu.h | 5 -
2 files changed, 26 deletions(-)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/
The omap2_iommu_save_ctx() and omap2_iommu_restore_ctx()
performs a sanity version check against a fixed value
that is correct only for OMAP2/OMAP3 IOMMUs. This fixed check
does not scale for all OMAP2+ IOMMUs and is not absolutely
required, so it has been removed.
Signed-off-by: Suman Anna
igned-off-by: Suman Anna
Acked-by: Laurent Pinchart
---
drivers/iommu/omap-iommu.c | 9 -
drivers/iommu/omap-iommu.h | 4
drivers/iommu/omap-iommu2.c | 2 --
3 files changed, 15 deletions(-)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index ea04e4d..f9
The .domain field in omap_iommu struct is set properly when the
OMAP IOMMU device is attached to, but is never reset properly
on detach. Reset this properly so that the OMAP IOMMU debugfs
logic can depend on this field before allowing the debugfs
operations.
Signed-off-by: Suman Anna
Acked-by
-off-by: Suman Anna
Acked-by: Laurent Pinchart
---
drivers/iommu/omap-iommu.c | 15 +++
drivers/iommu/omap-iommu.h | 1 -
2 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index 3627887..ea04e4d 100644
--- a/drivers
The omap_iommu_save_ctx() and omap_iommu_restore_ctx() declarations
are defined in include/linux/omap-iommu.h and do not belong in the
internal drivers/iommu/omap-iommu.h header, so remove them.
Signed-off-by: Suman Anna
Acked-by: Laurent Pinchart
---
drivers/iommu/omap-iommu.h | 3 ---
1 file
1 - 100 of 233 matches
Mail list logo
