Re: [PATCH v7 0/10] iommu/vt-d: Fix intel vt-d faults in kdump kernel

2015-01-07 Thread Takao Indoh
On 2015/01/07 17:52, Li, ZhenHua wrote: > Well, that's quite good news. > Looking forward Takao's testing on his system. Unfortunately DMAR fault still occurs with this patch... I attach console log. Thanks, Takao Indoh > > Regards > Zhenhua > On 01/07/2015 04:28 PM

Re: [PATCH 0/10] iommu/vt-d: Fix intel vt-d faults in kdump kernel

2015-01-05 Thread Takao Indoh
On 2014/12/29 12:15, Li, ZhenHua wrote: > Hi Takao Indoh, > > Happy New Year, and thank you very much for you help. The flush is quite Happy new year! > a problem, as there are several places the flush function should be called, > I think the flush should be placed in

Re: [PATCH 0/10] iommu/vt-d: Fix intel vt-d faults in kdump kernel

2014-12-25 Thread Takao Indoh
On 2014/12/26 15:46, Li, ZhenHua wrote: > Hi Takao Indoh, > > Thank you very much for your testing. I will add your update in next > version. > Also I think a flush for __iommu_update_old_root_entry is also necessary. > > Currently I have no idea about your fault, doe

Re: [PATCH 0/10] iommu/vt-d: Fix intel vt-d faults in kdump kernel

2014-12-25 Thread Takao Indoh
nfiremd your commit 1a2262 was already applied. Any idea? Thanks, Takao Indoh On 2014/12/22 18:15, Li, Zhen-Hua wrote: > This patchset is an update of Bill Sumner's patchset, implements a fix for: > If a kernel boots with intel_iommu=on on a system that supports intel vt-d, > whe

Re: [PATCH 0/5] iommu/vt-d: Fix crash dump failure caused by legacy DMA/IO

2014-11-05 Thread Takao Indoh
et, userbuf); + + if (page_is_ram(pfn)) { + memcpy(buf, pfn_to_kaddr(pfn) + offset, csize); + ret = size; + } else + ret = copy_oldmem_page(pfn, buf, csize, offset, userbuf); return (int) ret; } Thanks, Takao Indoh > > On 11/06/2014 09:48 AM, Taka

Re: [PATCH 0/5] iommu/vt-d: Fix crash dump failure caused by legacy DMA/IO

2014-11-05 Thread Takao Indoh
thank you. Thanks, Takao Indoh > > Thanks > Zhenhua > > On 11/06/2014 09:31 AM, Takao Indoh wrote: >> Hi Zhenhua, Baoquan, >> >> (2014/10/22 19:05), Baoquan He wrote: >>> Hi Zhenhua, >>> >>> I tested your latest patch on 3.18.0-rc1+,

Re: [PATCH 0/5] iommu/vt-d: Fix crash dump failure caused by legacy DMA/IO

2014-11-05 Thread Takao Indoh
> + shift = aw_shift[aw]; > + > + pgt_old_phys = (struct dma_pte *) > + (context_address_root(ce) << VTD_PAGE_SHIFT); > + > + ret = copy_page_table(&pgt_new_phys, pgt_old_phys, > +

Re: [RFC PATCH] Crashdump Accepting Active IOMMU

2013-11-19 Thread Takao Indoh
You asked: " Do you have a plan to post new version?" > Yes. I am in the process of dividing the code into a set of 6 or 7 patches, > and completing the due-diligence on these patches before submitting them. Ok, I'll wait for new patches! Thanks, Takao Indoh >

[PATCH v2] intel-iommu: Quiesce devices before disabling IOMMU

2013-09-17 Thread Takao Indoh
last kdump fails. This patch fixes this problem. Changelog: v2: - Add CONTEXT_ENTRY_NR v1: https://lkml.org/lkml/2013/8/21/71 Signed-off-by: Takao Indoh --- drivers/iommu/intel-iommu.c | 56 ++- 1 files changed, 55 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] intel-iommu: Quiesce devices before disabling IOMMU

2013-09-09 Thread Takao Indoh
(2013/09/09 18:07), David Woodhouse wrote: > On Wed, 2013-08-21 at 16:15 +0900, Takao Indoh wrote: >> >> This causes problem on kdump. Devices are working in first kernel, and >> after switching to second kernel and initializing IOMMU, many DMAR faults >> occur and it

Re: [PATCH] intel-iommu: Quiesce devices before disabling IOMMU

2013-09-08 Thread Takao Indoh
(2013/09/09 13:28), Takao Indoh wrote: >> BTW, what's the status of Alex's PCI patchset which this patch depends >> on? > > It is merged to Bjorn's tree, will be in v3.12. This was wrong. Alex's patchset is already in L

Re: [PATCH] intel-iommu: Quiesce devices before disabling IOMMU

2013-09-08 Thread Takao Indoh
(2013/09/08 20:47), Baoquan He wrote: > Hi, > Patch is great and works on my HP-z420. Thank you for your test! > There are several small concerns, please see inline comments. > > On 08/21/13 at 04:15pm, Takao Indoh wrote: >> This patch quiesces devices before disabling

[PATCH] intel-iommu: Quiesce devices before disabling IOMMU

2013-08-21 Thread Takao Indoh
last kdump fails. This patch fixes this problem. Signed-off-by: Takao Indoh NOTE: To reset devices this patch uses bus reset interface introduced by following commits in PCI "next" branch. 64e8674fbe6bc848333a9b7e19f8cc019dde9eab 5c32b35b004f5ef70dcf62bbc42b8b

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-05-21 Thread Takao Indoh
Hi Bjorn, Any comments, ack/nack? Thanks, Takao Indoh (2013/05/15 7:04), Eric W. Biederman wrote: > Takao Indoh writes: > >> This patch resets PCIe devices on boot to stop ongoing DMA. When >> "pci=pcie_reset_endpoint_devices" is specified, a hot reset is trigger

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-05-15 Thread Takao Indoh
rred after its driver was loaded. One of ideas is adding boot parameter so user can choose appropriate method: just clearing bus master, FLR, hot-reset, etc. Thanks, Takao Indoh > > Bill Sumner > > > > -Original Message- > From: Takao Indoh [mailto:indou.ta...@jp.fujit

[PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-05-13 Thread Takao Indoh
is skipped because the monitor blacks out if VGA controller is reset. Changelog: v2: - Read pci config before de-assert secondary bus reset to flush previous write - Change function/variable name - Make a list of devices to be reset v1: https://patchwork.kernel.org/patch/2482291/ Signed-off

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-05-08 Thread Takao Indoh
(2013/04/26 3:01), Don Dutile wrote: > On 04/25/2013 01:11 AM, Takao Indoh wrote: >> (2013/04/25 4:59), Don Dutile wrote: >>> On 04/24/2013 12:58 AM, Takao Indoh wrote: >>>> This patch resets PCIe devices on boot to stop ongoing DMA. When >>>> "pci=p

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-05-08 Thread Takao Indoh
(2013/05/08 7:04), Alex Williamson wrote: > On Tue, 2013-05-07 at 16:10 -0400, Don Dutile wrote: >> On 05/07/2013 12:39 PM, Alex Williamson wrote: >>> On Wed, 2013-04-24 at 13:58 +0900, Takao Indoh wrote: >>>> This patch resets PCIe devices on boot to st

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-05-08 Thread Takao Indoh
(2013/05/07 21:50), Don Dutile wrote: > On 05/07/2013 03:09 AM, Takao Indoh wrote: >> Sorry for the delayed response. >> >> (2013/04/30 23:54), Sumner, William wrote: >>> I have installed your original patch set (from last November) and tested >>> with th

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-05-07 Thread Takao Indoh
still hangs up or not. subordinate = dev->subordinate; list_for_each_entry(child, &subordinate->devices, bus_list) { dev_info(&child->dev, "save state\n"); pci_save_state(child); + pci_write_config_word(c

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-04-25 Thread Takao Indoh
(2013/04/26 3:01), Don Dutile wrote: > On 04/25/2013 01:11 AM, Takao Indoh wrote: >> (2013/04/25 4:59), Don Dutile wrote: >>> On 04/24/2013 12:58 AM, Takao Indoh wrote: >>>> This patch resets PCIe devices on boot to stop ongoing DMA. When >>>> "pci=p

Re: [PATCH] Reset PCIe devices to stop ongoing DMA

2013-04-24 Thread Takao Indoh
(2013/04/25 4:59), Don Dutile wrote: > On 04/24/2013 12:58 AM, Takao Indoh wrote: >> This patch resets PCIe devices on boot to stop ongoing DMA. When >> "pci=pcie_reset_devices" is specified, a hot reset is triggered on each >> PCIe root port and downstream port t

[PATCH] Reset PCIe devices to stop ongoing DMA

2013-04-23 Thread Takao Indoh
814 Signed-off-by: Takao Indoh --- Documentation/kernel-parameters.txt |2 + drivers/pci/pci.c | 103 +++ 2 files changed, 105 insertions(+), 0 deletions(-) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.tx

[PATCH v2] intel-iommu: Disable translation if already enabled

2013-04-23 Thread Takao Indoh
igned-off-by: Takao Indoh --- drivers/iommu/dmar.c| 11 ++- drivers/iommu/intel-iommu.c | 15 +++ 2 files changed, 25 insertions(+), 1 deletions(-) diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c index e5cdaf8..9f69352 100644 --- a/drivers/iommu/dma

Re: [PATCH 1/1] intel-iommu: Disable DMA Remapping when intel_iommu=off

2013-04-22 Thread Takao Indoh
(2013/04/22 15:50), Wei Hu wrote: > On Sun, Apr 21, 2013 at 10:31 PM, Takao Indoh > wrote: >> (2013/04/20 15:58), Wei Hu wrote: >>> On a VT-d capable machine Linux will enable IOMMU by default. If it >>> then kexec's a second kernel with intel_iommu=off, this s

Re: [PATCH 1/1] intel-iommu: Disable DMA Remapping when intel_iommu=off

2013-04-21 Thread Takao Indoh
n(iommu); } Note, if you agree above code and fix your patch like this, you need additinal fix to set iommu->gcmd flag sinse gcmd is always zero here. See first hunk of this patch. https://lkml.org/lkml/2013/3/20/707 Thanks, Takao Indoh > > Signed-off-by: Wei Hu &g

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-17 Thread Takao Indoh
(2013/04/15 19:18), Joerg Roedel wrote: > On Mon, Apr 15, 2013 at 06:00:13PM +0900, Takao Indoh wrote: >> On DMAR initialization during kdump boot, do you guys agree to change >> order like this? >> >> Current order: >> (1) Disable translation >> (2) PCI

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-15 Thread Takao Indoh
(2013/04/10 13:47), Takao Indoh wrote: > (2013/04/05 20:06), Joerg Roedel wrote: >> On Wed, Apr 03, 2013 at 09:24:39AM +0100, David Woodhouse wrote: >>> On Wed, 2013-04-03 at 16:11 +0900, Takao Indoh wrote: >>>> Yeah, you are right. I forgot such a case. >>

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-09 Thread Takao Indoh
(2013/04/05 20:06), Joerg Roedel wrote: > On Wed, Apr 03, 2013 at 09:24:39AM +0100, David Woodhouse wrote: >> On Wed, 2013-04-03 at 16:11 +0900, Takao Indoh wrote: >>> Yeah, you are right. I forgot such a case. >> >> If you disable translation and there's some de

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-08 Thread Takao Indoh
(2013/04/04 23:24), David Woodhouse wrote: > On Thu, 2013-04-04 at 14:48 +0900, Takao Indoh wrote: >> >> - DMAR fault messages floods and second kernel does not boot. Recently I >>saw similar report. https://lkml.org/lkml/2013/3/8/120 > > Right. So the fix for tha

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-03 Thread Takao Indoh
(2013/04/03 17:24), David Woodhouse wrote: > On Wed, 2013-04-03 at 16:11 +0900, Takao Indoh wrote: >> (2013/04/02 23:05), Joerg Roedel wrote: >>> On Mon, Apr 01, 2013 at 02:45:18PM +0900, Takao Indoh wrote: >>>> >>>> ena

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-04-03 Thread Takao Indoh
(2013/04/02 23:05), Joerg Roedel wrote: > On Mon, Apr 01, 2013 at 02:45:18PM +0900, Takao Indoh wrote: >> >> enable_IR >>intel_enable_irq_remapping >> iommu_disable_irq_remapping <== IRES/QIES/TES disabled here >> dmar_disable_qi &

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-03-31 Thread Takao Indoh
(2013/03/27 19:31), Joerg Roedel wrote: > On Wed, Mar 27, 2013 at 02:02:44PM +0900, Takao Indoh wrote: >> The root cause of this problem is mismatch between iommu->gcmd and >> global command register in the case of kdump. At boot time, initial >> value of iommu->gcmd is

Re: [PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-03-26 Thread Takao Indoh
(2013/03/26 23:46), Joerg Roedel wrote: > On Thu, Mar 21, 2013 at 10:32:36AM +0900, Takao Indoh wrote: >> In this function, clearing IRE bit in iommu->gcmd and writing it to >> global command register. But initial value of iommu->gcmd is zero, so >> this writel means

[PATCH] intel-iommu: Synchronize gcmd value with global command register

2013-03-20 Thread Takao Indoh
h also changes init_dmars() to disable DMAR before initializing it if already enabled. Signed-off-by: Takao Indoh --- drivers/iommu/dmar.c| 11 ++- drivers/iommu/intel-iommu.c | 12 2 files changed, 22 insertions(+), 1 deletions(-) diff --git a/drivers/iommu/dmar