On 2020/5/1 19:37, Joerg Roedel wrote:
On Sat, Apr 18, 2020 at 09:47:03PM +0800, Tang Bin wrote:
The function qcom_iommu_device_probe() does not perform sufficient
error checking after executing devm_ioremap_resource(), which can
result in crashes if a critical error path is encountered
The function qcom_iommu_device_probe() does not perform sufficient
error checking after executing devm_ioremap_resource(), which can
result in crashes if a critical error path is encountered.
Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu")
Signed-off-by: Tang Bin
---
v2:
-
On 2020/4/18 19:54, Joerg Roedel wrote:
On Thu, Apr 16, 2020 at 02:42:23PM +0800, Tang Bin wrote:
The function qcom_iommu_device_probe() does not perform sufficient
error checking after executing devm_ioremap_resource(), which can result in
crashes if a critical error path
On 2020/4/16 18:05, Robin Murphy wrote:
On 2020-04-02 7:33 am, Tang Bin wrote:
Release resources when exiting on error.
Signed-off-by: Tang Bin
---
drivers/iommu/qcom_iommu.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu
Hi Bjorn:
On 2020/4/2 14:45, Bjorn Andersson wrote:
On Wed 01 Apr 23:33 PDT 2020, Tang Bin wrote:
Release resources when exiting on error.
Reviewed-by: Bjorn Andersson
Thanks for your positive feedback.
I don't know whether the commit message affect this patch's result. If
so, I think
> Reviewed-by:Bjorn Andersson
Thanks for your positive feedback.
Will the patch need any more clarification？Looking forward to your result,
thank you!
Regards,
Tang Bin
From: Bjorn Andersson
Date: 2020-04-02 14:45
To: Tang Bin
CC: agross; robdclark; joro; linux-arm-msm; iommu; li
Release resources when exiting on error.
Signed-off-by: Tang Bin
---
drivers/iommu/qcom_iommu.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
index 4328da0b0..c08aa9651 100644
--- a/drivers/iommu/qcom_iommu.c
