Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-08 Thread Gilad Ben-Yossef
On Tue, Mar 8, 2022 at 11:40 AM Corentin Labbe wrote: > > Le Mon, Mar 07, 2022 at 02:56:21PM +0100, Corentin Labbe a écrit : > > Le Mon, Mar 07, 2022 at 03:53:02PM +0200, Gilad Ben-Yossef a écrit : > > > On Mon, Mar 7, 2022 at 3:45 PM Corentin Labbe > > > wrote: > > > > > > > > Le Mon, Mar 07, 2

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-08 Thread Corentin Labbe
Le Mon, Mar 07, 2022 at 02:56:21PM +0100, Corentin Labbe a écrit : > Le Mon, Mar 07, 2022 at 03:53:02PM +0200, Gilad Ben-Yossef a écrit : > > On Mon, Mar 7, 2022 at 3:45 PM Corentin Labbe > > wrote: > > > > > > Le Mon, Mar 07, 2022 at 11:14:16AM +, Robin Murphy a écrit : > > > > On 2022-03-07

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Gilad Ben-Yossef
On Mon, Mar 7, 2022 at 3:45 PM Corentin Labbe wrote: > > Le Mon, Mar 07, 2022 at 11:14:16AM +, Robin Murphy a écrit : > > On 2022-03-07 10:48, Corentin Labbe wrote: > > > Le Mon, Mar 07, 2022 at 09:59:29AM +0200, Gilad Ben-Yossef a �crit : > > >> On Sun, Mar 6, 2022 at 11:49 PM Herbert Xu

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Gilad Ben-Yossef
On Mon, Mar 7, 2022 at 3:56 PM Corentin Labbe wrote: > > Le Mon, Mar 07, 2022 at 03:53:02PM +0200, Gilad Ben-Yossef a écrit : > > On Mon, Mar 7, 2022 at 3:45 PM Corentin Labbe > > wrote: > > > > > > Le Mon, Mar 07, 2022 at 11:14:16AM +, Robin Murphy a écrit : > > > > On 2022-03-07 10:48, Cor

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Gilad Ben-Yossef
On Mon, Mar 7, 2022 at 3:12 PM Robin Murphy wrote: > > On 2022-03-07 13:03, Robin Murphy wrote: > > On 2022-03-07 12:47, Gilad Ben-Yossef wrote: > >> On Mon, Mar 7, 2022 at 2:36 PM Robin Murphy wrote: > >>> > >>> On 2022-03-07 12:17, Gilad Ben-Yossef wrote: > On Mon, Mar 7, 2022 at 1:14 PM R

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Gilad Ben-Yossef
On Mon, Mar 7, 2022 at 3:03 PM Robin Murphy wrote: > > On 2022-03-07 12:47, Gilad Ben-Yossef wrote: > > On Mon, Mar 7, 2022 at 2:36 PM Robin Murphy wrote: > >> > >> On 2022-03-07 12:17, Gilad Ben-Yossef wrote: > >>> On Mon, Mar 7, 2022 at 1:14 PM Robin Murphy wrote: > >>> > The "overlap" is

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Gilad Ben-Yossef
On Mon, Mar 7, 2022 at 12:48 PM Corentin Labbe wrote: > > Hello > > I still get the warning: > [ 433.406230] [ cut here ] > [ 433.406326] DMA-API: ccree e6601000.crypto: cacheline tracking EEXIST, > overlapping mappings aren't supported > [ 433.406386] WARNING: CPU: 7

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Gilad Ben-Yossef
On Mon, Mar 7, 2022 at 2:36 PM Robin Murphy wrote: > > On 2022-03-07 12:17, Gilad Ben-Yossef wrote: > > On Mon, Mar 7, 2022 at 1:14 PM Robin Murphy wrote: > > > >> The "overlap" is in the sense of having more than one mapping within the > >> same cacheline: > >> > >> [ 142.458120] DMA-API: add_d

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Gilad Ben-Yossef
On Mon, Mar 7, 2022 at 12:48 PM Corentin Labbe wrote: > > Hello > > I still get the warning: > [ 433.406230] [ cut here ] > [ 433.406326] DMA-API: ccree e6601000.crypto: cacheline tracking EEXIST, > overlapping mappings aren't supported > [ 433.406386] WARNING: CPU: 7

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Gilad Ben-Yossef
On Mon, Mar 7, 2022 at 1:14 PM Robin Murphy wrote: > The "overlap" is in the sense of having more than one mapping within the > same cacheline: > > [ 142.458120] DMA-API: add_dma_entry start P=ba79f200 N=ba79f > D=ba79f200 L=10 DMA_FROM_DEVICE attrs=0 > [ 142.458156] DMA-API: add_dma_entry star

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Gilad Ben-Yossef
Hi Corentin, A bug in the DMA API it is not. What is the call site that calls into the crypto driver in your case? Is it the drbg like in the cryptocell case or something else? Thanks, Gilad On Mon, Mar 7, 2022 at 1:49 PM Corentin Labbe wrote: > > Le Mon, Mar 07, 2022 at 11:14:16AM +, Robi

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Corentin Labbe
Le Mon, Mar 07, 2022 at 04:00:44PM +0200, Gilad Ben-Yossef a écrit : > On Mon, Mar 7, 2022 at 3:56 PM Corentin Labbe > wrote: > > > > Le Mon, Mar 07, 2022 at 03:53:02PM +0200, Gilad Ben-Yossef a écrit : > > > On Mon, Mar 7, 2022 at 3:45 PM Corentin Labbe > > > wrote: > > > > > > > > Le Mon, Mar

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Corentin Labbe
Le Mon, Mar 07, 2022 at 03:53:02PM +0200, Gilad Ben-Yossef a écrit : > On Mon, Mar 7, 2022 at 3:45 PM Corentin Labbe > wrote: > > > > Le Mon, Mar 07, 2022 at 11:14:16AM +, Robin Murphy a écrit : > > > On 2022-03-07 10:48, Corentin Labbe wrote: > > > > Le Mon, Mar 07, 2022 at 09:59:29AM +0200,

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Corentin Labbe
Le Mon, Mar 07, 2022 at 01:59:00PM +0200, Gilad Ben-Yossef a écrit : > Hi Corentin, > > A bug in the DMA API it is not. > > What is the call site that calls into the crypto driver in your case? > Is it the drbg like in the cryptocell case or something else? > In my case, it is a user call from

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Corentin Labbe
Le Mon, Mar 07, 2022 at 11:14:16AM +, Robin Murphy a écrit : > On 2022-03-07 10:48, Corentin Labbe wrote: > > Le Mon, Mar 07, 2022 at 09:59:29AM +0200, Gilad Ben-Yossef a �crit : > >> On Sun, Mar 6, 2022 at 11:49 PM Herbert Xu > >> wrote: > >>> > >>> On Fri, Mar 04, 2022 at 02:30:06PM +0100

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Robin Murphy
On 2022-03-07 13:03, Robin Murphy wrote: On 2022-03-07 12:47, Gilad Ben-Yossef wrote: On Mon, Mar 7, 2022 at 2:36 PM Robin Murphy wrote: On 2022-03-07 12:17, Gilad Ben-Yossef wrote: On Mon, Mar 7, 2022 at 1:14 PM Robin Murphy wrote: The "overlap" is in the sense of having more than one ma

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Robin Murphy
On 2022-03-07 12:47, Gilad Ben-Yossef wrote: On Mon, Mar 7, 2022 at 2:36 PM Robin Murphy wrote: On 2022-03-07 12:17, Gilad Ben-Yossef wrote: On Mon, Mar 7, 2022 at 1:14 PM Robin Murphy wrote: The "overlap" is in the sense of having more than one mapping within the same cacheline: [ 142.4

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Robin Murphy
On 2022-03-07 12:17, Gilad Ben-Yossef wrote: On Mon, Mar 7, 2022 at 1:14 PM Robin Murphy wrote: The "overlap" is in the sense of having more than one mapping within the same cacheline: [ 142.458120] DMA-API: add_dma_entry start P=ba79f200 N=ba79f D=ba79f200 L=10 DMA_FROM_DEVICE attrs=0 [ 14

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Corentin Labbe
Le Mon, Mar 07, 2022 at 11:14:16AM +, Robin Murphy a écrit : > On 2022-03-07 10:48, Corentin Labbe wrote: > > Le Mon, Mar 07, 2022 at 09:59:29AM +0200, Gilad Ben-Yossef a �crit : > >> On Sun, Mar 6, 2022 at 11:49 PM Herbert Xu > >> wrote: > >>> > >>> On Fri, Mar 04, 2022 at 02:30:06PM +0100

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Robin Murphy
On 2022-03-07 10:48, Corentin Labbe wrote: Le Mon, Mar 07, 2022 at 09:59:29AM +0200, Gilad Ben-Yossef a �crit : On Sun, Mar 6, 2022 at 11:49 PM Herbert Xu wrote: On Fri, Mar 04, 2022 at 02:30:06PM +0100, Corentin Labbe wrote: Hello I got: [ 17.563793] [ cut here ]--

Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0

2022-03-07 Thread Corentin Labbe
Le Mon, Mar 07, 2022 at 09:59:29AM +0200, Gilad Ben-Yossef a écrit : > On Sun, Mar 6, 2022 at 11:49 PM Herbert Xu > wrote: > > > > On Fri, Mar 04, 2022 at 02:30:06PM +0100, Corentin Labbe wrote: > > > > > > Hello > > > > > > I got: > > > [ 17.563793] [ cut here ] > > > [