Re: [PATCH] iommu/io-pgtable-arm: hide unused ipmmu_iotlb_sync

2017-10-11 Thread Arnd Bergmann
On Wed, Oct 11, 2017 at 4:16 PM, Robin Murphy wrote: > On 11/10/17 14:59, Arnd Bergmann wrote: > > That said, I think the third option is now viable as well, namely to > shuffle some lines and get rid of the almost-duplicated ops entirely. > I'll have a quick go at that shortly. Ok, thanks!

Re: [PATCH] iommu/io-pgtable-arm: hide unused ipmmu_iotlb_sync

2017-10-11 Thread Robin Murphy
On 11/10/17 14:59, Arnd Bergmann wrote: > There are two sets of iommu_ops in this driver, and only > one of them contains a reference to the ipmmu_iotlb_sync > function. This leads to a compiler warning when these > operations are not in use: > > drivers/iommu/ipmmu-vmsa.c:622:13: error: 'ipmmu_io

[PATCH] iommu/io-pgtable-arm: hide unused ipmmu_iotlb_sync

2017-10-11 Thread Arnd Bergmann
There are two sets of iommu_ops in this driver, and only one of them contains a reference to the ipmmu_iotlb_sync function. This leads to a compiler warning when these operations are not in use: drivers/iommu/ipmmu-vmsa.c:622:13: error: 'ipmmu_iotlb_sync' defined but not used [-Werror=unused-func