Re: [PATCH] iommu/iova: Remove stale cached32_node

2019-07-22 Thread Joerg Roedel
On Sat, Jul 20, 2019 at 07:08:48PM +0100, Chris Wilson wrote: > --- > drivers/iommu/iova.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Applied to iommu/fixes. ___ iommu mailing list iommu@lists.linux-foundation.org

Re: [PATCH] iommu/iova: Remove stale cached32_node

2019-07-22 Thread Chris Wilson
Quoting Robin Murphy (2019-07-22 11:13:49) > Hi Chris, > > On 20/07/2019 19:08, Chris Wilson wrote: > > Since the cached32_node is allowed to be advanced above dma_32bit_pfn > > (to provide a shortcut into the limited range), we need to be careful to > > remove the to be freed node if it is the

Re: [PATCH] iommu/iova: Remove stale cached32_node

2019-07-22 Thread Robin Murphy
Hi Chris, On 20/07/2019 19:08, Chris Wilson wrote: Since the cached32_node is allowed to be advanced above dma_32bit_pfn (to provide a shortcut into the limited range), we need to be careful to remove the to be freed node if it is the cached32_node. Thanks for digging in - just to confirm my

Re: [PATCH] iommu/iova: Remove stale cached32_node

2019-07-20 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: e60aa7b53845 iommu/iova: Extend rbtree node caching. The bot has tested the following trees: v5.2.1, v5.1.18, v4.19.59. v5.2.1: Build OK! v5.1.18: Build OK! v4.19.59: Failed to

[PATCH] iommu/iova: Remove stale cached32_node

2019-07-20 Thread Chris Wilson
Since the cached32_node is allowed to be advanced above dma_32bit_pfn (to provide a shortcut into the limited range), we need to be careful to remove the to be freed node if it is the cached32_node. [ 48.43] BUG: KASAN: use-after-free in __cached_rbnode_delete_update+0x68/0x110 [