Re: [PATCH] iommu/iova: avoid false sharing on fq_timer_on

2019-08-30 Thread Joerg Roedel
On Fri, Aug 30, 2019 at 01:27:25PM +0100, Robin Murphy wrote: > On 30/08/2019 11:49, Joerg Roedel wrote: > > Looks good to me, but adding Robin for his opinion. > > Sounds reasonable to me too - that should also be true for the majority of > Arm systems that we know of. Will suggested that atomic_

Re: [PATCH] iommu/iova: avoid false sharing on fq_timer_on

2019-08-30 Thread Robin Murphy
On 30/08/2019 11:49, Joerg Roedel wrote: Looks good to me, but adding Robin for his opinion. Sounds reasonable to me too - that should also be true for the majority of Arm systems that we know of. Will suggested that atomic_try_cmpxchg() might be relevant, but AFAICS that's backwards compared

Re: [PATCH] iommu/iova: avoid false sharing on fq_timer_on

2019-08-30 Thread Joerg Roedel
Looks good to me, but adding Robin for his opinion. On Wed, Aug 28, 2019 at 06:13:38AM -0700, Eric Dumazet wrote: > In commit 14bd9a607f90 ("iommu/iova: Separate atomic variables > to improve performance") Jinyu Qi identified that the atomic_cmpxchg() > in queue_iova() was causing a performance lo

[PATCH] iommu/iova: avoid false sharing on fq_timer_on

2019-08-28 Thread Eric Dumazet
In commit 14bd9a607f90 ("iommu/iova: Separate atomic variables to improve performance") Jinyu Qi identified that the atomic_cmpxchg() in queue_iova() was causing a performance loss and moved critical fields so that the false sharing would not impact them. However, avoiding the false sharing in the