[PATCH] iommu: Check for iommu_ops == NULL in iommu_probe_device()

2018-12-20 Thread Joerg Roedel
From: Joerg Roedel This check needs to be there and got lost at some point during development. Add it again. Fixes: 641fb0efbff0 ('iommu/of: Don't call iommu_ops->add_device directly') Reported-by: Marek Szyprowski Reported-by: kernelci.org bot Signed-off-by: Joerg Roedel --- drivers/iommu/i

Re: [PATCH] iommu: Check for iommu_ops == NULL in iommu_probe_device()

2019-01-16 Thread Auger Eric
Hi Joerg, On 12/20/18 10:08 AM, Joerg Roedel wrote: > From: Joerg Roedel > > This check needs to be there and got lost at some point > during development. Add it again. > > Fixes: 641fb0efbff0 ('iommu/of: Don't call iommu_ops->add_device directly') I experience a regression with those 2 patches

Re: [PATCH] iommu: Check for iommu_ops == NULL in iommu_probe_device()

2019-01-16 Thread Jean-Philippe Brucker
On 16/01/2019 15:27, Auger Eric wrote: > Hi Joerg, > > On 12/20/18 10:08 AM, Joerg Roedel wrote: >> From: Joerg Roedel >> >> This check needs to be there and got lost at some point >> during development. Add it again. >> >> Fixes: 641fb0efbff0 ('iommu/of: Don't call iommu_ops->add_device directly

Re: [PATCH] iommu: Check for iommu_ops == NULL in iommu_probe_device()

2019-01-16 Thread Joerg Roedel
On Wed, Jan 16, 2019 at 04:33:51PM +, Jean-Philippe Brucker wrote: > There is a fix on the list: > https://www.spinics.net/lists/arm-kernel/msg698371.html It is also in my tree already, I will send it upstream this week. Regards, Joerg ___

Re: [PATCH] iommu: Check for iommu_ops == NULL in iommu_probe_device()

2019-01-16 Thread Auger Eric
Hi Jean, Joerg, On 1/16/19 5:43 PM, Joerg Roedel wrote: > On Wed, Jan 16, 2019 at 04:33:51PM +, Jean-Philippe Brucker wrote: >> There is a fix on the list: >> https://www.spinics.net/lists/arm-kernel/msg698371.html > > It is also in my tree already, I will send it upstream this week. OK than