Re: [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA

2020-06-30 Thread Robin Murphy
On 2020-06-30 11:09, Joerg Roedel wrote: On Mon, Jun 29, 2020 at 05:29:36PM +0100, Robin Murphy wrote: On 2020-06-29 13:11, Geert Uytterhoeven wrote: If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config): drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap': dma-iommu.c:(.text+0x92e):

Re: [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA

2020-06-30 Thread Joerg Roedel
On Mon, Jun 29, 2020 at 05:29:36PM +0100, Robin Murphy wrote: > On 2020-06-29 13:11, Geert Uytterhoeven wrote: > > If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config): > > > > drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap': > > dma-iommu.c:(.text+0x92e): undefined reference to

Re: [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA

2020-06-29 Thread Robin Murphy
On 2020-06-29 13:11, Geert Uytterhoeven wrote: If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config): drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap': dma-iommu.c:(.text+0x92e): undefined reference to `dma_pgprot' IOMMU_DMA must not be selected, unless HAS_DMA=y. Wait, no, IOMMU_DMA

Re: [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA

2020-06-29 Thread Maxime Ripard
On Mon, Jun 29, 2020 at 02:11:46PM +0200, Geert Uytterhoeven wrote: > If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config): > > drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap': > dma-iommu.c:(.text+0x92e): undefined reference to `dma_pgprot' > > IOMMU_DMA must not be selected, unless

[PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA

2020-06-29 Thread Geert Uytterhoeven
If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config): drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap': dma-iommu.c:(.text+0x92e): undefined reference to `dma_pgprot' IOMMU_DMA must not be selected, unless HAS_DMA=y. Hence fix this by making SUN50I_IOMMU depend on HAS_DMA. Fixes: