[PATCH] iommu: fix device remove

2017-05-05 Thread Rob Clark
It looks like it *used* to make sense to free the device. But now it is embedded in 'struct iommu' (which is allocated or embedded in something that the device allocated). Spotted when testing qcom_iommu with CONFIG_DEBUG_TEST_DRIVER_REMOVE. Fixes: 39ab955 ("iommu: Add sysfs bindings for struct

Re: [PATCH] iommu: fix device remove

2017-05-05 Thread Greg KH
On Fri, May 05, 2017 at 02:08:37PM -0400, Rob Clark wrote: > It looks like it *used* to make sense to free the device. But now it is > embedded in 'struct iommu' (which is allocated or embedded in something > that the device allocated). > > Spotted when testing qcom_iommu with CONFIG_DEBUG_TEST_D

Re: [PATCH] iommu: fix device remove

2017-05-05 Thread Rob Clark
On Fri, May 5, 2017 at 2:24 PM, Greg KH wrote: > On Fri, May 05, 2017 at 02:08:37PM -0400, Rob Clark wrote: >> It looks like it *used* to make sense to free the device. But now it is >> embedded in 'struct iommu' (which is allocated or embedded in something >> that the device allocated). >> >> Sp

Re: [PATCH] iommu: fix device remove

2017-05-05 Thread Greg KH
On Fri, May 05, 2017 at 02:56:00PM -0400, Rob Clark wrote: > On Fri, May 5, 2017 at 2:24 PM, Greg KH wrote: > > On Fri, May 05, 2017 at 02:08:37PM -0400, Rob Clark wrote: > >> It looks like it *used* to make sense to free the device. But now it is > >> embedded in 'struct iommu' (which is allocat

Re: [PATCH] iommu: fix device remove

2017-05-05 Thread Rob Clark
On Fri, May 5, 2017 at 3:58 PM, Greg KH wrote: > On Fri, May 05, 2017 at 02:56:00PM -0400, Rob Clark wrote: >> On Fri, May 5, 2017 at 2:24 PM, Greg KH wrote: >> > On Fri, May 05, 2017 at 02:08:37PM -0400, Rob Clark wrote: >> >> It looks like it *used* to make sense to free the device. But now it