Re: [PATCH] kernel: dma: Make CMA boot parameters __ro_after_init

2019-10-18 Thread Shyam Saini
Hi Robin, Sorry for the late reply. > This parameters are not changed after early boot. > > By making them __ro_after_init will reduce any attack surface in the > > kernel. > > At a glance, it looks like these are only referenced by a couple of > __init functions, so couldn't they just be __init

Re: [PATCH] kernel: dma: Make CMA boot parameters __ro_after_init

2019-10-16 Thread Shyam Saini
Hi Nathan, On Mon, Oct 14, 2019 at 7:55 AM Nathan Chancellor wrote: > > On Sat, Oct 12, 2019 at 05:59:18PM +0530, Shyam Saini wrote: > > This parameters are not changed after early boot. > > By making them __ro_after_init will reduce any attack surface in the > > kernel. > > > > Link: https://lwn

Re: [PATCH] kernel: dma: Make CMA boot parameters __ro_after_init

2019-10-14 Thread Robin Murphy
On 12/10/2019 13:29, Shyam Saini wrote: This parameters are not changed after early boot. By making them __ro_after_init will reduce any attack surface in the kernel. At a glance, it looks like these are only referenced by a couple of __init functions, so couldn't they just be __initdata/__ini

Re: [PATCH] kernel: dma: Make CMA boot parameters __ro_after_init

2019-10-13 Thread Nathan Chancellor
On Sat, Oct 12, 2019 at 05:59:18PM +0530, Shyam Saini wrote: > This parameters are not changed after early boot. > By making them __ro_after_init will reduce any attack surface in the > kernel. > > Link: https://lwn.net/Articles/676145/ > Cc: Christoph Hellwig > Cc: Marek Szyprowski > Cc: Robin

[PATCH] kernel: dma: Make CMA boot parameters __ro_after_init

2019-10-12 Thread Shyam Saini
This parameters are not changed after early boot. By making them __ro_after_init will reduce any attack surface in the kernel. Link: https://lwn.net/Articles/676145/ Cc: Christoph Hellwig Cc: Marek Szyprowski Cc: Robin Murphy Cc: Matthew Wilcox Cc: Christopher Lameter Cc: Kees Cook Signed-of