Re: [PATCH 03/10] iommu/ioasid: Introduce per set allocation APIs

2020-04-21 Thread Jacob Pan
Hi Jean, Sorry for the late reply, been trying to redesign the notification part. On Tue, 7 Apr 2020 13:01:07 +0200 Jean-Philippe Brucker wrote: > On Mon, Apr 06, 2020 at 01:02:45PM -0700, Jacob Pan wrote: > > > > + sdata = kzalloc(sizeof(*sdata), GFP_KERNEL); > > > > + if (!sdata)

Re: [PATCH 03/10] iommu/ioasid: Introduce per set allocation APIs

2020-04-07 Thread Jean-Philippe Brucker
On Mon, Apr 06, 2020 at 01:02:45PM -0700, Jacob Pan wrote: > > > + sdata = kzalloc(sizeof(*sdata), GFP_KERNEL); > > > + if (!sdata) > > > + return -ENOMEM; > > > > I don't understand why we need this structure at all, nor why we need > > the SID. Users have already allocated an

Re: [PATCH 03/10] iommu/ioasid: Introduce per set allocation APIs

2020-04-06 Thread Jacob Pan
On Wed, 1 Apr 2020 15:47:45 +0200 Jean-Philippe Brucker wrote: > On Wed, Mar 25, 2020 at 10:55:24AM -0700, Jacob Pan wrote: > > IOASID set defines a group of IDs that share the same token. The > > ioasid_set concept helps to do permission checking among users as > > in the current code. > > > >

Re: [PATCH 03/10] iommu/ioasid: Introduce per set allocation APIs

2020-04-01 Thread Jean-Philippe Brucker
On Wed, Mar 25, 2020 at 10:55:24AM -0700, Jacob Pan wrote: > IOASID set defines a group of IDs that share the same token. The > ioasid_set concept helps to do permission checking among users as in the > current code. > > With guest SVA usage, each VM has its own IOASID set. More > functionalities

RE: [PATCH 03/10] iommu/ioasid: Introduce per set allocation APIs

2020-03-28 Thread Tian, Kevin
> From: Jacob Pan > Sent: Saturday, March 28, 2020 12:59 AM > > On Fri, 27 Mar 2020 08:38:44 + > "Tian, Kevin" wrote: > > > > From: Jacob Pan > > > Sent: Thursday, March 26, 2020 1:55 AM > > > > > > IOASID set defines a group of IDs that share the same token. The > > > ioasid_set concept

Re: [PATCH 03/10] iommu/ioasid: Introduce per set allocation APIs

2020-03-27 Thread Jacob Pan
On Fri, 27 Mar 2020 08:38:44 + "Tian, Kevin" wrote: > > From: Jacob Pan > > Sent: Thursday, March 26, 2020 1:55 AM > > > > IOASID set defines a group of IDs that share the same token. The > > ioasid_set concept helps to do permission checking among users as > > in the current code. > > >

RE: [PATCH 03/10] iommu/ioasid: Introduce per set allocation APIs

2020-03-27 Thread Tian, Kevin
> From: Jacob Pan > Sent: Thursday, March 26, 2020 1:55 AM > > IOASID set defines a group of IDs that share the same token. The > ioasid_set concept helps to do permission checking among users as in the > current code. > > With guest SVA usage, each VM has its own IOASID set. More >

Re: [PATCH 03/10] iommu/ioasid: Introduce per set allocation APIs

2020-03-26 Thread Jacob Pan
Hi Baolu, On Thu, 26 Mar 2020 10:12:36 +0800 Lu Baolu wrote: > On 2020/3/26 1:55, Jacob Pan wrote: > > IOASID set defines a group of IDs that share the same token. The > > ioasid_set concept helps to do permission checking among users as > > in the current code. > > > > With guest SVA usage,

Re: [PATCH 03/10] iommu/ioasid: Introduce per set allocation APIs

2020-03-25 Thread Lu Baolu
On 2020/3/26 1:55, Jacob Pan wrote: IOASID set defines a group of IDs that share the same token. The ioasid_set concept helps to do permission checking among users as in the current code. With guest SVA usage, each VM has its own IOASID set. More functionalities are needed: 1. Enforce quota,

[PATCH 03/10] iommu/ioasid: Introduce per set allocation APIs

2020-03-25 Thread Jacob Pan
IOASID set defines a group of IDs that share the same token. The ioasid_set concept helps to do permission checking among users as in the current code. With guest SVA usage, each VM has its own IOASID set. More functionalities are needed: 1. Enforce quota, each guest may be assigned limited quota