Re: [PATCH 1/2] iommu/rockchip: Handle errors returned from PM framework

Am Dienstag, 7. August 2018, 10:54:05 CEST schrieb Marc Zyngier: > pm_runtime_get_if_in_use can fail: either PM has been disabled > altogether (-EINVAL), or the device hasn't been enabled yet (0). > Sadly, the Rockchip IOMMU driver tends to conflate the two things > by considering a non-zero

Re: [PATCH 1/2] iommu/rockchip: Handle errors returned from PM framework

Am Dienstag, 7. August 2018, 16:25:53 CEST schrieb Marc Zyngier: > On 07/08/18 14:15, Heiko Stuebner wrote: > > Am Dienstag, 7. August 2018, 14:31:49 CEST schrieb Marc Zyngier: > >> On 07/08/18 13:09, Heiko Stuebner wrote: > >>> Hi Marc, > >>> > >>> Am Dienstag, 7. August 2018, 10:54:05 CEST

Re: [PATCH 1/2] iommu/rockchip: Handle errors returned from PM framework

On 07/08/18 14:15, Heiko Stuebner wrote: > Am Dienstag, 7. August 2018, 14:31:49 CEST schrieb Marc Zyngier: >> On 07/08/18 13:09, Heiko Stuebner wrote: >>> Hi Marc, >>> >>> Am Dienstag, 7. August 2018, 10:54:05 CEST schrieb Marc Zyngier: pm_runtime_get_if_in_use can fail: either PM has been

Re: [PATCH 1/2] iommu/rockchip: Handle errors returned from PM framework

Am Dienstag, 7. August 2018, 14:31:49 CEST schrieb Marc Zyngier: > On 07/08/18 13:09, Heiko Stuebner wrote: > > Hi Marc, > > > > Am Dienstag, 7. August 2018, 10:54:05 CEST schrieb Marc Zyngier: > >> pm_runtime_get_if_in_use can fail: either PM has been disabled > >> altogether (-EINVAL), or the

Re: [PATCH 1/2] iommu/rockchip: Handle errors returned from PM framework

On 07/08/18 13:09, Heiko Stuebner wrote: > Hi Marc, > > Am Dienstag, 7. August 2018, 10:54:05 CEST schrieb Marc Zyngier: >> pm_runtime_get_if_in_use can fail: either PM has been disabled >> altogether (-EINVAL), or the device hasn't been enabled yet (0). >> Sadly, the Rockchip IOMMU driver tends

Re: [PATCH 1/2] iommu/rockchip: Handle errors returned from PM framework

Hi Marc, Am Dienstag, 7. August 2018, 10:54:05 CEST schrieb Marc Zyngier: > pm_runtime_get_if_in_use can fail: either PM has been disabled > altogether (-EINVAL), or the device hasn't been enabled yet (0). > Sadly, the Rockchip IOMMU driver tends to conflate the two things > by considering a

[PATCH 1/2] iommu/rockchip: Handle errors returned from PM framework

pm_runtime_get_if_in_use can fail: either PM has been disabled altogether (-EINVAL), or the device hasn't been enabled yet (0). Sadly, the Rockchip IOMMU driver tends to conflate the two things by considering a non-zero return value as successful. This has the consequence of hiding other bugs, so