Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-15 Thread Oza Oza via iommu
On Sat, May 6, 2017 at 11:00 AM, Oza Oza wrote: > On Fri, May 5, 2017 at 8:55 PM, Robin Murphy wrote: >> On 04/05/17 19:41, Oza Oza wrote: >> [...] > 5) leaves scope of adding PCI flag handling for inbound memory > by the new function.

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-05 Thread Oza Oza via iommu
On Fri, May 5, 2017 at 8:55 PM, Robin Murphy wrote: > On 04/05/17 19:41, Oza Oza wrote: > [...] 5) leaves scope of adding PCI flag handling for inbound memory by the new function. >>> >>> Which flags would ever actually matter? DMA windows aren't going to be >>> to

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-05 Thread Robin Murphy
On 04/05/17 19:41, Oza Oza wrote: [...] >>> 5) leaves scope of adding PCI flag handling for inbound memory >>> by the new function. >> >> Which flags would ever actually matter? DMA windows aren't going to be >> to config or I/O space, so the memory type can be assumed, and the >> 32/64-bit

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-04 Thread Oza Oza via iommu
On Thu, May 4, 2017 at 11:32 PM, Robin Murphy wrote: > [apologies for the silence - I've been on holiday] > > On 03/05/17 05:46, Oza Pawandeep wrote: >> current device framework and of framework integration assumes >> dma-ranges in a way where memory-mapped devices define

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-04 Thread Oza Oza via iommu
On Thu, May 4, 2017 at 11:32 PM, Robin Murphy wrote: > [apologies for the silence - I've been on holiday] > > On 03/05/17 05:46, Oza Pawandeep wrote: >> current device framework and of framework integration assumes >> dma-ranges in a way where memory-mapped devices define

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-04 Thread Robin Murphy
[apologies for the silence - I've been on holiday] On 03/05/17 05:46, Oza Pawandeep wrote: > current device framework and of framework integration assumes > dma-ranges in a way where memory-mapped devices define their > dma-ranges. (child-bus-address, parent-bus-address, length). Well, yes, that

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-03 Thread Rob Herring
On Tue, May 2, 2017 at 11:46 PM, Oza Pawandeep wrote: > current device framework and of framework integration assumes > dma-ranges in a way where memory-mapped devices define their > dma-ranges. (child-bus-address, parent-bus-address, length). > > of_dma_configure is

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-02 Thread Oza Oza via iommu
I will send v2 after removing GERRIT details from commit message. My apologies for the noise. Regards, Oza ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-02 Thread Oza Pawandeep via iommu
current device framework and of framework integration assumes dma-ranges in a way where memory-mapped devices define their dma-ranges. (child-bus-address, parent-bus-address, length). of_dma_configure is specifically written to take care of memory mapped devices. but no implementation exists for