Re: [PATCH 1/3] xtensa: remove partial support for DMA buffers in high memory

2018-09-21 Thread Max Filippov
On Thu, Sep 20, 2018 at 11:51 PM, Christoph Hellwig wrote: > On Thu, Sep 20, 2018 at 12:08:28PM -0700, Max Filippov wrote: >> I'm not familiar with the details of alloc_contig_range implementation, but >> I don't see how gfp_mask is used to limit allocation to non-high memory. >> So when alloc_con

Re: [PATCH 1/3] xtensa: remove partial support for DMA buffers in high memory

2018-09-21 Thread Michał Nazarewicz
> On Thu, Sep 20, 2018 at 12:08:28PM -0700, Max Filippov wrote: > > I'm not familiar with the details of alloc_contig_range implementation, but > > I don't see how gfp_mask is used to limit allocation to non-high memory. > > So when alloc_contig_range gets start and end PFNs in high memory > > (fro

Re: [PATCH 1/3] xtensa: remove partial support for DMA buffers in high memory

2018-09-20 Thread Max Filippov
On Thu, Sep 20, 2018 at 11:08 AM, Christoph Hellwig wrote: > On Thu, Sep 20, 2018 at 10:44:55AM -0700, Max Filippov wrote: >> Hi Christoph, >> >> On Thu, Sep 20, 2018 at 10:15 AM, Christoph Hellwig wrote: >> > This reverts commit 6137e4166004e2ec383ac05d5ca15831f4668806. >> > >> > We explicitly c

Re: [PATCH 1/3] xtensa: remove partial support for DMA buffers in high memory

2018-09-20 Thread Christoph Hellwig
On Thu, Sep 20, 2018 at 10:44:55AM -0700, Max Filippov wrote: > Hi Christoph, > > On Thu, Sep 20, 2018 at 10:15 AM, Christoph Hellwig wrote: > > This reverts commit 6137e4166004e2ec383ac05d5ca15831f4668806. > > > > We explicitly clear GFP_HIGHMEM from the allowed dma flags at the beginning > > of

Re: [PATCH 1/3] xtensa: remove partial support for DMA buffers in high memory

2018-09-20 Thread Max Filippov
Hi Christoph, On Thu, Sep 20, 2018 at 10:15 AM, Christoph Hellwig wrote: > This reverts commit 6137e4166004e2ec383ac05d5ca15831f4668806. > > We explicitly clear GFP_HIGHMEM from the allowed dma flags at the beginning > of the function (and the generic dma_alloc_attr function calling us does the >

[PATCH 1/3] xtensa: remove partial support for DMA buffers in high memory

2018-09-20 Thread Christoph Hellwig
This reverts commit 6137e4166004e2ec383ac05d5ca15831f4668806. We explicitly clear GFP_HIGHMEM from the allowed dma flags at the beginning of the function (and the generic dma_alloc_attr function calling us does the same!), so this code just adds dead wood. Signed-off-by: Christoph Hellwig --- a