Re: [PATCH 1/6] iommu/arm-smmu: add support for specifying clocks

2014-09-15 Thread Mitchel Humpherys
On Wed, Sep 10 2014 at 12:09:06 PM, Mitchel Humpherys wrote: > On Wed, Sep 10 2014 at 11:27:39 AM, Will Deacon wrote: >> On Wed, Sep 10, 2014 at 02:29:42AM +0100, Mitchel Humpherys wrote: >>> On Tue, Aug 26 2014 at 07:27:58 AM, Will Deacon wrote: >>> > On Tue, Aug 19, 2014 at 08:03:09PM +0100,

Re: [PATCH 1/6] iommu/arm-smmu: add support for specifying clocks

2014-09-10 Thread Mitchel Humpherys
On Wed, Sep 10 2014 at 11:27:39 AM, Will Deacon wrote: > On Wed, Sep 10, 2014 at 02:29:42AM +0100, Mitchel Humpherys wrote: >> On Tue, Aug 26 2014 at 07:27:58 AM, Will Deacon wrote: >> > On Tue, Aug 19, 2014 at 08:03:09PM +0100, Olav Haugan wrote: >> >> Clients of the SMMU driver are required to

Re: [PATCH 1/6] iommu/arm-smmu: add support for specifying clocks

2014-09-10 Thread Will Deacon
On Wed, Sep 10, 2014 at 02:29:42AM +0100, Mitchel Humpherys wrote: > On Tue, Aug 26 2014 at 07:27:58 AM, Will Deacon wrote: > > On Tue, Aug 19, 2014 at 08:03:09PM +0100, Olav Haugan wrote: > >> Clients of the SMMU driver are required to vote for clocks and power > >> when they know they need to us

Re: [PATCH 1/6] iommu/arm-smmu: add support for specifying clocks

2014-09-09 Thread Mitchel Humpherys
On Tue, Aug 26 2014 at 07:27:58 AM, Will Deacon wrote: > [adding Mike] > > On Tue, Aug 19, 2014 at 08:03:09PM +0100, Olav Haugan wrote: >> Hi Will, > > Hi Olav, > >> On 8/19/2014 5:58 AM, Will Deacon wrote: >> > On Wed, Aug 13, 2014 at 01:51:34AM +0100, Mitchel Humpherys wrote: >> >> On some platf

Re: [PATCH 1/6] iommu/arm-smmu: add support for specifying clocks

2014-08-26 Thread Will Deacon
[adding Mike] On Tue, Aug 19, 2014 at 08:03:09PM +0100, Olav Haugan wrote: > Hi Will, Hi Olav, > On 8/19/2014 5:58 AM, Will Deacon wrote: > > On Wed, Aug 13, 2014 at 01:51:34AM +0100, Mitchel Humpherys wrote: > >> On some platforms with tight power constraints it is polite to only > >> leave you

Re: [PATCH 1/6] iommu/arm-smmu: add support for specifying clocks

2014-08-19 Thread Mitchel Humpherys
On Tue, Aug 19 2014 at 05:58:34 AM, Will Deacon wrote: > I also assume that the clk API ignores calls to clk_enable_prepare > for a clk that's already enabled? I couldn't find that code... That's clk_prepare_enable, not clk_enable_prepare. It's in . -Mitch -- The Qualcomm Innovation Center, I

Re: [PATCH 1/6] iommu/arm-smmu: add support for specifying clocks

2014-08-19 Thread Olav Haugan
Hi Will, On 8/19/2014 5:58 AM, Will Deacon wrote: > On Wed, Aug 13, 2014 at 01:51:34AM +0100, Mitchel Humpherys wrote: >> On some platforms with tight power constraints it is polite to only >> leave your clocks on for as long as you absolutely need them. Currently >> we assume that all clocks nece

Re: [PATCH 1/6] iommu/arm-smmu: add support for specifying clocks

2014-08-19 Thread Will Deacon
On Wed, Aug 13, 2014 at 01:51:34AM +0100, Mitchel Humpherys wrote: > On some platforms with tight power constraints it is polite to only > leave your clocks on for as long as you absolutely need them. Currently > we assume that all clocks necessary for SMMU register access are always > on. > > Add

Re: [PATCH 1/6] iommu/arm-smmu: add support for specifying clocks

2014-08-13 Thread Mitchel Humpherys
Well hopefully this isn't too Nick Krouse-esque, but I have some comments on my own patch below. I sat on these for a few days but have noticed a few things after testing on another platform... On Tue, Aug 12 2014 at 05:51:34 PM, Mitchel Humpherys wrote: > On some platforms with tight power cons

[PATCH 1/6] iommu/arm-smmu: add support for specifying clocks

2014-08-12 Thread Mitchel Humpherys
On some platforms with tight power constraints it is polite to only leave your clocks on for as long as you absolutely need them. Currently we assume that all clocks necessary for SMMU register access are always on. Add some optional device tree properties to specify any clocks that are necessary