Re: [PATCH 2/2] iommu/dma: Avoid SAC address trick for PCIe devices

2020-07-22 Thread Joerg Roedel
On Tue, Jul 14, 2020 at 12:42:36PM +0100, Robin Murphy wrote: > Oh bother - yes, this could have been masking all manner of bugs. That > system will presumably also break if you managed to exhaust the 32-bit IOVA > space such that the allocator moved up to the higher range anyway, or if you >

Re: [PATCH 2/2] iommu/dma: Avoid SAC address trick for PCIe devices

2020-07-14 Thread Robin Murphy
On 2020-07-13 14:14, Joerg Roedel wrote: On Wed, Jul 08, 2020 at 12:32:42PM +0100, Robin Murphy wrote: As for the intel-iommu implementation, relegate the opportunistic attempt to allocate a SAC address to the domain of conventional PCI devices only, to avoid it increasingly causing far more

Re: [PATCH 2/2] iommu/dma: Avoid SAC address trick for PCIe devices

2020-07-13 Thread Joerg Roedel
On Wed, Jul 08, 2020 at 12:32:42PM +0100, Robin Murphy wrote: > As for the intel-iommu implementation, relegate the opportunistic > attempt to allocate a SAC address to the domain of conventional PCI > devices only, to avoid it increasingly causing far more performance > issues than possible

[PATCH 2/2] iommu/dma: Avoid SAC address trick for PCIe devices

2020-07-08 Thread Robin Murphy
As for the intel-iommu implementation, relegate the opportunistic attempt to allocate a SAC address to the domain of conventional PCI devices only, to avoid it increasingly causing far more performance issues than possible benefits on modern PCI Express systems. Signed-off-by: Robin Murphy ---