Re: [PATCH 2/5] iommu/of: Use device_iommu_mapped()

2018-12-07 Thread Joerg Roedel
On Thu, Dec 06, 2018 at 05:42:16PM +, Robin Murphy wrote: > For sure - although I am now wondering whether "mapped" is perhaps a little > ambiguous in the naming, since the answer to "can I use the API" is yes even > when the device may currently be attached to an identity/passthrough domain >

Re: [PATCH 2/5] iommu/of: Use device_iommu_mapped()

2018-12-06 Thread Robin Murphy
On 06/12/2018 15:35, Joerg Roedel wrote: Hi Robin, On Wed, Dec 05, 2018 at 05:17:54PM +, Robin Murphy wrote: FWIW, this check (and its ACPI equivalent in patch #3) is specifically asking "has .add_device() already been called?", rather than the more general "is this device managed by an

Re: [PATCH 2/5] iommu/of: Use device_iommu_mapped()

2018-12-05 Thread Robin Murphy
On 04/12/2018 17:25, Joerg Roedel wrote: From: Joerg Roedel Use Use device_iommu_mapped() to check if the device is already mapped by an IOMMU. FWIW, this check (and its ACPI equivalent in patch #3) is specifically asking "has .add_device() already been called?", rather than the more

[PATCH 2/5] iommu/of: Use device_iommu_mapped()

2018-12-04 Thread Joerg Roedel
From: Joerg Roedel Use Use device_iommu_mapped() to check if the device is already mapped by an IOMMU. Signed-off-by: Joerg Roedel --- drivers/iommu/of_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index