Re: [PATCH 2/7] iommu/arm-smmu: Calculate SMMU_CB_BASE from smmu register values

2013-09-25 Thread Will Deacon
On Tue, Sep 24, 2013 at 07:07:20PM +0100, Andreas Herrmann wrote: > On Tue, Sep 24, 2013 at 11:34:57AM -0400, Will Deacon wrote: > > On Tue, Sep 24, 2013 at 04:06:56PM +0100, Andreas Herrmann wrote: > > > Currently it is derived from smmu resource size. If the resource size > > > is wrongly specifi

Re: [PATCH 2/7] iommu/arm-smmu: Calculate SMMU_CB_BASE from smmu register values

2013-09-24 Thread Andreas Herrmann
On Tue, Sep 24, 2013 at 11:34:57AM -0400, Will Deacon wrote: > On Tue, Sep 24, 2013 at 04:06:56PM +0100, Andreas Herrmann wrote: > > Currently it is derived from smmu resource size. If the resource size > > is wrongly specified (e.g. too large) this leads to a miscalculation > > and can cause undef

Re: [PATCH 2/7] iommu/arm-smmu: Calculate SMMU_CB_BASE from smmu register values

2013-09-24 Thread Will Deacon
On Tue, Sep 24, 2013 at 04:06:56PM +0100, Andreas Herrmann wrote: > Currently it is derived from smmu resource size. If the resource size > is wrongly specified (e.g. too large) this leads to a miscalculation > and can cause undefined behaviour when context bank registers are > modified. > > Signe

[PATCH 2/7] iommu/arm-smmu: Calculate SMMU_CB_BASE from smmu register values

2013-09-24 Thread Andreas Herrmann
Currently it is derived from smmu resource size. If the resource size is wrongly specified (e.g. too large) this leads to a miscalculation and can cause undefined behaviour when context bank registers are modified. Signed-off-by: Andreas Herrmann --- drivers/iommu/arm-smmu.c |7 +-- 1 fi