Re: [PATCH 4/6] iommu/tegra: smmu: Support variable MMIO range

2013-01-21 Thread Stephen Warren
On 01/21/2013 12:36 AM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Fri, 18 Jan 2013 17:44:13 > +0100: > >>> Even the checks if "offs" is in some of register blocks could be >>> ifdef'ed out with DEBUG. "smmu->regbase" can be calculated in probe() >>> as below. I don't think that we don't need

Re: [PATCH 4/6] iommu/tegra: smmu: Support variable MMIO range

2013-01-20 Thread Hiroshi Doyu
Stephen Warren wrote @ Fri, 18 Jan 2013 17:44:13 +0100: > > Even the checks if "offs" is in some of register blocks could be > > ifdef'ed out with DEBUG. "smmu->regbase" can be calculated in probe() > > as below. I don't think that we don't need to access "mc" DT entry to > > get this address. si

Re: [PATCH 4/6] iommu/tegra: smmu: Support variable MMIO range

2013-01-18 Thread Stephen Warren
On 01/18/2013 02:05 AM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Wed, 16 Jan 2013 22:12:24 > +0100: > >> On 01/15/2013 01:17 AM, Hiroshi Doyu wrote: >>> There are 3 SMMU MMIO register blocks. They may get bigger as new >>> Tegra SoC comes. This patch enables to support variable size of those

Re: [PATCH 4/6] iommu/tegra: smmu: Support variable MMIO range

2013-01-18 Thread Hiroshi Doyu
Stephen Warren wrote @ Wed, 16 Jan 2013 22:12:24 +0100: > On 01/15/2013 01:17 AM, Hiroshi Doyu wrote: > > There are 3 SMMU MMIO register blocks. They may get bigger as new > > Tegra SoC comes. This patch enables to support variable size of those > > register blocks. > > Why would the register blo

Re: [PATCH 4/6] iommu/tegra: smmu: Support variable MMIO range

2013-01-16 Thread Stephen Warren
On 01/15/2013 01:17 AM, Hiroshi Doyu wrote: > There are 3 SMMU MMIO register blocks. They may get bigger as new > Tegra SoC comes. This patch enables to support variable size of those > register blocks. Why would the register blocks move around? In the HW, there's one single chunk of memory contai

[PATCH 4/6] iommu/tegra: smmu: Support variable MMIO range

2013-01-15 Thread Hiroshi Doyu
There are 3 SMMU MMIO register blocks. They may get bigger as new Tegra SoC comes. This patch enables to support variable size of those register blocks. Signed-off-by: Hiroshi Doyu --- drivers/iommu/tegra-smmu.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a