Re: [PATCH 5/5] iommu/arm-smmu: fix compilation issue when !CONFIG_ARM_AMBA

2014-02-13 Thread Timur Tabi
On 02/13/2014 11:04 AM, Will Deacon wrote: It's harmless to enable CONFIG_ARM_AMBA, even if you don't have any AMBA devices in your SoC, Ah, ok. It's seems obvious now, but somehow that didn't click. it just makes your binary a bit bigger because you're compiling in code that you don't need

Re: [PATCH 5/5] iommu/arm-smmu: fix compilation issue when !CONFIG_ARM_AMBA

2014-02-13 Thread Timur Tabi
On Thu, Feb 6, 2014 at 12:09 PM, Will Deacon wrote: > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 0ae4dd39197f..6fe7922ecc1d 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -2004,8 +2004,10 @@ static int __init arm_smmu_init(void) >

Re: [PATCH 5/5] iommu/arm-smmu: fix compilation issue when !CONFIG_ARM_AMBA

2014-02-13 Thread Will Deacon
On Thu, Feb 13, 2014 at 04:55:25PM +, Timur Tabi wrote: > On Thu, Feb 6, 2014 at 12:09 PM, Will Deacon wrote: > > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > > index 0ae4dd39197f..6fe7922ecc1d 100644 > > --- a/drivers/iommu/arm-smmu.c > > +++ b/drivers/iommu/arm-smmu.

[PATCH 5/5] iommu/arm-smmu: fix compilation issue when !CONFIG_ARM_AMBA

2014-02-06 Thread Will Deacon
If !CONFIG_ARM_AMBA, we shouldn't try to register ourselves with the amba_bustype. Signed-off-by: Will Deacon --- drivers/iommu/arm-smmu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 0ae4dd39197f..6fe7922ecc1d 100644 --- a/drive