Re: [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-10 Thread Yongji Xie
On Tue, Aug 10, 2021 at 11:02 AM Jason Wang wrote: > > > 在 2021/8/9 下午1:56, Yongji Xie 写道: > > On Thu, Aug 5, 2021 at 9:31 PM Jason Wang wrote: > >> > >> 在 2021/8/5 下午8:34, Yongji Xie 写道: > My main point, though, is that if you've already got something else > keeping track of the actual

Re: [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-09 Thread Jason Wang
在 2021/8/9 下午1:56, Yongji Xie 写道: On Thu, Aug 5, 2021 at 9:31 PM Jason Wang wrote: 在 2021/8/5 下午8:34, Yongji Xie 写道: My main point, though, is that if you've already got something else keeping track of the actual addresses, then the way you're using an iova_domain appears to be something you

Re: [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-08 Thread Yongji Xie
On Thu, Aug 5, 2021 at 9:31 PM Jason Wang wrote: > > > 在 2021/8/5 下午8:34, Yongji Xie 写道: > >> My main point, though, is that if you've already got something else > >> keeping track of the actual addresses, then the way you're using an > >> iova_domain appears to be something you could do with a tr

Re: [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-05 Thread Jason Wang
在 2021/8/5 下午8:34, Yongji Xie 写道: My main point, though, is that if you've already got something else keeping track of the actual addresses, then the way you're using an iova_domain appears to be something you could do with a trivial bitmap allocator. That's why I don't buy the efficiency argume

Re: [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-05 Thread Yongji Xie
On Wed, Aug 4, 2021 at 11:43 PM Robin Murphy wrote: > > On 2021-08-04 06:02, Yongji Xie wrote: > > On Tue, Aug 3, 2021 at 6:54 PM Robin Murphy wrote: > >> > >> On 2021-08-03 09:54, Yongji Xie wrote: > >>> On Tue, Aug 3, 2021 at 3:41 PM Jason Wang wrote: > > > 在 2021/7/29 下午3:34, X

Re: [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-04 Thread Robin Murphy
On 2021-08-04 06:02, Yongji Xie wrote: On Tue, Aug 3, 2021 at 6:54 PM Robin Murphy wrote: On 2021-08-03 09:54, Yongji Xie wrote: On Tue, Aug 3, 2021 at 3:41 PM Jason Wang wrote: 在 2021/7/29 下午3:34, Xie Yongji 写道: Export alloc_iova_fast() and free_iova_fast() so that some modules can use

Re: [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-03 Thread Yongji Xie
On Tue, Aug 3, 2021 at 6:54 PM Robin Murphy wrote: > > On 2021-08-03 09:54, Yongji Xie wrote: > > On Tue, Aug 3, 2021 at 3:41 PM Jason Wang wrote: > >> > >> > >> 在 2021/7/29 下午3:34, Xie Yongji 写道: > >>> Export alloc_iova_fast() and free_iova_fast() so that > >>> some modules can use it to improve

Re: [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-03 Thread Robin Murphy
On 2021-08-03 09:54, Yongji Xie wrote: On Tue, Aug 3, 2021 at 3:41 PM Jason Wang wrote: 在 2021/7/29 下午3:34, Xie Yongji 写道: Export alloc_iova_fast() and free_iova_fast() so that some modules can use it to improve iova allocation efficiency. It's better to explain why alloc_iova() is not su

Re: [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-03 Thread Yongji Xie
On Tue, Aug 3, 2021 at 3:41 PM Jason Wang wrote: > > > 在 2021/7/29 下午3:34, Xie Yongji 写道: > > Export alloc_iova_fast() and free_iova_fast() so that > > some modules can use it to improve iova allocation efficiency. > > > It's better to explain why alloc_iova() is not sufficient here. > Fine. Tha

Re: [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-03 Thread Jason Wang
在 2021/7/29 下午3:34, Xie Yongji 写道: Export alloc_iova_fast() and free_iova_fast() so that some modules can use it to improve iova allocation efficiency. It's better to explain why alloc_iova() is not sufficient here. Thanks Signed-off-by: Xie Yongji --- drivers/iommu/iova.c | 2 ++ 1

Re: [PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-08-03 Thread Jason Wang
在 2021/7/29 下午3:34, Xie Yongji 写道: Export alloc_iova_fast() and free_iova_fast() so that some modules can use it to improve iova allocation efficiency. It's better to explain which alloc_iova() is not sufficient here. Thanks Signed-off-by: Xie Yongji --- drivers/iommu/iova.c | 2 ++

[PATCH v10 01/17] iova: Export alloc_iova_fast() and free_iova_fast()

2021-07-29 Thread Xie Yongji
Export alloc_iova_fast() and free_iova_fast() so that some modules can use it to improve iova allocation efficiency. Signed-off-by: Xie Yongji --- drivers/iommu/iova.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c index b6cf5f16123b..3941ed6bb9