Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Shuah Khan
On Fri, 2012-09-28 at 20:15 +0100, David Woodhouse wrote: > On Fri, 2012-09-28 at 12:36 -0400, Linda Knippers wrote: > > I can only speak to the HP servers. We have been shipping devices > > 'for a while' that provide sensor-type data to the platform. The > > device does DMA writes to a range of

RE: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Mingarelli, Thomas
hanks, Tom -Original Message- From: David Woodhouse [mailto:dw...@infradead.org] Sent: Friday, September 28, 2012 2:15 PM To: Knippers, Linda Cc: Alex Williamson; Joerg Roedel; iommu@lists.linux-foundation.org; Khan, Shuah; Mingarelli, Thomas Subject: Re: [PATCH v2] Intel IOMMU pat

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread David Woodhouse
On Fri, 2012-09-28 at 12:36 -0400, Linda Knippers wrote: > I can only speak to the HP servers. We have been shipping devices > 'for a while' that provide sensor-type data to the platform. The > device does DMA writes to a range of memory (the RMRR) and > iLO does DMA reads of that data. > > This

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Alex Williamson
On Fri, 2012-09-28 at 19:01 +0200, Joerg Roedel wrote: > On Fri, Sep 28, 2012 at 12:36:05PM -0400, Linda Knippers wrote: > > I can only speak to the HP servers. We have been shipping devices > > 'for a while' that provide sensor-type data to the platform. The > > device does DMA writes to a range

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Joerg Roedel
On Fri, Sep 28, 2012 at 07:01:06PM +0200, Joerg Roedel wrote: > On Fri, Sep 28, 2012 at 12:36:05PM -0400, Linda Knippers wrote: > > I can only speak to the HP servers. We have been shipping devices > > 'for a while' that provide sensor-type data to the platform. The > > device does DMA writes to

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Joerg Roedel
On Fri, Sep 28, 2012 at 12:36:05PM -0400, Linda Knippers wrote: > I can only speak to the HP servers. We have been shipping devices > 'for a while' that provide sensor-type data to the platform. The > device does DMA writes to a range of memory (the RMRR) and > iLO does DMA reads of that data. A

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Linda Knippers
David Woodhouse wrote: > > HP may have been shipping such things 'for a while' but it's never > actually worked right, yes? This thread is about the patch that's > intended to *fix* that? I can only speak to the HP servers. We have been shipping devices 'for a while' that provide sensor-type dat

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Alex Williamson
On Fri, 2012-09-28 at 16:52 +0100, David Woodhouse wrote: > HP may have been shipping such things 'for a while' but it's never > actually worked right, yes? This thread is about the patch that's > intended to *fix* that? I believe it currently works in non-passthrough mode since the RMRRs stick fo

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread David Woodhouse
HP may have been shipping such things 'for a while' but it's never actually worked right, yes? This thread is about the patch that's intended to *fix* that? If they could just manage to make their firmware-owned DMA appear to be from a different PCIe device/function from the one the OS gets to

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Alex Williamson
On Fri, 2012-09-28 at 14:52 +0200, Joerg Roedel wrote: > On Fri, Sep 28, 2012 at 06:40:08AM -0600, Alex Williamson wrote: > > On Fri, 2012-09-28 at 11:43 +0200, Joerg Roedel wrote: > > > > I don't think so. The concept of RMRR is just not defined well enough > > > (like the concept of unity mappin

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Joerg Roedel
On Fri, Sep 28, 2012 at 06:40:08AM -0600, Alex Williamson wrote: > On Fri, 2012-09-28 at 11:43 +0200, Joerg Roedel wrote: > > I don't think so. The concept of RMRR is just not defined well enough > > (like the concept of unity mappings on the AMD side which is similar to > > RMRR). The definition

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Alex Williamson
On Fri, 2012-09-28 at 11:43 +0200, Joerg Roedel wrote: > On Thu, Sep 27, 2012 at 03:34:07PM -0600, Alex Williamson wrote: > > > It really seems like RMRRs are incompatible with IOMMU API use > > though. > > I don't think so. The concept of RMRR is just not defined well enough > (like the concept

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Joerg Roedel
On Fri, Sep 28, 2012 at 11:23:23AM +0100, David Woodhouse wrote: > On Fri, 2012-09-28 at 11:46 +0200, Joerg Roedel wrote: > > Even on modern hardware with modern (IOMMU aware) kernels there is still > > this small time window when the OS has enabled the IOMMU and the USB > > driver is not initializ

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread David Woodhouse
On Fri, 2012-09-28 at 11:46 +0200, Joerg Roedel wrote: > Even on modern hardware with modern (IOMMU aware) kernels there is still > this small time window when the OS has enabled the IOMMU and the USB > driver is not initialized yet. In this time window the RMRR memory > region is still necessary,

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Joerg Roedel
On Thu, Sep 27, 2012 at 10:50:05PM +0100, David Woodhouse wrote: > That would include fairly much any USB host controller. The whole RMRR > concept is completely broken and should never have been invented. The > idea that firmware-controlled DMA should continue to happen *after* the > operating sys

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-28 Thread Joerg Roedel
On Thu, Sep 27, 2012 at 03:34:07PM -0600, Alex Williamson wrote: > It really seems like RMRRs are incompatible with IOMMU API use > though. I don't think so. The concept of RMRR is just not defined well enough (like the concept of unity mappings on the AMD side which is similar to RMRR). The def

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-27 Thread Linda Knippers
iam...@redhat.com] >> Sent: Thursday, September 27, 2012 3:37 PM >> To: Mingarelli, Thomas >> Cc: iommu@lists.linux-foundation.org; Knippers, Linda; Khan, Shuah; Don >> Dutile; David Woodhouse >> Subject: Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info &g

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-27 Thread Alex Williamson
> >> -Original Message- > >> From: Alex Williamson [mailto:alex.william...@redhat.com] > >> Sent: Thursday, September 27, 2012 3:37 PM > >> To: Mingarelli, Thomas > >> Cc: iommu@lists.linux-foundation.org; Knippers, Linda; Khan, Shuah; Don > >&

RE: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-27 Thread Mingarelli, Thomas
x Williamson [mailto:alex.william...@redhat.com] >> Sent: Thursday, September 27, 2012 3:37 PM >> To: Mingarelli, Thomas >> Cc: iommu@lists.linux-foundation.org; Knippers, Linda; Khan, Shuah; Don >> Dutile; David Woodhouse >> Subject: Re: [PATCH v2] Intel IOMMU

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-27 Thread David Woodhouse
On Thu, 2012-09-27 at 15:34 -0600, Alex Williamson wrote: > It really seems like RMRRs are incompatible with IOMMU API use though. > If an RMRR is setup for a VM domain, that's bad because a) it gives the > VM direct access to that range of host memory, and b) it interferes with > the guest use of

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-27 Thread Alex Williamson
ember 27, 2012 3:37 PM > To: Mingarelli, Thomas > Cc: iommu@lists.linux-foundation.org; Knippers, Linda; Khan, Shuah; Don > Dutile; David Woodhouse > Subject: Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info > > [adding David Woodhouse] > > On Tue, 2012-09-18 at 16:49 +00

RE: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-27 Thread Mingarelli, Thomas
: Mingarelli, Thomas Cc: iommu@lists.linux-foundation.org; Knippers, Linda; Khan, Shuah; Don Dutile; David Woodhouse Subject: Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info [adding David Woodhouse] On Tue, 2012-09-18 at 16:49 +, Tom Mingarelli wrote: > When a 32bit PCI device is remo

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-27 Thread Alex Williamson
[adding David Woodhouse] On Tue, 2012-09-18 at 16:49 +, Tom Mingarelli wrote: > When a 32bit PCI device is removed from the SI Domain, the RMRR information > for this device becomes invalid and needs to be reprocessed to avoid DMA > Read errors. These errors are evidenced by the Present bit be

Re: [PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-18 Thread Don Dutile
On 09/18/2012 12:49 PM, Tom Mingarelli wrote: When a 32bit PCI device is removed from the SI Domain, the RMRR information for this device becomes invalid and needs to be reprocessed to avoid DMA Read errors. These errors are evidenced by the Present bit being cleared in the device's context entry

[PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-18 Thread Tom Mingarelli
When a 32bit PCI device is removed from the SI Domain, the RMRR information for this device becomes invalid and needs to be reprocessed to avoid DMA Read errors. These errors are evidenced by the Present bit being cleared in the device's context entry. Fixing this problem with an enhancement to pro

[PATCH v2] Intel IOMMU patch to reprocess RMRR info

2012-09-18 Thread Tom Mingarelli
When a 32bit PCI device is removed from the SI Domain, the RMRR information for this device becomes invalid and needs to be reprocessed to avoid DMA Read errors. These errors are evidenced by the Present bit being cleared in the device's context entry. Fixing this problem with an enhancement to pro