Re: [PATCH v2] dma-mapping: Move vmap address checks into dma_map_single()

2019-10-11 Thread kbuild test robot
Hi Kees, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.4-rc2 next-20191010] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the

Re: [PATCH v2] dma-mapping: Move vmap address checks into dma_map_single()

2019-10-05 Thread kbuild test robot
Hi Kees, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.4-rc1 next-20191004] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify

Re: [PATCH v2] dma-mapping: Move vmap address checks into dma_map_single()

2019-10-05 Thread Christoph Hellwig
Please split the usb and dma-mapping parts into separate patches. > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h > index 4a1c4fca475a..12dbd07f74f2 100644 > --- a/include/linux/dma-mapping.h > +++ b/include/linux/dma-mapping.h > @@ -583,6 +583,13 @@ static inline

Re: [PATCH v2] dma-mapping: Move vmap address checks into dma_map_single()

2019-10-05 Thread Greg Kroah-Hartman
On Fri, Oct 04, 2019 at 02:28:16PM -0700, Kees Cook wrote: > As we've seen from USB and other areas, we need to always do runtime > checks for DMA operating on memory regions that might be remapped. This > moves the existing checks from USB into dma_map_single(), but leaves > the slightly heavier

Re: [PATCH v2] dma-mapping: Move vmap address checks into dma_map_single()

2019-10-04 Thread Florian Fainelli
On 10/4/19 2:28 PM, Kees Cook wrote: > As we've seen from USB and other areas, we need to always do runtime > checks for DMA operating on memory regions that might be remapped. This > moves the existing checks from USB into dma_map_single(), but leaves > the slightly heavier checks as they are. >

[PATCH v2] dma-mapping: Move vmap address checks into dma_map_single()

2019-10-04 Thread Kees Cook
As we've seen from USB and other areas, we need to always do runtime checks for DMA operating on memory regions that might be remapped. This moves the existing checks from USB into dma_map_single(), but leaves the slightly heavier checks as they are. Suggested-by: Laura Abbott Signed-off-by: