Re: [PATCH v2] iommu/dma: Map scatterlists more parsimoniously

2015-12-29 Thread Yong Wu
On Fri, 2015-11-20 at 10:57 +, Robin Murphy wrote: > Whilst blindly assuming the worst case for segment boundaries and > aligning every segment individually is safe from the point of view > of respecting the device's parameters, it is also undeniably a waste > of IOVA space. Futhermore, the

Re: [PATCH v2] iommu/dma: Map scatterlists more parsimoniously

2015-11-27 Thread Robin Murphy
On 27/11/15 15:16, Joerg Roedel wrote: On Thu, Nov 26, 2015 at 05:36:20PM +, Robin Murphy wrote: On 26/11/15 15:37, Joerg Roedel wrote: When the size is bigger than the mask you can either put a WARN on into and return error (to see if that really happens), or just do multiple smaller

Re: [PATCH v2] iommu/dma: Map scatterlists more parsimoniously

2015-11-26 Thread Joerg Roedel
On Fri, Nov 20, 2015 at 10:57:40AM +, Robin Murphy wrote: > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c > index 3a20db4..427fdc1 100644 > --- a/drivers/iommu/dma-iommu.c > +++ b/drivers/iommu/dma-iommu.c > @@ -441,6 +441,7 @@ int iommu_dma_map_sg(struct device *dev,

Re: [PATCH v2] iommu/dma: Map scatterlists more parsimoniously

2015-11-26 Thread Robin Murphy
On 26/11/15 15:37, Joerg Roedel wrote: On Fri, Nov 20, 2015 at 10:57:40AM +, Robin Murphy wrote: diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 3a20db4..427fdc1 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -441,6 +441,7 @@ int

[PATCH v2] iommu/dma: Map scatterlists more parsimoniously

2015-11-20 Thread Robin Murphy
Whilst blindly assuming the worst case for segment boundaries and aligning every segment individually is safe from the point of view of respecting the device's parameters, it is also undeniably a waste of IOVA space. Futhermore, the knock-on effects of more pages than necessary being exposed to