Re: [PATCH v2 07/11] memory: mtk-smi: Add smi sub common support

2021-07-21 Thread Yong Wu
Hi Ikjoon, Thanks very much for your help reviewing.. On Wed, 2021-07-21 at 19:43 +0800, Ikjoon Jang wrote: > On Thu, Jul 15, 2021 at 8:25 PM Yong Wu wrote: > > > > In mt8195, there are some larbs connect with the smi-sub-common, then > > connect with smi-common. > > Not critical but I suggest

Re: [PATCH v2 07/11] memory: mtk-smi: Add smi sub common support

2021-07-21 Thread Ikjoon Jang
On Thu, Jul 15, 2021 at 8:25 PM Yong Wu wrote: > > In mt8195, there are some larbs connect with the smi-sub-common, then > connect with smi-common. Not critical but I suggest to describe what is smi-sub-common. e.g. "some larbs are not directly connected to smi-common, they are connected to smi-s

[PATCH v2 07/11] memory: mtk-smi: Add smi sub common support

2021-07-15 Thread Yong Wu
In mt8195, there are some larbs connect with the smi-sub-common, then connect with smi-common. Before we create device link between smi-larb with smi-common. If we have sub-common, we should use device link the smi-larb and smi-sub-common, then use device link between the smi-sub-common with smi-c