1. Add mt6779_data define to support mt6779 IOMMU HW init.
2. For mt6779, there are two IOMMUs, one is MM_IOMMU, the
other is VPU_IOMMU. MM_IOMMU is connected smi_larb to support
multimedia engine to access DRAM, and VPU_IOMMU is connected to
APU_bus to support VPU,MDLA,EDMA to access DRAM. MM_IOMMU and
VPU_IOMMU use the same page table to simplify design by
"mtk_iommu_get_m4u_data".
3. For smi_larb6, it doesn't use MM_IOMMU, so we can distinguish
VPU_IOMMU by it when excutes iommu_probe.
4. For mt6779 APU_IOMMU fault id is irregular, so it was treated specially.

Signed-off-by: Chao Hao <chao....@mediatek.com>
---
 drivers/iommu/mtk_iommu.c | 46 ++++++++++++++++++++++++++++++++++-----
 drivers/iommu/mtk_iommu.h |  2 ++
 2 files changed, 42 insertions(+), 6 deletions(-)

diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index ad5690350d6a..7829d1fd08dd 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -43,7 +43,10 @@
 #define F_INVLD_EN1                            BIT(1)
 
 #define REG_MMU_MISC_CTRL                      0x048
+#define REG_MMU_STANDARD_AXI_MODE_MT6779       (BIT(3) | BIT(19))
+
 #define REG_MMU_DCM_DIS                                0x050
+
 #define REG_MMU_WR_LEN                         0x054
 #define F_MMU_WR_THROT_DIS                     (BIT(5) |  BIT(21))
 
@@ -95,8 +98,10 @@
 #define F_MMU_INT_ID_SUB_COMM_ID(a)            (((a) >> 7) & 0x3)
 #define F_MMU_INT_ID_LARB_ID(a)                        (((a) >> 7) & 0x7)
 #define F_MMU_INT_ID_PORT_ID(a)                        (((a) >> 2) & 0x1f)
+#define F_MMU_INT_ID_COMM_APU_ID(a)            ((a) & 0x3)
+#define F_MMU_INT_ID_SUB_APU_ID(a)             (((a) >> 2) & 0x3)
 
-#define MTK_PROTECT_PA_ALIGN                   128
+#define MTK_PROTECT_PA_ALIGN                   256
 
 /*
  * Get the local arbiter ID and the portid within the larb arbiter
@@ -249,8 +254,15 @@ static irqreturn_t mtk_iommu_isr(int irq, void *dev_id)
        write = fault_iova & F_MMU_FAULT_VA_WRITE_BIT;
        fault_port = F_MMU_INT_ID_PORT_ID(regval);
        if (data->plat_data->has_sub_comm[data->m4u_id]) {
-               fault_larb = F_MMU_INT_ID_COMM_ID(regval);
-               sub_comm = F_MMU_INT_ID_SUB_COMM_ID(regval);
+               /* m4u1 is VPU in mt6779.*/
+               if (data->m4u_id && data->plat_data->m4u_plat == M4U_MT6779) {
+                       fault_larb = F_MMU_INT_ID_COMM_APU_ID(regval);
+                       sub_comm = F_MMU_INT_ID_SUB_APU_ID(regval);
+                       fault_port = 0; /* for mt6779 APU ID is irregular */
+               } else {
+                       fault_larb = F_MMU_INT_ID_COMM_ID(regval);
+                       sub_comm = F_MMU_INT_ID_SUB_COMM_ID(regval);
+               }
        } else {
                fault_larb = F_MMU_INT_ID_LARB_ID(regval);
        }
@@ -556,11 +568,12 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data 
*data)
                return ret;
        }
 
+       regval = readl_relaxed(data->base + REG_MMU_CTRL_REG);
        if (data->plat_data->m4u_plat == M4U_MT8173)
-               regval = F_MMU_PREFETCH_RT_REPLACE_MOD |
+               regval |= F_MMU_PREFETCH_RT_REPLACE_MOD |
                         F_MMU_TF_PROT_TO_PROGRAM_ADDR_MT8173;
        else
-               regval = F_MMU_TF_PROT_TO_PROGRAM_ADDR;
+               regval |= F_MMU_TF_PROT_TO_PROGRAM_ADDR;
        writel_relaxed(regval, data->base + REG_MMU_CTRL_REG);
 
        regval = F_L2_MULIT_HIT_EN |
@@ -604,8 +617,16 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data 
*data)
                writel_relaxed(regval, data->base + REG_MMU_WR_LEN);
        }
 
-       if (data->plat_data->reset_axi)
+       if (data->plat_data->has_misc_ctrl[data->m4u_id]) {
+               /* special settings for mmu0 (multimedia iommu) */
+               regval = readl_relaxed(data->base + REG_MMU_MISC_CTRL);
+               /* non-standard AXI mode */
+               regval &= ~REG_MMU_STANDARD_AXI_MODE_MT6779;
+               writel_relaxed(regval, data->base + REG_MMU_MISC_CTRL);
+       } else if (data->plat_data->reset_axi) {
+               /*disable standard axi when it is REG_MMU_STANDARD_AXI_MODE */
                writel_relaxed(0, data->base + REG_MMU_MISC_CTRL);
+       }
 
        if (devm_request_irq(data->dev, data->irq, mtk_iommu_isr, 0,
                             dev_name(data->dev), (void *)data)) {
@@ -806,6 +827,18 @@ static const struct mtk_iommu_plat_data mt2712_data = {
        .inv_sel_reg = REG_MMU_INV_SEL,
 };
 
+static const struct mtk_iommu_plat_data mt6779_data = {
+       .m4u_plat = M4U_MT6779,
+       .larbid_remap[0] = {0, 1, 2, 3, 5, 7, 10, 9},
+       /* vp6a, vp6b, mdla/core2, mdla/edmc*/
+       .larbid_remap[1] = {2, 0, 3, 1},
+       .has_sub_comm = {true, true},
+       .has_wr_len = true,
+       .has_misc_ctrl = {true, false},
+       .inv_sel_reg = REG_MMU_INV_SEL_MT6779,
+       .m4u1_mask =  BIT(6),
+};
+
 static const struct mtk_iommu_plat_data mt8173_data = {
        .m4u_plat     = M4U_MT8173,
        .has_4gb_mode = true,
@@ -824,6 +857,7 @@ static const struct mtk_iommu_plat_data mt8183_data = {
 
 static const struct of_device_id mtk_iommu_of_ids[] = {
        { .compatible = "mediatek,mt2712-m4u", .data = &mt2712_data},
+       { .compatible = "mediatek,mt6779-m4u", .data = &mt6779_data},
        { .compatible = "mediatek,mt8173-m4u", .data = &mt8173_data},
        { .compatible = "mediatek,mt8183-m4u", .data = &mt8183_data},
        {}
diff --git a/drivers/iommu/mtk_iommu.h b/drivers/iommu/mtk_iommu.h
index 0623f199e96f..2b207dcadd06 100644
--- a/drivers/iommu/mtk_iommu.h
+++ b/drivers/iommu/mtk_iommu.h
@@ -31,6 +31,7 @@ struct mtk_iommu_suspend_reg {
 enum mtk_iommu_plat {
        M4U_MT2701,
        M4U_MT2712,
+       M4U_MT6779,
        M4U_MT8173,
        M4U_MT8183,
 };
@@ -45,6 +46,7 @@ struct mtk_iommu_plat_data {
        bool                has_vld_pa_rng;
        bool                reset_axi;
        bool                has_wr_len;
+       bool                has_misc_ctrl[2];
        u32                 m4u1_mask;
        u32                 inv_sel_reg;
        unsigned char       larbid_remap[2][MTK_LARB_NR_MAX];
-- 
2.18.0
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to