Re: [PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file

2022-02-15 Thread Lu Baolu
On 2/15/22 5:51 PM, Andy Shevchenko wrote: On Tue, Feb 15, 2022 at 09:31:37AM +0800, Lu Baolu wrote: On 2/14/22 9:27 PM, Joerg Roedel wrote: On Mon, Feb 07, 2022 at 04:12:40PM +0200, Andy Shevchenko wrote: ... +extern const struct iommu_ops intel_iommu_ops; The intel_iommu_ops symbol is

Re: [PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file

2022-02-15 Thread Andy Shevchenko
On Tue, Feb 15, 2022 at 09:31:37AM +0800, Lu Baolu wrote: > On 2/14/22 9:27 PM, Joerg Roedel wrote: > > On Mon, Feb 07, 2022 at 04:12:40PM +0200, Andy Shevchenko wrote: ... > > > +extern const struct iommu_ops intel_iommu_ops; > > The intel_iommu_ops symbol is only used in drivers/iommu/intel, s

Re: [PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file

2022-02-14 Thread Lu Baolu
On 2/14/22 9:27 PM, Joerg Roedel wrote: On Mon, Feb 07, 2022 at 04:12:40PM +0200, Andy Shevchenko wrote: diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h index 69230fd695ea..1036c1900b5c 100644 --- a/include/linux/intel-iommu.h +++ b/include/linux/intel-iommu.h @@ -813,6 +8

Re: [PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file

2022-02-14 Thread Joerg Roedel
On Mon, Feb 07, 2022 at 04:12:40PM +0200, Andy Shevchenko wrote: > diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h > index 69230fd695ea..1036c1900b5c 100644 > --- a/include/linux/intel-iommu.h > +++ b/include/linux/intel-iommu.h > @@ -813,6 +813,8 @@ bool context_present(stru

Re: [PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file

2022-02-09 Thread Andy Shevchenko
On Mon, Feb 07, 2022 at 04:12:40PM +0200, Andy Shevchenko wrote: > Compiler is not happy about hidden declaration of intel_iommu_ops. > > .../iommu.c:414:24: warning: symbol 'intel_iommu_ops' was not declared. > Should it be static? > > Move declaration to header file to make compiler happy. No

[PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file

2022-02-07 Thread Andy Shevchenko
Compiler is not happy about hidden declaration of intel_iommu_ops. .../iommu.c:414:24: warning: symbol 'intel_iommu_ops' was not declared. Should it be static? Move declaration to header file to make compiler happy. Signed-off-by: Andy Shevchenko --- v2: made sure it compiles with IRQ_REMAP=y,