Re: [PATCH v2 10/11] iommu/iova: Move flush queue code to iommu-dma

2021-12-14 Thread Robin Murphy
On 2021-12-14 17:18, John Garry via iommu wrote: On 10/12/2021 17:54, Robin Murphy wrote: +    iovad->fq_domain = fq_domain; +    iovad->fq = queue; + +    timer_setup(>fq_timer, fq_flush_timeout, 0); +    atomic_set(>fq_timer_on, 0); + +    return 0; +} + + nit: a single blank line is

Re: [PATCH v2 10/11] iommu/iova: Move flush queue code to iommu-dma

2021-12-14 Thread John Garry via iommu
On 10/12/2021 17:54, Robin Murphy wrote: + iovad->fq_domain = fq_domain; + iovad->fq = queue; + + timer_setup(>fq_timer, fq_flush_timeout, 0); + atomic_set(>fq_timer_on, 0); + + return 0; +} + + nit: a single blank line is standard, I think Cheers static

Re: [PATCH v2 10/11] iommu/iova: Move flush queue code to iommu-dma

2021-12-14 Thread John Garry via iommu
On 10/12/2021 17:54, Robin Murphy wrote: Flush queues are specific to DMA ops, which are now handled exclusively by iommu-dma. As such, now that the historical artefacts from being shared directly with drivers have been cleaned up, move the flush queue code into iommu-dma itself to get it out of

[PATCH v2 10/11] iommu/iova: Move flush queue code to iommu-dma

2021-12-10 Thread Robin Murphy
Flush queues are specific to DMA ops, which are now handled exclusively by iommu-dma. As such, now that the historical artefacts from being shared directly with drivers have been cleaned up, move the flush queue code into iommu-dma itself to get it out of the way of other IOVA users. This is pure