Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-09 Thread Maxim Levitsky
On Thu, 2021-12-09 at 15:45 +, Sean Christopherson wrote: > On Thu, Dec 09, 2021, Maxim Levitsky wrote: > > On Thu, 2021-12-09 at 15:29 +0100, Paolo Bonzini wrote: > > > On 12/9/21 01:02, Sean Christopherson wrote: > > > > RDX, a.k.a. ir_data is NULL. This check in svm_ir_list_add() > > > >

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-09 Thread Sean Christopherson via iommu
On Thu, Dec 09, 2021, Maxim Levitsky wrote: > On Thu, 2021-12-09 at 15:29 +0100, Paolo Bonzini wrote: > > On 12/9/21 01:02, Sean Christopherson wrote: > > > RDX, a.k.a. ir_data is NULL. This check in svm_ir_list_add() > > > > > > if (pi->ir_data && (pi->prev_ga_tag != 0)) { > > > > > >

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-09 Thread Maxim Levitsky
On Thu, 2021-12-09 at 15:29 +0100, Paolo Bonzini wrote: > On 12/9/21 01:02, Sean Christopherson wrote: > > RDX, a.k.a. ir_data is NULL. This check in svm_ir_list_add() > > > > if (pi->ir_data && (pi->prev_ga_tag != 0)) { > > > > implies pi->ir_data can be NULL, but neither > >

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-09 Thread Paolo Bonzini
On 12/9/21 01:02, Sean Christopherson wrote: RDX, a.k.a. ir_data is NULL. This check in svm_ir_list_add() if (pi->ir_data && (pi->prev_ga_tag != 0)) { implies pi->ir_data can be NULL, but neither avic_update_iommu_vcpu_affinity() nor amd_iommu_update_ga() check ir->data for NULL.

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Maxim Levitsky
On Thu, 2021-12-09 at 00:04 +, Sean Christopherson wrote: > On Thu, Dec 09, 2021, Maxim Levitsky wrote: > > Host crash while running 32 bit VM and another 32 bit VM nested in it: > > > > [ 751.182290] BUG: kernel NULL pointer dereference, address: > > 0025 > > [ 751.198234]

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Maxim Levitsky
On Wed, 2021-12-08 at 23:43 +, Sean Christopherson wrote: > On Thu, Dec 09, 2021, Maxim Levitsky wrote: > > > KVM: SVM: Remove unnecessary APICv/AVIC update in vCPU unblocking path > > ... > > > Probably just luck (can't reproduce this anymore) but > > while running some kvm unit tests

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Maxim Levitsky
On Thu, 2021-12-09 at 01:37 +, Sean Christopherson wrote: > On Thu, Dec 09, 2021, Maxim Levitsky wrote: > > On Thu, 2021-12-09 at 01:00 +0200, Maxim Levitsky wrote: > > > Probably just luck (can't reproduce this anymore) but > > > while running some kvm unit tests with this patch series (and

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Sean Christopherson via iommu
On Thu, Dec 09, 2021, Maxim Levitsky wrote: > On Thu, 2021-12-09 at 01:00 +0200, Maxim Levitsky wrote: > > Probably just luck (can't reproduce this anymore) but > > while running some kvm unit tests with this patch series (and few my patches > > for AVIC co-existance which shouldn't affect this) I

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Sean Christopherson via iommu
On Thu, Dec 09, 2021, Maxim Levitsky wrote: > Host crash while running 32 bit VM and another 32 bit VM nested in it: > > [ 751.182290] BUG: kernel NULL pointer dereference, address: 0025 > [ 751.198234] #PF: supervisor read access in kernel mode > [ 751.209982] #PF:

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Sean Christopherson via iommu
On Thu, Dec 09, 2021, Maxim Levitsky wrote: > Also got this while trying a VM with passed through device: > > [mlevitsk@amdlaptop ~]$[ 34.926140] usb 5-3: reset full-speed USB device > number 3 using xhci_hcd > [ 42.583661] FAT-fs (mmcblk0p1): Volume was not properly unmounted. Some > data

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Sean Christopherson via iommu
On Thu, Dec 09, 2021, Maxim Levitsky wrote: > > KVM: SVM: Remove unnecessary APICv/AVIC update in vCPU unblocking path ... > Probably just luck (can't reproduce this anymore) but > while running some kvm unit tests with this patch series (and few my patches > for AVIC co-existance which

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Maxim Levitsky
On Thu, 2021-12-09 at 01:16 +0200, Maxim Levitsky wrote: > On Thu, 2021-12-09 at 01:00 +0200, Maxim Levitsky wrote: > > On Wed, 2021-12-08 at 01:52 +, Sean Christopherson wrote: > > > Overhaul and cleanup APIC virtualization (Posted Interrupts on Intel VMX, > > > AVIC on AMD SVM) to streamline

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Maxim Levitsky
On Thu, 2021-12-09 at 01:00 +0200, Maxim Levitsky wrote: > On Wed, 2021-12-08 at 01:52 +, Sean Christopherson wrote: > > Overhaul and cleanup APIC virtualization (Posted Interrupts on Intel VMX, > > AVIC on AMD SVM) to streamline things as much as possible, remove a bunch > > of cruft, and

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Maxim Levitsky
On Wed, 2021-12-08 at 01:52 +, Sean Christopherson wrote: > Overhaul and cleanup APIC virtualization (Posted Interrupts on Intel VMX, > AVIC on AMD SVM) to streamline things as much as possible, remove a bunch > of cruft, and document the lurking gotchas along the way. > > Patch 01 is a fix

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Paolo Bonzini
On 12/8/21 02:52, Sean Christopherson wrote: Overhaul and cleanup APIC virtualization (Posted Interrupts on Intel VMX, AVIC on AMD SVM) to streamline things as much as possible, remove a bunch of cruft, and document the lurking gotchas along the way. Patch 01 is a fix from Paolo that's already

Re: [PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-08 Thread Paolo Bonzini
On 12/8/21 02:52, Sean Christopherson wrote: Overhaul and cleanup APIC virtualization (Posted Interrupts on Intel VMX, AVIC on AMD SVM) to streamline things as much as possible, remove a bunch of cruft, and document the lurking gotchas along the way. Patch 01 is a fix from Paolo that's already

[PATCH v3 00/26] KVM: x86: Halt and APICv overhaul

2021-12-07 Thread Sean Christopherson via iommu
Overhaul and cleanup APIC virtualization (Posted Interrupts on Intel VMX, AVIC on AMD SVM) to streamline things as much as possible, remove a bunch of cruft, and document the lurking gotchas along the way. Patch 01 is a fix from Paolo that's already been merged but hasn't made its way to