Re: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level

2019-12-16 Thread Lu Baolu
Hi, On 2019/12/17 10:36, Liu, Yi L wrote: From: Liu, Yi L Sent: Tuesday, December 17, 2019 10:26 AM To: Lu Baolu ; Joerg Roedel ; David Woodhouse ; Alex Williamson Subject: RE: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level From: Lu Baolu [mailto:baolu

RE: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level

2019-12-16 Thread Liu, Yi L
> From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Tuesday, December 17, 2019 9:39 AM > To: Liu, Yi L ; Joerg Roedel ; David > Woodhouse ; Alex Williamson > > Subject: Re: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over > first > level > >

RE: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level

2019-12-16 Thread Liu, Yi L
> From: Liu, Yi L > Sent: Tuesday, December 17, 2019 10:26 AM > To: Lu Baolu ; Joerg Roedel ; David > Woodhouse ; Alex Williamson > > Subject: RE: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over > first > level > > > From: Lu Baolu [mailto:b

RE: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level

2019-12-16 Thread Liu, Yi L
> From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Tuesday, December 17, 2019 9:37 AM > To: Liu, Yi L ; Joerg Roedel ; David > Woodhouse ; Alex Williamson > > Subject: Re: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over > first > level > >

Re: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level

2019-12-16 Thread Lu Baolu
Hi, On 12/17/19 9:37 AM, Lu Baolu wrote: You are right. I will change it accordingly. The logic should look like: if (domain attached to physical device) flush_piotlb_with_RID2PASID() else if (domain_attached_to_mdev_device) flush_piotlb_with_default_pasid() Both! so no "else" here

Re: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level

2019-12-16 Thread Lu Baolu
Hi again, On 12/17/19 9:19 AM, Lu Baolu wrote: Hi Yi, On 12/15/19 5:22 PM, Liu, Yi L wrote: Ok, let me explain more... default pasid is meaningful only when the domain has been attached to a device as an aux-domain. right? No exactly. Each domain has a specific default pasid, no matter norma

Re: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level

2019-12-16 Thread Lu Baolu
Hi Yi, On 12/15/19 5:22 PM, Liu, Yi L wrote: Ok, let me explain more... default pasid is meaningful only when the domain has been attached to a device as an aux-domain. right? No exactly. Each domain has a specific default pasid, no matter normal domain (RID based) or aux-domain (PASID based).

RE: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level

2019-12-15 Thread Liu, Yi L
Hi Baolu, Please check replies below: > From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Saturday, December 14, 2019 11:24 AM > To: Liu, Yi L ; Joerg Roedel ; David > Woodhouse ; Alex Williamson > > Subject: Re: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for

Re: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level

2019-12-13 Thread Lu Baolu
Hi Liu Yi, On 12/13/19 7:42 PM, Liu, Yi L wrote: From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf Of Lu Baolu Sent: Wednesday, December 11, 2019 10:12 AM To: Joerg Roedel ; David Woodhouse ; Subject: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over

RE: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level

2019-12-13 Thread Liu, Yi L
Hi Allen, > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf > Of Lu Baolu > Sent: Wednesday, December 11, 2019 10:12 AM > To: Joerg Roedel ; David Woodhouse ; > Subject: [PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over > first level

[PATCH v3 5/6] iommu/vt-d: Flush PASID-based iotlb for iova over first level

2019-12-10 Thread Lu Baolu
When software has changed first-level tables, it should invalidate the affected IOTLB and the paging-structure-caches using the PASID- based-IOTLB Invalidate Descriptor defined in spec 6.5.2.4. Signed-off-by: Lu Baolu --- drivers/iommu/dmar.c| 41 ++ drive