Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API

2021-03-19 Thread Ricardo Ribalda
Hi Christoph On Fri, Mar 19, 2021 at 2:10 PM Christoph Hellwig wrote: > > On Fri, Mar 19, 2021 at 02:05:21PM +0100, Ricardo Ribalda wrote: > > > + uvc_urb->sgt, > > > + uvc_stream_dir(uvc_urb->stream)); > > > + return

Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API

2021-03-19 Thread Christoph Hellwig
On Fri, Mar 19, 2021 at 02:05:21PM +0100, Ricardo Ribalda wrote: > > + uvc_urb->sgt, > > + uvc_stream_dir(uvc_urb->stream)); > > + return usb_submit_urb(uvc_urb->urb, GFP_KERNEL); > > +} > > We should have mem_flags instead

Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API

2021-03-19 Thread Ricardo Ribalda
Hi Christoph While backporting the patch I realised of a bug. On Sat, Mar 13, 2021 at 12:55 AM Ricardo Ribalda wrote: > > On architectures where there is no coherent caching such as ARM use the > dma_alloc_noncontiguous API and handle manually the cache flushing using > dma_sync_sgtable(). > >

Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API

2021-03-15 Thread Christoph Hellwig
Thanks, with all the reviews in I've applied the series to the dma-mapping tree for 5.13. This will eventually become a stable baseline branch for the v4l work and the mips drm driver that needs dma_mmap_pages, but I'd like to wait a bit for any issues to pop up in linux-next first.

Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API

2021-03-15 Thread Ricardo Ribalda
On Mon, Mar 15, 2021 at 8:34 AM Christoph Hellwig wrote: > > On Mon, Mar 15, 2021 at 08:30:57AM +0100, Ricardo Ribalda wrote: > > Hi Christoph > > > > I guess you can merge this patch from your tree. I hope it is not too > > late in this release cycle. > > The timing is perfectly fine, I haven't

Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API

2021-03-15 Thread Christoph Hellwig
On Mon, Mar 15, 2021 at 08:30:57AM +0100, Ricardo Ribalda wrote: > Hi Christoph > > I guess you can merge this patch from your tree. I hope it is not too > late in this release cycle. The timing is perfectly fine, I haven't even started the dma-mapping tree for v5.13 yet.

Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API

2021-03-15 Thread Ricardo Ribalda
Hi Christoph I guess you can merge this patch from your tree. I hope it is not too late in this release cycle. Have a great week! On Sat, Mar 13, 2021 at 12:55 AM Ricardo Ribalda wrote: > > On architectures where there is no coherent caching such as ARM use the > dma_alloc_noncontiguous API

[PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API

2021-03-12 Thread Ricardo Ribalda
On architectures where there is no coherent caching such as ARM use the dma_alloc_noncontiguous API and handle manually the cache flushing using dma_sync_sgtable(). If the architechture has coherent cache, the API falls back to alloc_dma_pages, so we can remove the coherent caching code-path from