Re: [PATCH v5 3/7] iommu/vt-d: Introduce is_downstream_to_pci_bridge helper

2019-05-29 Thread Auger Eric
Hi Christoph, On 5/29/19 8:21 AM, Christoph Hellwig wrote: >> +/* is_downstream_to_pci_bridge - test if a device belongs to the >> + * PCI sub-hierarchy of a candidate PCI-PCI bridge >> + * >> + * @dev: candidate PCI device belonging to @bridge PCI sub-hierarchy >> + * @bridge: the candidate

Re: [PATCH v5 3/7] iommu/vt-d: Introduce is_downstream_to_pci_bridge helper

2019-05-29 Thread Christoph Hellwig
> +/* is_downstream_to_pci_bridge - test if a device belongs to the > + * PCI sub-hierarchy of a candidate PCI-PCI bridge > + * > + * @dev: candidate PCI device belonging to @bridge PCI sub-hierarchy > + * @bridge: the candidate PCI-PCI bridge > + * > + * Return: true if @dev belongs to @bridge

Re: [PATCH v5 3/7] iommu/vt-d: Introduce is_downstream_to_pci_bridge helper

2019-05-28 Thread Lu Baolu
Hi, On 5/28/19 7:50 PM, Eric Auger wrote: Several call sites are about to check whether a device belongs to the PCI sub-hierarchy of a candidate PCI-PCI bridge. Introduce an helper to perform that check. This looks good to me. Reviewed-by: Lu Baolu Best regards, Baolu Signed-off-by:

[PATCH v5 3/7] iommu/vt-d: Introduce is_downstream_to_pci_bridge helper

2019-05-28 Thread Eric Auger
Several call sites are about to check whether a device belongs to the PCI sub-hierarchy of a candidate PCI-PCI bridge. Introduce an helper to perform that check. Signed-off-by: Eric Auger --- drivers/iommu/intel-iommu.c | 37 + 1 file changed, 29