Re: [RFC] remove the ->mapping_error method from dma_map_ops

2018-11-19 Thread Christoph Hellwig
On Fri, Nov 09, 2018 at 03:12:34PM -0800, David Miller wrote: > But patch #2 on the other hand, not so much. > > I hate seeing values returned by reference, it adds cost especially > on cpus where all argments and return values fit in registers (we end > up forcing a stack slot and memory

Re: [RFC] remove the ->mapping_error method from dma_map_ops

2018-11-09 Thread David Miller
From: Christoph Hellwig Date: Fri, 9 Nov 2018 09:46:30 +0100 > Error reporting for the dma_map_single and dma_map_page operations is > currently a mess. Both APIs directly return the dma_addr_t to be used for > the DMA, with a magic error escape that is specific to the instance and > checked

[RFC] remove the ->mapping_error method from dma_map_ops

2018-11-09 Thread Christoph Hellwig
Error reporting for the dma_map_single and dma_map_page operations is currently a mess. Both APIs directly return the dma_addr_t to be used for the DMA, with a magic error escape that is specific to the instance and checked by another method provided. This has a few downsides: - the error