Hi Robin,
> From: Robin Murphy, Sent: Friday, June 14, 2019 6:41 PM
>
> On 13/06/2019 11:20, Yoshihiro Shimoda wrote:
> > This patch adds an exported function to get minimum page size for
> > a domain. This patch also modifies similar codes on the iommu.c.
>
> Heh, seeing this gave me a genuine
Hi Wolfram-san,
> From: Wolfram Sang, Sent: Friday, June 14, 2019 4:38 AM
>
> On Thu, Jun 13, 2019 at 07:20:11PM +0900, Yoshihiro Shimoda wrote:
> > This patch adds an exported function to get minimum page size for
> > a domain. This patch also modifies similar codes on the iommu.c.
> >
> >
On 13/06/2019 11:20, Yoshihiro Shimoda wrote:
This patch adds an exported function to get minimum page size for
a domain. This patch also modifies similar codes on the iommu.c.
Heh, seeing this gave me a genuine déjà vu moment...
...but it turns out I actually *have* reviewed this patch
On Thu, Jun 13, 2019 at 09:37:59PM +0200, Wolfram Sang wrote:
> What about making this a 'static inline' in the iommu header file? I'd
> think it is simple enough and would save us the EXPORT symbol.
Agreed, this seems simple enought for an inline.
On Thu, Jun 13, 2019 at 07:20:11PM +0900, Yoshihiro Shimoda wrote:
> This patch adds an exported function to get minimum page size for
> a domain. This patch also modifies similar codes on the iommu.c.
>
> Signed-off-by: Yoshihiro Shimoda
> ---
> drivers/iommu/iommu.c | 18 +++---
>
This patch adds an exported function to get minimum page size for
a domain. This patch also modifies similar codes on the iommu.c.
Signed-off-by: Yoshihiro Shimoda
---
drivers/iommu/iommu.c | 18 +++---
include/linux/iommu.h | 1 +
2 files changed, 16 insertions(+), 3 deletions(-)
