Re: [patch V2 20/29] tracing: Simplify stacktrace retrieval in histograms

2019-04-18 Thread Tom Zanussi
Hi Steve, On Thu, 2019-04-18 at 16:13 -0400, Steven Rostedt wrote: > On Thu, 18 Apr 2019 14:58:55 -0500 > Tom Zanussi wrote: > > > > Tom, > > > > > > Can you review this too? > > > > Looks good to me too! > > > > Acked-by: Tom Zanussi > > > > Would you be OK to upgrade this to a

Re: [patch V2 20/29] tracing: Simplify stacktrace retrieval in histograms

2019-04-18 Thread Tom Zanussi
On Thu, 2019-04-18 at 09:40 -0400, Steven Rostedt wrote: > [ Added Tom Zanussi ] > > On Thu, 18 Apr 2019 10:41:39 +0200 > Thomas Gleixner wrote: > > > The indirection through struct stack_trace is not necessary at all. > > Use the > > storage array based interface. > > > > Signed-off-by:

Re: [patch V2 20/29] tracing: Simplify stacktrace retrieval in histograms

2019-04-18 Thread Steven Rostedt
On Thu, 18 Apr 2019 14:58:55 -0500 Tom Zanussi wrote: > > Tom, > > > > Can you review this too? > > Looks good to me too! > > Acked-by: Tom Zanussi > Would you be OK to upgrade this to a Reviewed-by tag? Thanks! -- Steve ___ iommu mailing

Re: [patch V2 20/29] tracing: Simplify stacktrace retrieval in histograms

2019-04-18 Thread Steven Rostedt
[ Added Tom Zanussi ] On Thu, 18 Apr 2019 10:41:39 +0200 Thomas Gleixner wrote: > The indirection through struct stack_trace is not necessary at all. Use the > storage array based interface. > > Signed-off-by: Thomas Gleixner > Cc: Steven Rostedt Looks fine to me Acked-by: Steven Rostedt

[patch V2 20/29] tracing: Simplify stacktrace retrieval in histograms

2019-04-18 Thread Thomas Gleixner
The indirection through struct stack_trace is not necessary at all. Use the storage array based interface. Signed-off-by: Thomas Gleixner Cc: Steven Rostedt --- kernel/trace/trace_events_hist.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) ---