Re: PCIe oops for NULL pointer dereference during next-20170807 and next-20170815

2017-08-17 Thread Shawn Lin
On 2017/8/17 15:58, Joerg Roedel wrote: On Thu, Aug 17, 2017 at 03:02:31PM +0800, Shawn Lin wrote: So should we revert this commit or maybe we could add some checking into gic-v2m and gic-v3-its to see if the dev is iommu-capable? If not, we should create another routine to map MSI msg. Yes,

Re: PCIe oops for NULL pointer dereference during next-20170807 and next-20170815

2017-08-17 Thread Marc Zyngier
On 17/08/17 08:58, Joerg Roedel wrote: > On Thu, Aug 17, 2017 at 03:02:31PM +0800, Shawn Lin wrote: >> So should we revert this commit or maybe we could add some checking >> into gic-v2m and gic-v3-its to see if the dev is iommu-capable? If not, >> we should create another routine to map MSI msg.

Re: PCIe oops for NULL pointer dereference during next-20170807 and next-20170815

2017-08-17 Thread Joerg Roedel
On Thu, Aug 17, 2017 at 03:02:31PM +0800, Shawn Lin wrote: > So should we revert this commit or maybe we could add some checking > into gic-v2m and gic-v3-its to see if the dev is iommu-capable? If not, > we should create another routine to map MSI msg. Yes, fixing this in gic code is the right

Re: PCIe oops for NULL pointer dereference during next-20170807 and next-20170815

2017-08-17 Thread Shawn Lin
+ Marc On 2017/8/17 11:34, Shawn Lin wrote: Hi all, I see this NULL pointer dereference into linux-next these day which break PCIe for my system, but not for linux-next-20170807. Is it that commit causing this problem? 05f80300dc8bc ("iommu: Finish making iommu_group support mandatory")

PCIe oops for NULL pointer dereference during next-20170807 and next-20170815

2017-08-16 Thread Shawn Lin
Hi all, I see this NULL pointer dereference into linux-next these day which break PCIe for my system, but not for linux-next-20170807. Is it that commit causing this problem? 05f80300dc8bc ("iommu: Finish making iommu_group support mandatory") As I check the oops dump and asm code, which shows