Re: [PATCH v2 1/2] IOMMU: arm-smmu-v3: Fix broken STE.VALID check in Broadcom Vulcan

2015-12-21 Thread Will Deacon
On Sat, Dec 19, 2015 at 04:47:30AM +, Prem (Premachandra) Mallappa wrote: > Hi Will, Hello Prem, > > > > Is this workaround only needed for bypass STEs? If not, we have a problem > > when we install a stage-1 entry, because we'll clear the EATS bits as it > > stands. > > > > Yes, this _wa

RE: [PATCH v2 1/2] IOMMU: arm-smmu-v3: Fix broken STE.VALID check in Broadcom Vulcan

2015-12-18 Thread Prem (Premachandra) Mallappa
Hi Will, > > Is this workaround only needed for bypass STEs? If not, we have a problem > when we install a stage-1 entry, because we'll clear the EATS bits as it > stands. > Yes, this _was_ needed only in Bypass STEs, AFAIK. However, the h/w fixes that were committed recently has this worked o

Re: [PATCH v2 1/2] IOMMU: arm-smmu-v3: Fix broken STE.VALID check in Broadcom Vulcan

2015-12-17 Thread Will Deacon
Hi Prem, Thanks for the update. I still have a few questions though. On Thu, Dec 17, 2015 at 03:29:35PM +0530, Prem Mallappa wrote: > Vulcan SMMUv3 looks into more bits than necessary to validate the STE > entry (including EATS, S2PS, AARCH64), which is a overkill, but without > the proper encodi