Re: iommu_sva_bind_device question

2022-06-25 Thread Jerry Snitselaar
On Sat, Jun 25, 2022 at 12:52:27PM -0700, Fenghua Yu wrote: > Hi, Jerry and Baolu, > > On Fri, Jun 24, 2022 at 07:47:30AM -0700, Jerry Snitselaar wrote: > > > > > > > Hi Baolu & Dave, > > > > > fails. > > > > > > > > > > You also will get the following warning if you don't have scalable > > > >

Re: iommu_sva_bind_device question

2022-06-25 Thread Fenghua Yu
Hi, Jerry and Baolu, On Fri, Jun 24, 2022 at 07:47:30AM -0700, Jerry Snitselaar wrote: > > > > > > Hi Baolu & Dave, > > > > fails. > > > > > > > > You also will get the following warning if you don't have scalable > > > > mode enabled (either not enabled by default, or if enabled by default > >

Re: iommu_sva_bind_device question

2022-06-24 Thread Jerry Snitselaar
On Fri, Jun 24, 2022 at 06:41:02AM -0700, Jerry Snitselaar wrote: > On Fri, Jun 24, 2022 at 09:43:30AM +0800, Baolu Lu wrote: > > On 2022/6/24 09:14, Jerry Snitselaar wrote: > > > On Fri, Jun 24, 2022 at 08:55:08AM +0800, Baolu Lu wrote: > > > > On 2022/6/24 01:02, Jerry Snitselaar wrote: > > > >

Re: iommu_sva_bind_device question

2022-06-24 Thread Jerry Snitselaar
On Fri, Jun 24, 2022 at 09:43:30AM +0800, Baolu Lu wrote: > On 2022/6/24 09:14, Jerry Snitselaar wrote: > > On Fri, Jun 24, 2022 at 08:55:08AM +0800, Baolu Lu wrote: > > > On 2022/6/24 01:02, Jerry Snitselaar wrote: > > > > Hi Baolu & Dave, > > > > > > > > I noticed last night that on a Sapphire

Re: iommu_sva_bind_device question

2022-06-23 Thread Baolu Lu
On 2022/6/24 09:14, Jerry Snitselaar wrote: On Fri, Jun 24, 2022 at 08:55:08AM +0800, Baolu Lu wrote: On 2022/6/24 01:02, Jerry Snitselaar wrote: Hi Baolu & Dave, I noticed last night that on a Sapphire Rapids system if you boot without intel_iommu=on, the idxd driver will crash during probe

Re: iommu_sva_bind_device question

2022-06-23 Thread Jerry Snitselaar
On Fri, Jun 24, 2022 at 08:55:08AM +0800, Baolu Lu wrote: > On 2022/6/24 01:02, Jerry Snitselaar wrote: > > Hi Baolu & Dave, > > > > I noticed last night that on a Sapphire Rapids system if you boot without > > intel_iommu=on, the idxd driver will crash during probe in > >

Re: iommu_sva_bind_device question

2022-06-23 Thread Baolu Lu
On 2022/6/24 01:02, Jerry Snitselaar wrote: Hi Baolu & Dave, I noticed last night that on a Sapphire Rapids system if you boot without intel_iommu=on, the idxd driver will crash during probe in iommu_sva_bind_device(). Should there be a sanity check before calling dev_iommu_ops(), or is the

iommu_sva_bind_device question

2022-06-23 Thread Jerry Snitselaar
Hi Baolu & Dave, I noticed last night that on a Sapphire Rapids system if you boot without intel_iommu=on, the idxd driver will crash during probe in iommu_sva_bind_device(). Should there be a sanity check before calling dev_iommu_ops(), or is the expectation that the caller would verify it is