Re: of_dma_request_slave_channel() failed ?

2018-09-14 Thread Geert Uytterhoeven
Hi Morimoto-san, On Fri, Sep 14, 2018 at 2:53 AM Kuninori Morimoto wrote: > > > Before 6c92d5a2744e2761 patch, driver will forcibly ignore > > > non-SSI modules, and try to use PIO mode. > > > I'm not sure it is "kindly support" or "overkill support". > > > > > > After this patch, it needs DMA,

Re: of_dma_request_slave_channel() failed ?

2018-09-13 Thread Kuninori Morimoto
Hi Geert > > ...which is in fact the exact same problem that the IOMMU code has - > > might it make sense to give of_dma_request_slave_channel() similar > > (optional?) driver_deferred_probe_check_state() logic, i.e. "if my DMAC > > driver's not shown up by this point, assume it's not built-in

Re: of_dma_request_slave_channel() failed ?

2018-09-13 Thread Kuninori Morimoto
Hi Geert > > Before 6c92d5a2744e2761 patch, driver will forcibly ignore > > non-SSI modules, and try to use PIO mode. > > I'm not sure it is "kindly support" or "overkill support". > > > > After this patch, it needs DMA, otherwise, probe will be failed. > > DT shouldn't have non-SSI modules if

Re: of_dma_request_slave_channel() failed ?

2018-09-13 Thread Geert Uytterhoeven
Hi Robin, On Thu, Sep 13, 2018 at 12:12 PM Robin Murphy wrote: > On 13/09/18 10:00, Geert Uytterhoeven wrote: > [...] > > The main issue is that if of_dma_find_controller() fails, a DMA slave driver > > cannot distinguish between dmac not yet probed successfully, and dmac > > driver not present.

Re: of_dma_request_slave_channel() failed ?

2018-09-13 Thread Robin Murphy
On 13/09/18 10:00, Geert Uytterhoeven wrote: [...] The main issue is that if of_dma_find_controller() fails, a DMA slave driver cannot distinguish between dmac not yet probed successfully, and dmac driver not present. ...which is in fact the exact same problem that the IOMMU code has - might

Re: of_dma_request_slave_channel() failed ?

2018-09-13 Thread Geert Uytterhoeven
Hi Mark, On Wed, Sep 12, 2018 at 5:51 PM Mark Brown wrote: > On Tue, Sep 11, 2018 at 11:43:47AM +0200, Geert Uytterhoeven wrote: > > So it seems the audio DMAC is deferred a second time, before the iommu > > driver > > probed. > > Shouldn't there be at least one more round of deferred probe

Re: of_dma_request_slave_channel() failed ?

2018-09-13 Thread Geert Uytterhoeven
Hi Morimoto-san, On Thu, Sep 13, 2018 at 7:48 AM Kuninori Morimoto wrote: > > > - > > > commit ac6bbf0cdf4206c517ac9789814c23e372ebce4d > > > Author: Rob Herring > > > Date: Mon Jul 9 09:41:52 2018 -0600 > > > > > > iommu: Remove

Re: of_dma_request_slave_channel() failed ?

2018-09-12 Thread Kuninori Morimoto
Hi Geert Thank you for your feedback > > - > > commit ac6bbf0cdf4206c517ac9789814c23e372ebce4d > > Author: Rob Herring > > Date: Mon Jul 9 09:41:52 2018 -0600 > > > > iommu: Remove IOMMU_OF_DECLARE > > > > Now that we use the

Re: of_dma_request_slave_channel() failed ?

2018-09-12 Thread Mark Brown
On Tue, Sep 11, 2018 at 11:43:47AM +0200, Geert Uytterhoeven wrote: > So it seems the audio DMAC is deferred a second time, before the iommu driver > probed. Shouldn't there be at least one more round of deferred probe triggers after the IOMMU probes? signature.asc Description: PGP signature

Re: of_dma_request_slave_channel() failed ?

2018-09-11 Thread Geert Uytterhoeven
Hi Morimoto-san, CC asoc, dma, iommu On Tue, Sep 4, 2018 at 8:06 AM Kuninori Morimoto wrote: > Hi Renesas ML > Cc Rob > > I noticed that Sound driver is using PIO mode > on latest kernel. > > ... > rcar_sound ec50.sound: src[0] : probe error -11 > rcar_sound