Re: [dev] how to share "same platform ID" among iotivity stack instances?

2018-09-04 Thread Joo-Chul Lee
Hi Gregg, In my understanding, usually, OCF app (== a process) is a "logical device" which has its own /oic/p and /oic/d. An OCF platform is a physical device, and it may host more than one "logical device" in it, and they share same "physical ID" among them. Thanks & BR - Kevin On Wed, Sep 5,

Re: [dev] how to share "same platform ID" among iotivity stack instances?

2018-09-04 Thread Joo-Chul Lee
Hi Nathan, Thank you for explanation. I have more questions about it. Is the ".dat" file used to store default resource values same as the ".dat" file used to store SVR during/after onboarding ? If not, then, does the ".dat" file have any specific format (json or something) ? Thanks & BR - Kev

Re: [dev] anybody know about windows builds on 1.3-rel?

2018-09-04 Thread Nathan Heldt-Sheller
Hi Mats, I'm not sure why these tests specifically would fail, as they appear to be testing the CBOR conversion code which should be unchanged. However the /amacl Resource itself is not even instantiated in IoTivity, and the implementation is incomplete (see "AMACL_RESOURCE_IMPLEMENTATION_COMP

Re: [dev] Inefficient code reviews

2018-09-04 Thread Mats Wichmann
On 09/04/2018 02:46 PM, Gregg Reynolds wrote: > It's a general problem. I submitted an absolutely trivial but critical > patch when I got started that languished for months. Thats one reason I no > longer bother. With gerrit you have to pick your reviewers, AFAIK. So I'm > subscribed to the iotiv

Re: [dev] Inefficient code reviews

2018-09-04 Thread Gregg Reynolds
On Wed, Aug 29, 2018, 7:47 PM Rami Alshafi wrote: > Devs, > > I have extremely simple code review that I submitted 3 weeks ago. It > mainly includes changes in README file, white space modifications (based on > previous code reviews) and fixing a minor issue with the sample app SVR > database. >

Re: [dev] Call for review

2018-09-04 Thread Gregg Reynolds
On Tue, Sep 4, 2018, 2:51 AM Ondrej Tomcik wrote: > Hello, > > Would like to ask you to review these changes > > https://gerrit.iotivity.org/gerrit/#/c/26853/1 > g_sessionlist is static, only used in one file? If so, why "g_"? > https://gerrit.iotivity.org/gerrit/#/c/26849/1 > > https://gerrit.i

Re: [dev] how to share "same platform ID" among iotivity stack instances?

2018-09-04 Thread Gregg Reynolds
On Tue, Sep 4, 2018, 12:51 PM Nathan Heldt-Sheller < nathan.heldt-shel...@intel.com> wrote: > Hi Kevin, > > > > If I’ve understood your question correctly, the answer is that the > manufacturer would set the platform ID to the same value for all the > Devices on the platform prior to shipping the

Re: [dev] how to share "same platform ID" among iotivity stack instances?

2018-09-04 Thread Nathan Heldt-Sheller
Hi Kevin, If I’ve understood your question correctly, the answer is that the manufacturer would set the platform ID to the same value for all the Devices on the platform prior to shipping the product. In IoTivity, this is done via the .dat file that IoTivity loads many default Resource values

[dev] Call for review

2018-09-04 Thread Ondrej Tomcik
Hello, Would like to ask you to review these changes https://gerrit.iotivity.org/gerrit/#/c/26853/1 https://gerrit.iotivity.org/gerrit/#/c/26849/1 https://gerrit.iotivity.org/gerrit/#/c/26851/1 Thanks Ondrej Tomcik :: KISTLER :: measure, analyze, inovate -=-=-=-=-=-=-=-=-=-=-=- Links: You recei