Re: [iovisor-dev] [PATCH RFC v2] bpf: allow map helpers access to map values directly

2017-09-19 Thread Alexei Starovoitov via iovisor-dev
On Mon, Sep 18, 2017 at 11:14 AM, Paul Chaignon wrote: >> > + BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, >> > + offsetof(struct test_val, foo)), >> >> there are few bugs here. >> 1. it adds 4 byte, so it should have been rejected

Re: [iovisor-dev] reminder: IO Visor TSC/Dev Meeting

2017-09-19 Thread Alexei Starovoitov via iovisor-dev
I won't be able to make it. On Tue, Sep 19, 2017 at 7:53 PM, Brenden Blanco via iovisor-dev wrote: > Please join us tomorrow for our bi-weekly call. As usual, this meeting is > open to everybody and completely optional. > You might be interested to join if: > You

[iovisor-dev] reminder: IO Visor TSC/Dev Meeting

2017-09-19 Thread Brenden Blanco via iovisor-dev
Please join us tomorrow for our bi-weekly call. As usual, this meeting is open to everybody and completely optional. You might be interested to join if: You want to know what is going on in BPF land You are doing something interesting yourself with BPF and would like to share You want to know what

Re: [iovisor-dev] [PATCH RFC 0/4] Initial 32-bit eBPF encoding support

2017-09-19 Thread Jiong Wang via iovisor-dev
On 18/09/2017 22:29, Daniel Borkmann wrote: On 09/18/2017 10:47 PM, Jiong Wang wrote: Hi,    Currently, LLVM eBPF backend always generate code in 64-bit mode, this may cause troubles when JITing to 32-bit targets.    For example, it is quite common for XDP eBPF program to access some

Re: [iovisor-dev] [PATCH RFC 3/4] New 32-bit register set

2017-09-19 Thread Jiong Wang via iovisor-dev
On 19/09/2017 07:44, Y Song wrote: Hi, Jiong, Thanks for the patch! It is a great start to support 32bit register in BPF. In the past, I have studied a little bit to see whether 32bit register support may reduce the number of unnecessary shifts on x86_64 and improve the performance. Looking

Re: [iovisor-dev] [PATCH RFC 0/4] Initial 32-bit eBPF encoding support

2017-09-19 Thread Jiong Wang via iovisor-dev
On 19/09/2017 05:49, Fulvio Risso wrote: Dear Jiong, that's a great work. I havent' gone through the whole patches, but it seems to me that the documentation is not that much. From my past experiences, putting your hands into a compiler without at least some high-level documentation that