Re: [Ipmitool-devel] [PATCH v2] add support for delloem getsysinfo/setsysinfo (store OS information to BMC)

2012-08-08 Thread Jim Mankovich
Jordan, You left some cruft in lib/ipmi_delloem.c that you no longer need. Per the IPMI Spec, request 2 is System name, not a hostname. Please change the command argument from "hostname" to "system_name" so users aren't confused about how to interpret the string returned. From the IPMI Spec p

Re: [Ipmitool-devel] [PATCH v2] add support for delloem getsysinfo/setsysinfo (store OS information to BMC)

2012-08-08 Thread Andy Cress
Jordan, You commented "and added tests for the Dell-specific commands." Where? I don't see anything in this sysinfo code that is not in the IPMI spec addendum. Andy -- Live Security Virtual Conference Exclusive live ev

Re: [Ipmitool-devel] ipmitool 1.8.12 release this week

2012-08-08 Thread Carson Gaspar
On 8/7/12 8:56 PM, Zdenek Styblik wrote: > On Wed, Aug 8, 2012 at 3:19 AM, Carson Gaspar > wrote: >> Where does the struct_member_name: value syntax even come from? Every > > Can you post stdout/stderr/logs? My guess is this is not a problem, > but rather pre-processor/compiler tripping all over

Re: [Ipmitool-devel] ipmitool 1.8.12 release this week

2012-08-08 Thread Carson Gaspar
On 8/8/12 8:54 AM, Jim Mankovich wrote: > Carson, > > The struct_member_name:value syntax was obsoleted in GCC 2.5 See: > http://gcc.gnu.org/onlinedocs/gcc-4.4.1/gcc/Designated-Inits.html#Designated-Inits > > The right thing to do is to change these to .struct_member_name = > value syntax, which is

[Ipmitool-devel] [PATCH v2] add support for delloem getsysinfo/setsysinfo (store OS information to BMC)

2012-08-08 Thread Jordan_Hargrave
I have moved the common code for getsysinfo/setsysinfo to ipmi_mc and added tests for the Dell-specific commands. Index: doc/ipmitool.1 === RCS file: /cvsroot/ipmitool/ipmitool/doc/ipmitool.1,v retrieving revision 1.48 diff -u -p -b

Re: [Ipmitool-devel] ipmitool 1.8.12 release this week

2012-08-08 Thread Jim Mankovich
Carson, The struct_member_name:value syntax was obsoleted in GCC 2.5 See: http://gcc.gnu.org/onlinedocs/gcc-4.4.1/gcc/Designated-Inits.html#Designated-Inits The right thing to do is to change these to .struct_member_name = value syntax, which is what you mentioned you did. I think the delloem

Re: [Ipmitool-devel] Ipmitool-devel Digest, Vol 74, Issue 6

2012-08-08 Thread Jim Mankovich
Carson, You should only get zero (IPMI_OEM_UNKNOWN) for the interface manufacturer_id or returned by ipmi_get_oem() when the interface has not been successfully opened or the IPMI BMC_GET_DEVICE_ID fails. Are you using these before the lanplus interface is open? Is it possible your platform is

Re: [Ipmitool-devel] Ipmitool-devel Digest, Vol 74, Issue 6

2012-08-08 Thread Jordan_Hargrave
> Message: 3 > Date: Wed, 08 Aug 2012 06:12:56 -0600 > From: Jim Mankovich > Subject: Re: [Ipmitool-devel] [PATCH] add support for delloem > getsysinfo/setsysinfo (store OS information to BMC) > To: ipmitool-devel@lists.sourceforge.net > Message-ID: <502257c8.8090...@hp.com> > Content-Type

Re: [Ipmitool-devel] [PATCH] add support for delloem getsysinfo/setsysinfo (store OS information to BMC)

2012-08-08 Thread Jim Mankovich
Jordan, Another option would be to make this as part of the "mc" command, as Al suggested, and use if ( intf->manufacturer_id == IPMI_OEM_DELL) { Dell specific code } to encapsulate the Dell OEM specific capabilities from the common capabilities? In doing it this way, the common "mc" command

Re: [Ipmitool-devel] [PATCH] Added system support to ipmievd

2012-08-08 Thread Zdenek Styblik
On Wed, Aug 8, 2012 at 8:29 AM, Jan Safranek wrote: > On 08/07/2012 10:21 PM, Zdenek Styblik wrote: >> On Fri, Aug 3, 2012 at 3:10 PM, Jan Safranek wrote: >>> Hi, >>> >>> I've encountered some problems with running ipmievd under systemd - it does >>> not >>> understand the way how ipmievd forks